mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-25 14:11:14 +00:00
Aaro Altonen
e71c484d5b
This commit introduces a new concept called `NotificationService` which allows Polkadot protocols to communicate with the underlying notification protocol implementation directly, without routing events through `NetworkWorker`. This implies that each protocol has its own service which it uses to communicate with remote peers and that each `NotificationService` is unique with respect to the underlying notification protocol, meaning `NotificationService` for the transaction protocol can only be used to send and receive transaction-related notifications. The `NotificationService` concept introduces two additional benefits: * allow protocols to start using custom handshakes * allow protocols to accept/reject inbound peers Previously the validation of inbound connections was solely the responsibility of `ProtocolController`. This caused issues with light peers and `SyncingEngine` as `ProtocolController` would accept more peers than `SyncingEngine` could accept which caused peers to have differing views of their own states. `SyncingEngine` would reject excess peers but these rejections were not properly communicated to those peers causing them to assume that they were accepted. With `NotificationService`, the local handshake is not sent to remote peer if peer is rejected which allows it to detect that it was rejected. This commit also deprecates the use of `NetworkEventStream` for all notification-related events and going forward only DHT events are provided through `NetworkEventStream`. If protocols wish to follow each other's events, they must introduce additional abtractions, as is done for GRANDPA and transactions protocols by following the syncing protocol through `SyncEventStream`. Fixes https://github.com/paritytech/polkadot-sdk/issues/512 Fixes https://github.com/paritytech/polkadot-sdk/issues/514 Fixes https://github.com/paritytech/polkadot-sdk/issues/515 Fixes https://github.com/paritytech/polkadot-sdk/issues/554 Fixes https://github.com/paritytech/polkadot-sdk/issues/556 --- These changes are transferred from https://github.com/paritytech/substrate/pull/14197 but there are no functional changes compared to that PR --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
36 lines
1.1 KiB
TOML
36 lines
1.1 KiB
TOML
[package]
|
|
description = "Gossiping for the Substrate network protocol"
|
|
name = "sc-network-gossip"
|
|
version = "0.10.0-dev"
|
|
license = "GPL-3.0-or-later WITH Classpath-exception-2.0"
|
|
authors.workspace = true
|
|
edition.workspace = true
|
|
homepage = "https://substrate.io"
|
|
repository.workspace = true
|
|
documentation = "https://docs.rs/sc-network-gossip"
|
|
readme = "README.md"
|
|
|
|
[package.metadata.docs.rs]
|
|
targets = ["x86_64-unknown-linux-gnu"]
|
|
|
|
[dependencies]
|
|
ahash = "0.8.2"
|
|
futures = "0.3.21"
|
|
futures-timer = "3.0.1"
|
|
libp2p = "0.51.3"
|
|
log = "0.4.17"
|
|
schnellru = "0.2.1"
|
|
tracing = "0.1.29"
|
|
prometheus-endpoint = { package = "substrate-prometheus-endpoint", path = "../../utils/prometheus" }
|
|
sc-network = { path = "../network" }
|
|
sc-network-common = { path = "../network/common" }
|
|
sc-network-sync = { path = "../network/sync" }
|
|
sp-runtime = { path = "../../primitives/runtime" }
|
|
|
|
[dev-dependencies]
|
|
tokio = "1.22.0"
|
|
async-trait = "0.1.73"
|
|
codec = { package = "parity-scale-codec", version = "3.0.0", features = [ "derive" ] }
|
|
quickcheck = { version = "1.0.3", default-features = false }
|
|
substrate-test-runtime-client = { path = "../../test-utils/runtime/client" }
|