mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-30 10:31:03 +00:00
Oliver Tale-Yazdi
e1c033ebe1
(imported from https://github.com/paritytech/cumulus/pull/2157) ## Changes This MR refactores the XCMP, Parachains System and DMP pallets to use the [MessageQueue](https://github.com/paritytech/substrate/pull/12485) for delayed execution of incoming messages. The DMP pallet is entirely replaced by the MQ and thereby removed. This allows for PoV-bounded execution and resolves a number of issues that stem from the current work-around. All System Parachains adopt this change. The most important changes are in `primitives/core/src/lib.rs`, `parachains/common/src/process_xcm_message.rs`, `pallets/parachain-system/src/lib.rs`, `pallets/xcmp-queue/src/lib.rs` and the runtime configs. ### DMP Queue Pallet The pallet got removed and its logic refactored into parachain-system. Overweight message management can be done directly through the MQ pallet. Final undeployment migrations are provided by `cumulus_pallet_dmp_queue::UndeployDmpQueue` and `DeleteDmpQueue` that can be configured with an aux config trait like: ```rust parameter_types! { pub const DmpQueuePalletName: &'static str = \"DmpQueue\" < CHANGE ME; pub const RelayOrigin: AggregateMessageOrigin = AggregateMessageOrigin::Parent; } impl cumulus_pallet_dmp_queue::MigrationConfig for Runtime { type PalletName = DmpQueuePalletName; type DmpHandler = frame_support::traits::EnqueueWithOrigin<MessageQueue, RelayOrigin>; type DbWeight = <Runtime as frame_system::Config>::DbWeight; } // And adding them to your Migrations tuple: pub type Migrations = ( ... cumulus_pallet_dmp_queue::UndeployDmpQueue<Runtime>, cumulus_pallet_dmp_queue::DeleteDmpQueue<Runtime>, ); ``` ### XCMP Queue pallet Removed all dispatch queue functionality. Incoming XCMP messages are now either: Immediately handled if they are Signals, enqueued into the MQ pallet otherwise. New config items for the XCMP queue pallet: ```rust /// The actual queue implementation that retains the messages for later processing. type XcmpQueue: EnqueueMessage<ParaId>; /// How a XCM over HRMP from a sibling parachain should be processed. type XcmpProcessor: ProcessMessage<Origin = ParaId>; /// The maximal number of suspended XCMP channels at the same time. #[pallet::constant] type MaxInboundSuspended: Get<u32>; ``` How to configure those: ```rust // Use the MessageQueue pallet to store messages for later processing. The `TransformOrigin` is needed since // the MQ pallet itself operators on `AggregateMessageOrigin` but we want to enqueue `ParaId`s. type XcmpQueue = TransformOrigin<MessageQueue, AggregateMessageOrigin, ParaId, ParaIdToSibling>; // Process XCMP messages from siblings. This is type-safe to only accept `ParaId`s. They will be dispatched // with origin `Junction::Sibling(…)`. type XcmpProcessor = ProcessFromSibling< ProcessXcmMessage< AggregateMessageOrigin, xcm_executor::XcmExecutor<xcm_config::XcmConfig>, RuntimeCall, >, >; // Not really important what to choose here. Just something larger than the maximal number of channels. type MaxInboundSuspended = sp_core::ConstU32<1_000>; ``` The `InboundXcmpStatus` storage item was replaced by `InboundXcmpSuspended` since it now only tracks inbound queue suspension and no message indices anymore. Now only sends the most recent channel `Signals`, as all prio ones are out-dated anyway. ### Parachain System pallet For `DMP` messages instead of forwarding them to the `DMP` pallet, it now pushes them to the configured `DmpQueue`. The message processing which was triggered in `set_validation_data` is now being done by the MQ pallet `on_initialize`. XCMP messages are still handed off to the `XcmpMessageHandler` (XCMP-Queue pallet) - no change here. New config items for the parachain system pallet: ```rust /// Queues inbound downward messages for delayed processing. /// /// Analogous to the `XcmpQueue` of the XCMP queue pallet. type DmpQueue: EnqueueMessage<AggregateMessageOrigin>; ``` How to configure: ```rust /// Use the MQ pallet to store DMP messages for delayed processing. type DmpQueue = MessageQueue; ``` ## Message Flow The flow of messages on the parachain side. Messages come in from the left via the `Validation Data` and finally end up at the `Xcm Executor` on the right.  ## Further changes - Bumped the default suspension, drop and resume thresholds in `QueueConfigData::default()`. - `XcmpQueue::{suspend_xcm_execution, resume_xcm_execution}` errors when they would be a noop. - Properly validate the `QueueConfigData` before setting it. - Marked weight files as auto-generated so they wont auto-expand in the MR files view. - Move the `hypothetical` asserts to `frame_support` under the name `experimental_hypothetically` Questions: - [ ] What about the ugly `#[cfg(feature = \"runtime-benchmarks\")]` in the runtimes? Not sure how to best fix. Just having them like this makes tests fail that rely on the real message processor when the feature is enabled. - [ ] Need a good weight for `MessageQueueServiceWeight`. The scheduler already takes 80% so I put it to 10% but that is quite low. TODO: - [x] Remove c&p code after https://github.com/paritytech/polkadot/pull/6271 - [x] Use `HandleMessage` once it is public in Substrate - [x] fix `runtime-benchmarks` feature https://github.com/paritytech/polkadot/pull/6966 - [x] Benchmarks - [x] Tests - [ ] Migrate `InboundXcmpStatus` to `InboundXcmpSuspended` - [x] Possibly cleanup Migrations (DMP+XCMP) - [x] optional: create `TransformProcessMessageOrigin` in Substrate and replace `ProcessFromSibling` - [ ] Rerun weights on ref HW --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: command-bot <>
254 lines
13 KiB
TOML
254 lines
13 KiB
TOML
[package]
|
|
name = "bridge-hub-rococo-runtime"
|
|
version = "0.1.0"
|
|
authors.workspace = true
|
|
edition.workspace = true
|
|
description = "Rococo's BridgeHub parachain runtime"
|
|
license = "Apache-2.0"
|
|
|
|
[build-dependencies]
|
|
substrate-wasm-builder = { path = "../../../../../substrate/utils/wasm-builder", optional = true }
|
|
|
|
[dependencies]
|
|
codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
|
|
hex-literal = { version = "0.4.1" }
|
|
log = { version = "0.4.20", default-features = false }
|
|
scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
|
|
serde = { version = "1.0.188", optional = true, features = ["derive"] }
|
|
smallvec = "1.11.0"
|
|
|
|
# Substrate
|
|
frame-benchmarking = { path = "../../../../../substrate/frame/benchmarking", default-features = false, optional = true}
|
|
frame-executive = { path = "../../../../../substrate/frame/executive", default-features = false}
|
|
frame-support = { path = "../../../../../substrate/frame/support", default-features = false}
|
|
frame-system = { path = "../../../../../substrate/frame/system", default-features = false}
|
|
frame-system-benchmarking = { path = "../../../../../substrate/frame/system/benchmarking", default-features = false, optional = true}
|
|
frame-system-rpc-runtime-api = { path = "../../../../../substrate/frame/system/rpc/runtime-api", default-features = false}
|
|
frame-try-runtime = { path = "../../../../../substrate/frame/try-runtime", default-features = false, optional = true}
|
|
pallet-aura = { path = "../../../../../substrate/frame/aura", default-features = false}
|
|
pallet-authorship = { path = "../../../../../substrate/frame/authorship", default-features = false}
|
|
pallet-balances = { path = "../../../../../substrate/frame/balances", default-features = false}
|
|
pallet-session = { path = "../../../../../substrate/frame/session", default-features = false}
|
|
pallet-multisig = { path = "../../../../../substrate/frame/multisig", default-features = false}
|
|
pallet-timestamp = { path = "../../../../../substrate/frame/timestamp", default-features = false}
|
|
pallet-transaction-payment = { path = "../../../../../substrate/frame/transaction-payment", default-features = false}
|
|
pallet-transaction-payment-rpc-runtime-api = { path = "../../../../../substrate/frame/transaction-payment/rpc/runtime-api", default-features = false}
|
|
pallet-utility = { path = "../../../../../substrate/frame/utility", default-features = false}
|
|
sp-api = { path = "../../../../../substrate/primitives/api", default-features = false}
|
|
sp-block-builder = { path = "../../../../../substrate/primitives/block-builder", default-features = false}
|
|
sp-consensus-aura = { path = "../../../../../substrate/primitives/consensus/aura", default-features = false}
|
|
sp-core = { path = "../../../../../substrate/primitives/core", default-features = false}
|
|
sp-genesis-builder = { path = "../../../../../substrate/primitives/genesis-builder", default-features = false }
|
|
sp-inherents = { path = "../../../../../substrate/primitives/inherents", default-features = false}
|
|
sp-io = { path = "../../../../../substrate/primitives/io", default-features = false}
|
|
sp-offchain = { path = "../../../../../substrate/primitives/offchain", default-features = false}
|
|
sp-runtime = { path = "../../../../../substrate/primitives/runtime", default-features = false}
|
|
sp-session = { path = "../../../../../substrate/primitives/session", default-features = false}
|
|
sp-std = { path = "../../../../../substrate/primitives/std", default-features = false}
|
|
sp-storage = { path = "../../../../../substrate/primitives/storage", default-features = false}
|
|
sp-transaction-pool = { path = "../../../../../substrate/primitives/transaction-pool", default-features = false}
|
|
sp-version = { path = "../../../../../substrate/primitives/version", default-features = false}
|
|
|
|
# Polkadot
|
|
rococo-runtime-constants = { path = "../../../../../polkadot/runtime/rococo/constants", default-features = false}
|
|
pallet-xcm = { path = "../../../../../polkadot/xcm/pallet-xcm", default-features = false}
|
|
pallet-xcm-benchmarks = { path = "../../../../../polkadot/xcm/pallet-xcm-benchmarks", default-features = false, optional = true }
|
|
polkadot-core-primitives = { path = "../../../../../polkadot/core-primitives", default-features = false}
|
|
polkadot-parachain-primitives = { path = "../../../../../polkadot/parachain", default-features = false}
|
|
polkadot-runtime-common = { path = "../../../../../polkadot/runtime/common", default-features = false}
|
|
xcm = { package = "staging-xcm", path = "../../../../../polkadot/xcm", default-features = false}
|
|
xcm-builder = { package = "staging-xcm-builder", path = "../../../../../polkadot/xcm/xcm-builder", default-features = false}
|
|
xcm-executor = { package = "staging-xcm-executor", path = "../../../../../polkadot/xcm/xcm-executor", default-features = false}
|
|
|
|
# Cumulus
|
|
cumulus-pallet-aura-ext = { path = "../../../../pallets/aura-ext", default-features = false }
|
|
pallet-message-queue = { path = "../../../../../substrate/frame/message-queue", default-features = false }
|
|
cumulus-pallet-dmp-queue = { path = "../../../../pallets/dmp-queue", default-features = false }
|
|
cumulus-pallet-parachain-system = { path = "../../../../pallets/parachain-system", default-features = false, features = ["parameterized-consensus-hook",] }
|
|
cumulus-pallet-session-benchmarking = { path = "../../../../pallets/session-benchmarking", default-features = false}
|
|
cumulus-pallet-xcm = { path = "../../../../pallets/xcm", default-features = false }
|
|
cumulus-pallet-xcmp-queue = { path = "../../../../pallets/xcmp-queue", default-features = false, features = ["bridging"] }
|
|
cumulus-primitives-core = { path = "../../../../primitives/core", default-features = false }
|
|
cumulus-primitives-utility = { path = "../../../../primitives/utility", default-features = false }
|
|
pallet-collator-selection = { path = "../../../../pallets/collator-selection", default-features = false }
|
|
parachain-info = { package = "staging-parachain-info", path = "../../../pallets/parachain-info", default-features = false }
|
|
parachains-common = { path = "../../../common", default-features = false }
|
|
|
|
# Bridges
|
|
bp-asset-hub-rococo = { path = "../../../../../bridges/primitives/chain-asset-hub-rococo", default-features = false }
|
|
bp-asset-hub-westend = { path = "../../../../../bridges/primitives/chain-asset-hub-westend", default-features = false }
|
|
bp-asset-hub-wococo = { path = "../../../../../bridges/primitives/chain-asset-hub-wococo", default-features = false }
|
|
bp-bridge-hub-rococo = { path = "../../../../../bridges/primitives/chain-bridge-hub-rococo", default-features = false }
|
|
bp-bridge-hub-westend = { path = "../../../../../bridges/primitives/chain-bridge-hub-westend", default-features = false }
|
|
bp-bridge-hub-wococo = { path = "../../../../../bridges/primitives/chain-bridge-hub-wococo", default-features = false }
|
|
bp-header-chain = { path = "../../../../../bridges/primitives/header-chain", default-features = false }
|
|
bp-messages = { path = "../../../../../bridges/primitives/messages", default-features = false }
|
|
bp-parachains = { path = "../../../../../bridges/primitives/parachains", default-features = false }
|
|
bp-polkadot-core = { path = "../../../../../bridges/primitives/polkadot-core", default-features = false }
|
|
bp-relayers = { path = "../../../../../bridges/primitives/relayers", default-features = false }
|
|
bp-runtime = { path = "../../../../../bridges/primitives/runtime", default-features = false }
|
|
bp-rococo = { path = "../../../../../bridges/primitives/chain-rococo", default-features = false }
|
|
bp-westend = { path = "../../../../../bridges/primitives/chain-westend", default-features = false }
|
|
bp-wococo = { path = "../../../../../bridges/primitives/chain-wococo", default-features = false }
|
|
pallet-bridge-grandpa = { path = "../../../../../bridges/modules/grandpa", default-features = false }
|
|
pallet-bridge-messages = { path = "../../../../../bridges/modules/messages", default-features = false }
|
|
pallet-bridge-parachains = { path = "../../../../../bridges/modules/parachains", default-features = false }
|
|
pallet-bridge-relayers = { path = "../../../../../bridges/modules/relayers", default-features = false }
|
|
bridge-runtime-common = { path = "../../../../../bridges/bin/runtime-common", default-features = false }
|
|
|
|
[dev-dependencies]
|
|
static_assertions = "1.1"
|
|
bridge-hub-test-utils = { path = "../test-utils" }
|
|
bridge-runtime-common = { path = "../../../../../bridges/bin/runtime-common", features = ["integrity-test"] }
|
|
sp-keyring = { path = "../../../../../substrate/primitives/keyring" }
|
|
|
|
[features]
|
|
default = [ "std" ]
|
|
std = [
|
|
"bp-asset-hub-rococo/std",
|
|
"bp-asset-hub-westend/std",
|
|
"bp-asset-hub-wococo/std",
|
|
"bp-bridge-hub-rococo/std",
|
|
"bp-bridge-hub-westend/std",
|
|
"bp-bridge-hub-wococo/std",
|
|
"bp-header-chain/std",
|
|
"bp-messages/std",
|
|
"bp-parachains/std",
|
|
"bp-polkadot-core/std",
|
|
"bp-relayers/std",
|
|
"bp-rococo/std",
|
|
"bp-runtime/std",
|
|
"bp-westend/std",
|
|
"bp-wococo/std",
|
|
"bridge-runtime-common/std",
|
|
"codec/std",
|
|
"cumulus-pallet-aura-ext/std",
|
|
"cumulus-pallet-dmp-queue/std",
|
|
"cumulus-pallet-parachain-system/std",
|
|
"cumulus-pallet-session-benchmarking/std",
|
|
"cumulus-pallet-xcm/std",
|
|
"cumulus-pallet-xcmp-queue/std",
|
|
"cumulus-primitives-core/std",
|
|
"cumulus-primitives-utility/std",
|
|
"frame-benchmarking/std",
|
|
"frame-executive/std",
|
|
"frame-support/std",
|
|
"frame-system-benchmarking?/std",
|
|
"frame-system-rpc-runtime-api/std",
|
|
"frame-system/std",
|
|
"frame-try-runtime?/std",
|
|
"log/std",
|
|
"pallet-aura/std",
|
|
"pallet-authorship/std",
|
|
"pallet-balances/std",
|
|
"pallet-bridge-grandpa/std",
|
|
"pallet-bridge-messages/std",
|
|
"pallet-bridge-parachains/std",
|
|
"pallet-bridge-relayers/std",
|
|
"pallet-collator-selection/std",
|
|
"pallet-message-queue/std",
|
|
"pallet-multisig/std",
|
|
"pallet-session/std",
|
|
"pallet-timestamp/std",
|
|
"pallet-transaction-payment-rpc-runtime-api/std",
|
|
"pallet-transaction-payment/std",
|
|
"pallet-utility/std",
|
|
"pallet-xcm-benchmarks?/std",
|
|
"pallet-xcm/std",
|
|
"parachain-info/std",
|
|
"parachains-common/std",
|
|
"polkadot-core-primitives/std",
|
|
"polkadot-parachain-primitives/std",
|
|
"polkadot-runtime-common/std",
|
|
"rococo-runtime-constants/std",
|
|
"scale-info/std",
|
|
"serde",
|
|
"sp-api/std",
|
|
"sp-block-builder/std",
|
|
"sp-consensus-aura/std",
|
|
"sp-core/std",
|
|
"sp-genesis-builder/std",
|
|
"sp-inherents/std",
|
|
"sp-io/std",
|
|
"sp-offchain/std",
|
|
"sp-runtime/std",
|
|
"sp-session/std",
|
|
"sp-std/std",
|
|
"sp-storage/std",
|
|
"sp-transaction-pool/std",
|
|
"sp-version/std",
|
|
"substrate-wasm-builder",
|
|
"xcm-builder/std",
|
|
"xcm-executor/std",
|
|
"xcm/std",
|
|
]
|
|
|
|
runtime-benchmarks = [
|
|
"bridge-runtime-common/runtime-benchmarks",
|
|
"cumulus-pallet-dmp-queue/runtime-benchmarks",
|
|
"cumulus-pallet-parachain-system/runtime-benchmarks",
|
|
"cumulus-pallet-session-benchmarking/runtime-benchmarks",
|
|
"cumulus-pallet-xcmp-queue/runtime-benchmarks",
|
|
"cumulus-primitives-core/runtime-benchmarks",
|
|
"cumulus-primitives-utility/runtime-benchmarks",
|
|
"frame-benchmarking/runtime-benchmarks",
|
|
"frame-support/runtime-benchmarks",
|
|
"frame-system-benchmarking/runtime-benchmarks",
|
|
"frame-system/runtime-benchmarks",
|
|
"pallet-balances/runtime-benchmarks",
|
|
"pallet-bridge-grandpa/runtime-benchmarks",
|
|
"pallet-bridge-messages/runtime-benchmarks",
|
|
"pallet-bridge-parachains/runtime-benchmarks",
|
|
"pallet-bridge-relayers/runtime-benchmarks",
|
|
"pallet-collator-selection/runtime-benchmarks",
|
|
"pallet-message-queue/runtime-benchmarks",
|
|
"pallet-multisig/runtime-benchmarks",
|
|
"pallet-timestamp/runtime-benchmarks",
|
|
"pallet-utility/runtime-benchmarks",
|
|
"pallet-xcm-benchmarks/runtime-benchmarks",
|
|
"pallet-xcm/runtime-benchmarks",
|
|
"parachains-common/runtime-benchmarks",
|
|
"polkadot-parachain-primitives/runtime-benchmarks",
|
|
"polkadot-runtime-common/runtime-benchmarks",
|
|
"sp-runtime/runtime-benchmarks",
|
|
"xcm-builder/runtime-benchmarks",
|
|
"xcm-executor/runtime-benchmarks",
|
|
]
|
|
|
|
try-runtime = [
|
|
"cumulus-pallet-aura-ext/try-runtime",
|
|
"cumulus-pallet-dmp-queue/try-runtime",
|
|
"cumulus-pallet-parachain-system/try-runtime",
|
|
"cumulus-pallet-xcm/try-runtime",
|
|
"cumulus-pallet-xcmp-queue/try-runtime",
|
|
"frame-executive/try-runtime",
|
|
"frame-support/try-runtime",
|
|
"frame-system/try-runtime",
|
|
"frame-try-runtime/try-runtime",
|
|
"pallet-aura/try-runtime",
|
|
"pallet-authorship/try-runtime",
|
|
"pallet-balances/try-runtime",
|
|
"pallet-bridge-grandpa/try-runtime",
|
|
"pallet-bridge-messages/try-runtime",
|
|
"pallet-bridge-parachains/try-runtime",
|
|
"pallet-bridge-relayers/try-runtime",
|
|
"pallet-collator-selection/try-runtime",
|
|
"pallet-message-queue/try-runtime",
|
|
"pallet-multisig/try-runtime",
|
|
"pallet-session/try-runtime",
|
|
"pallet-timestamp/try-runtime",
|
|
"pallet-transaction-payment/try-runtime",
|
|
"pallet-utility/try-runtime",
|
|
"pallet-xcm/try-runtime",
|
|
"parachain-info/try-runtime",
|
|
"polkadot-runtime-common/try-runtime",
|
|
"sp-runtime/try-runtime",
|
|
]
|
|
|
|
experimental = [ "pallet-aura/experimental" ]
|
|
|
|
# A feature that should be enabled when the runtime should be built for on-chain
|
|
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
|
|
# to make it smaller like logging for example.
|
|
on-chain-release-build = [ "sp-api/disable-logging" ]
|