pezkuwichain/pezkuwi-wallet-android
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-wallet-android.git synced 2026-07-22 19:35:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use raw org.mockito.Mockito statics instead of test_shared wrappers

Browse Source 
Root cause of 'eq(...) must not be null' NPE: test_shared's eq()/any()/
argThat() are thin Kotlin wrappers with a declared non-null generic return
type T. Mockito.eq()/any() genuinely return null at runtime (that's how
their matcher-stack recording works) - fine when called directly from
Kotlin (a raw Java static call's return is a platform type, no null-check
inserted), but going through a Kotlin-declared wrapper whose T infers as
non-null at the call site (e.g. eq(baseUrl: String) here) gets a
compiler-inserted null-check on the wrapper's return, which then fires.

Scoped this fix to this test file only rather than touching test_shared's
shared implementation, which every other module's tests also depend on.
This commit is contained in:
Satoshi Qazi Muhammed
2026-07-10 09:36:41 -07:00
parent fb1e0c9cf0
commit a8d2636f66
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
feature-wallet-impl/src/test/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionServiceTest.kt
+14 -4
View File
@@ -15,10 +15,6 @@ import io.novafoundation.nova.feature_wallet_impl.data.network.tron.TronGridApi
import io.novafoundation.nova.feature_wallet_impl.data.network.tron.model.TronAccountResourceResponse
import io.novafoundation.nova.feature_wallet_impl.data.network.tron.model.TronUnsignedTransactionResponse
import io.novafoundation.nova.runtime.multiNetwork.chain.model.Chain
import io.novafoundation.nova.test_shared.any
import io.novafoundation.nova.test_shared.argThat
import io.novafoundation.nova.test_shared.eq
import io.novafoundation.nova.test_shared.whenever
import io.novasama.substrate_sdk_android.encrypt.SignatureWrapper
import io.novasama.substrate_sdk_android.extensions.fromHex
import io.novasama.substrate_sdk_android.extensions.toHexString
@@ -31,11 +27,25 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.Mockito
import org.mockito.Mockito.any
import org.mockito.Mockito.argThat
import org.mockito.Mockito.eq
import org.mockito.Mockito.never
import org.mockito.Mockito.verify
import org.mockito.junit.MockitoJUnitRunner
import java.math.BigInteger
// Deliberately NOT using io.novafoundation.nova.test_shared's eq/any/argThat/whenever here: those are thin
// Kotlin wrappers around the raw org.mockito.Mockito statics, and a Kotlin function with a declared non-null
// generic return type T gets a compiler-inserted null-check on that return value whenever T is inferred as
// non-null at the call site (e.g. eq(baseUrl: String) here) - crashing with "eq(...) must not be null", since
// Mockito.eq()/any() genuinely return null at runtime (that's how their matcher-stack recording works). Calling
// org.mockito.Mockito's statics directly avoids this: Kotlin treats a direct Java static call's return as a
// platform type (T!) and does not insert that check. Fixing test_shared itself would apply project-wide and
// wasn't attempted here (shared-infra change out of scope for this test file).
private fun <T> whenever(methodCall: T?) = Mockito.`when`(methodCall)
/**
* Covers the native-TRX branch of [RealTronTransactionService.transact] - the sign/broadcast pipeline this class'
* own doc comment describes (sha256(raw_data) signed via the existing Ethereum-style ECDSA-raw-hash primitive,