mirror of
https://github.com/pezkuwichain/pwap.git
synced 2026-08-12 12:31:34 +00:00
pezkuwichain
e18ba679be
The migrations did not describe this database, and could not be made to.
Three findings, in the order they surfaced:
* 25 functions declared across six migrations — all recorded as applied — did
not exist. Their tables did. Two were reached by the app, so merchant tier
upgrades and post-trade reputation updates had been quietly dead. This only
came to light because a user hit "Could not find the function
public.upsert_user_profile(...)" while toggling a notification setting.
* admin_roles has three conflicting definitions across the set and production
matches none of them. 001 says (id, user_id, role, granted_by, granted_at),
COMBINED says (user_id, role, created_at), production has
(id, user_id, role, permissions, created_at, updated_at).
* Applied to an empty database, five migrations fail. The legacy 0NN filenames
sort before the 14-digit timestamps they depend on — "013" < "20241117054600"
— so 013 runs before the migration creating the table it alters. The set
could never have been replayed from scratch.
So it could not be tested, could not rebuild the database, and did not match what
was running. Widening or patching it would have been dressing up a history that
was already fiction.
The baseline is a pg_dump of the live public schema, which matches production by
construction. Privileges are included deliberately: the REVOKEs on
lock_escrow_internal, release_escrow_internal, refund_escrow_internal and
request_withdraw are the 20260725030000 hardening, and dropping them would hand
fund movement back to anon.
Verified step by step against production before committing:
- applies to an empty database cleanly, after three real obstacles were fixed
(extensions live in the `extensions` schema, supabase_admin membership,
platform-level ALTER DEFAULT PRIVILEGES that cannot apply outside Supabase)
- produces 83 tables / 39 functions / 222 indexes / 360 policies — identical
counts to production
- recorded as applied in supabase_migrations without touching the 37 existing
rows, then dry-run confirmed "up to date — no pending migrations", so the
next deploy will not try to replay it over live tables
- drift check now reports "every declared function is present"; the known-gaps
list drops from 22 entries to zero
The old files move to migrations/archive/ rather than being deleted — they are
the only record of why parts of this look the way they do. Their README says
plainly not to run them, and why.
CI now applies migrations to an empty Postgres on every PR. That check was
impossible while the old set was the starting point; it is the thing that stops
this class of drift from being discovered by a user again.
54 lines
2.4 KiB
Markdown
54 lines
2.4 KiB
Markdown
# Archived migrations
|
|
|
|
Superseded by `../00000000000000_baseline.sql` on 2026-08-01. Kept, not deleted:
|
|
they are the only record of why parts of the schema look the way they do, even
|
|
where they no longer describe it.
|
|
|
|
**Do not run these.** They are not a working migration set and several are unsafe
|
|
to replay.
|
|
|
|
## Why they were replaced
|
|
|
|
These files were applied by hand through the Supabase SQL editor over months —
|
|
most still carry `-- Run this in Supabase SQL Editor` headers. Some runs stopped
|
|
partway and were recorded as applied regardless, so the recorded history stopped
|
|
matching the database. Three things made that concrete:
|
|
|
|
**Functions declared but absent.** 25 functions across six migrations, all marked
|
|
applied, did not exist in the database. Their tables did. Two were reached by the
|
|
app, so merchant tier upgrades and post-trade reputation updates had been quietly
|
|
dead. Found on 2026-07-30 only because a user hit
|
|
`Could not find the function public.upsert_user_profile(...)` while toggling a
|
|
notification setting.
|
|
|
|
**Conflicting definitions.** `admin_roles` is defined three different ways and
|
|
production matches none of them:
|
|
|
|
| source | columns |
|
|
|---|---|
|
|
| `001_initial_schema.sql` | id, user_id, role, granted_by, granted_at |
|
|
| `COMBINED_p2p_full_system.sql` | user_id, role, created_at |
|
|
| production | id, user_id, role, permissions, created_at, updated_at |
|
|
|
|
**Not replayable.** Applied to an empty database, five of them fail. The legacy
|
|
`0NN` filenames sort before the 14-digit timestamps they depend on — `"013"` <
|
|
`"20241117054600"` — so `013` runs before the migration that creates the table it
|
|
alters. That ordering could never have worked from scratch.
|
|
|
|
## What replaced them
|
|
|
|
A `pg_dump` of the live `public` schema, which matches production by
|
|
construction. Verified: applying it to an empty database produces 83 tables, 39
|
|
functions, 222 indexes and 360 policies — identical counts to production.
|
|
|
|
CI now applies migrations to an empty Postgres on every PR, so a migration that
|
|
cannot run from scratch fails there instead of on the production host. That check
|
|
was impossible while this set was the starting point.
|
|
|
|
## If you need something from here
|
|
|
|
Read it, take the statement you need, and write a new forward migration against
|
|
the baseline. Do not re-run the file — `20241117054601` inserts payment methods
|
|
with no `ON CONFLICT`, `015` has 17 unguarded inserts, and `018` overwrites the
|
|
live hot wallet address.
|