remove temp_dir; tempfile has all we need

Cargo.lock

@@ -4492,6 +4492,7 @@ dependencies = [
  "semver 1.0.26",
  "serde",
  "serde_json",
+ "tempfile",
  "tokio",
  "tracing",
 ]
@@ -4504,7 +4505,7 @@ dependencies = [
  "clap",
  "semver 1.0.26",
  "serde",
- "temp-dir",
+ "tempfile",
 ]
 
 [[package]]
@@ -4530,7 +4531,6 @@ dependencies = [
  "semver 1.0.26",
  "serde",
  "serde_json",
- "temp-dir",
  "tempfile",
  "tokio",
  "tracing",
@@ -4572,7 +4572,7 @@ dependencies = [
  "serde_json",
  "sp-core",
  "sp-runtime",
- "temp-dir",
+ "tempfile",
  "tokio",
  "tracing",
 ]
@@ -5786,12 +5786,6 @@ version = "1.0.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "55937e1799185b12863d447f42597ed69d9928686b8d88a1df17376a097d8369"
 
-[[package]]
-name = "temp-dir"
-version = "0.1.16"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "83176759e9416cf81ee66cb6508dbfe9c96f20b8b56265a39917551c23c70964"
-
 [[package]]
 name = "tempfile"
 version = "3.20.0"

Cargo.toml

@@ -46,7 +46,6 @@ serde_json = { version = "1.0", default-features = false, features = [
 sha2 = { version = "0.10.9" }
 sp-core = "36.1.0"
 sp-runtime = "41.1.0"
-temp-dir = { version = "0.1.16" }
 tempfile = "3.3"
 thiserror = "2"
 tokio = { version = "1.47.0", default-features = false, features = [

crates/compiler/Cargo.toml

@@ -26,5 +26,8 @@ serde_json = { workspace = true }
 tracing = { workspace = true }
 tokio = { workspace = true }
 
+[dev-dependencies]
+tempfile = { workspace = true }
+
 [lints]
 workspace = true

crates/compiler/src/utils.rs

@@ -48,3 +48,28 @@ pub async fn solc_version(solc_path: &Path) -> anyhow::Result<semver::Version> {
         }
     }
 }
+
+#[cfg(test)]
+mod test {
+    use super::*;
+    use revive_dt_common::types::VersionOrRequirement;
+
+    #[tokio::test]
+    async fn compiler_version_can_be_obtained() {
+        // Arrange
+        let temp_dir = tempfile::tempdir().expect("can create tempdir");
+        let solc_path = revive_dt_solc_binaries::download_solc(
+            temp_dir.path(),
+            VersionOrRequirement::default(),
+            false,
+        )
+        .await
+        .expect("can download solc");
+
+        // Act
+        let version = solc_version(&solc_path).await;
+
+        // Assert
+        let _ = version.expect("Failed to get version");
+    }
+}

crates/config/Cargo.toml

@@ -12,7 +12,7 @@ rust-version.workspace = true
 alloy = { workspace = true }
 clap = { workspace = true }
 semver = { workspace = true }
-temp-dir = { workspace = true }
+tempfile = { workspace = true }
 serde = { workspace = true }
 
 [lints]

crates/config/src/lib.rs

@@ -10,7 +10,7 @@ use alloy::{network::EthereumWallet, signers::local::PrivateKeySigner};
 use clap::{Parser, ValueEnum};
 use semver::Version;
 use serde::{Deserialize, Serialize};
-use temp_dir::TempDir;
+use tempfile::TempDir;
 
 #[derive(Debug, Parser, Clone, Serialize, Deserialize)]
 #[command(name = "retester")]

crates/core/Cargo.toml

@@ -37,7 +37,6 @@ tracing-subscriber = { workspace = true }
 semver = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-temp-dir = { workspace = true }
 tempfile = { workspace = true }
 
 [lints]

crates/core/src/main.rs

@@ -18,7 +18,7 @@ use futures::StreamExt;
 use futures::stream;
 use indexmap::IndexMap;
 use revive_dt_node_interaction::EthereumNode;
-use temp_dir::TempDir;
+use tempfile::TempDir;
 use tokio::{sync::mpsc, try_join};
 use tracing::{debug, info, info_span, instrument};
 use tracing_appender::non_blocking::WorkerGuard;

crates/node/Cargo.toml

@@ -27,7 +27,7 @@ sp-core = { workspace = true }
 sp-runtime = { workspace = true }
 
 [dev-dependencies]
-temp-dir = { workspace = true }
+tempfile = { workspace = true }
 tokio = { workspace = true }
 
 [lints]

crates/node/src/geth.rs

@@ -605,7 +605,7 @@ impl Drop for GethNode {
 mod tests {
     use revive_dt_config::Arguments;
 
-    use temp_dir::TempDir;
+    use tempfile::TempDir;
 
     use crate::{GENESIS_JSON, Node};