Merge remote-tracking branch 'origin/main' into chore/update-version-of-tests2

crates/config/src/lib.rs

@@ -16,7 +16,6 @@ use alloy::{
     primitives::{B256, FixedBytes, U256},
     signers::local::PrivateKeySigner,
 };
-use anyhow::Context as _;
 use clap::{Parser, ValueEnum, ValueHint};
 use revive_dt_common::types::{ParsedTestSpecifier, PlatformIdentifier};
 use semver::Version;
@@ -1080,10 +1079,7 @@ impl FromStr for WorkingDirectoryConfiguration {
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         match s {
             "" => Ok(Default::default()),
-            _ => PathBuf::from(s)
-                .canonicalize()
-                .context("Failed to canonicalize the working directory path")
-                .map(Self::Path),
+            _ => Ok(Self::Path(PathBuf::from(s))),
         }
     }
 }

crates/core/src/lib.rs

@@ -234,15 +234,9 @@ impl Platform for ReviveDevNodePolkavmResolcPlatform {
             .path
             .as_path();
         let wallet = AsRef::<WalletConfiguration>::as_ref(&context).wallet();
-        let working_directory = AsRef::<WorkingDirectoryConfiguration>::as_ref(&context).as_path();
         let export_chainspec_command = SubstrateNode::REVIVE_DEV_NODE_EXPORT_CHAINSPEC_COMMAND;
 
-        SubstrateNode::node_genesis(
-            revive_dev_node_path,
-            export_chainspec_command,
-            &wallet,
-            working_directory,
-        )
+        SubstrateNode::node_genesis(revive_dev_node_path, export_chainspec_command, &wallet)
     }
 }
 
@@ -308,15 +302,9 @@ impl Platform for ReviveDevNodeRevmSolcPlatform {
             .path
             .as_path();
         let wallet = AsRef::<WalletConfiguration>::as_ref(&context).wallet();
-        let working_directory = AsRef::<WorkingDirectoryConfiguration>::as_ref(&context).as_path();
         let export_chainspec_command = SubstrateNode::REVIVE_DEV_NODE_EXPORT_CHAINSPEC_COMMAND;
 
-        SubstrateNode::node_genesis(
-            revive_dev_node_path,
-            export_chainspec_command,
-            &wallet,
-            working_directory,
-        )
+        SubstrateNode::node_genesis(revive_dev_node_path, export_chainspec_command, &wallet)
     }
 }
 

crates/node/src/node_implementations/substrate.rs

@@ -160,7 +160,6 @@ impl SubstrateNode {
             &self.node_binary,
             &self.export_chainspec_command,
             &self.wallet,
-            self.base_directory.as_path(),
         )
         .context("Failed to prepare the chainspec command")?;
 
@@ -320,7 +319,6 @@ impl SubstrateNode {
         node_path: &Path,
         export_chainspec_command: &str,
         wallet: &EthereumWallet,
-        base_directory: impl AsRef<Path>,
     ) -> anyhow::Result<serde_json::Value> {
         trace!("Exporting the chainspec");
         let output = Command::new(node_path)
@@ -328,7 +326,6 @@ impl SubstrateNode {
             .arg("--chain")
             .arg("dev")
             .env_remove("RUST_LOG")
-            .current_dir(base_directory)
             .output()
             .context("Failed to export the chain-spec")?;