warning: `#[doc(hidden)]` is ignored on trait impl items
--> serde/src/de/impls.rs:796:5
|
796 | #[doc(hidden)]
| ^^^^^^^^^^^^^^ help: remove this attribute
|
= note: `#[warn(unused_attributes)]` on by default
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item
error: this expression creates a reference which is immediately dereferenced by the compiler
--> serde/src/de/impls.rs:2015:58
|
2015 | ... Err(Error::unknown_field(&value, FIELDS))
| ^^^^^^ help: change this to: `value`
|
= note: `-D clippy::needless-borrow` implied by `-D clippy::all`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> serde/src/de/impls.rs:2355:54
|
2355 | ... Err(Error::unknown_field(&value, FIELDS))
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this lifetime isn't used in the impl
--> serde/src/de/value.rs:607:11
|
607 | impl<'de, 'a, E> de::EnumAccess<'de> for StringDeserializer<E>
| ^^
|
= note: `-D clippy::extra-unused-lifetimes` implied by `-D clippy::all`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
I'm not sure what is going on with this lint but it's triggering in a
lot of test code. Will need to investigate further.
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:194:21
|
194 | bound = "E: SerializeWith + DeserializeWith"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::type-repetition-in-bounds` implied by `-D clippy::pedantic`
= help: consider combining the bounds: `"E: SerializeWith + DeserializeWith": "E: SerializeWith + DeserializeWith" + "E: SerializeWith + DeserializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:184:21
|
184 | #[serde(bound = "D: SerializeWith + DeserializeWith")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"D: SerializeWith + DeserializeWith": "D: SerializeWith + DeserializeWith" + "D: SerializeWith + DeserializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:210:31
|
210 | bound(serialize = "E: SerializeWith")
| ^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"E: SerializeWith": "E: SerializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:201:31
|
201 | #[serde(bound(serialize = "D: SerializeWith", deserialize = "D: DeserializeWith"))]
| ^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"D: SerializeWith": "D: SerializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:231:21
|
231 | bound = "E: SerializeWith + DeserializeWith"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"E: SerializeWith + DeserializeWith": "E: SerializeWith + DeserializeWith" + "E: SerializeWith + DeserializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:221:21
|
221 | #[serde(bound = "D: SerializeWith + DeserializeWith")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"D: SerializeWith + DeserializeWith": "D: SerializeWith + DeserializeWith" + "D: SerializeWith + DeserializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:247:31
|
247 | bound(serialize = "E: SerializeWith")
| ^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"E: SerializeWith": "E: SerializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_gen.rs:238:31
|
238 | #[serde(bound(serialize = "D: SerializeWith", deserialize = "D: DeserializeWith"))]
| ^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `"D: SerializeWith": "D: SerializeWith"`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:84:5
|
84 | C: MyDefault,
| ^^^^^^^^^^^^
|
= note: `-D clippy::type-repetition-in-bounds` implied by `-D clippy::pedantic`
= help: consider combining the bounds: `C: MyDefault`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:85:5
|
85 | E: MyDefault,
| ^^^^^^^^^^^^
|
= help: consider combining the bounds: `E: MyDefault`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:105:5
|
105 | C: MyDefault;
| ^^^^^^^^^^^^
|
= help: consider combining the bounds: `C: MyDefault`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:1066:5
|
1066 | B: 'a,
| ^^^^^
|
= help: consider combining the bounds: ``
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:1067:5
|
1067 | D: SerializeWith,
| ^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `D: SerializeWith`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:1106:5
|
1106 | B: SerializeWith,
| ^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `B: SerializeWith`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:1150:5
|
1150 | B: SerializeWith,
| ^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `B: SerializeWith`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this type has already been used as a bound predicate
--> test_suite/tests/test_annotations.rs:1368:5
|
1368 | B: DeserializeWith,
| ^^^^^^^^^^^^^^^^^^
|
= help: consider combining the bounds: `B: DeserializeWith`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
This allows non-Cargo builds to generally not get involved in cfgs. As
long as one is using a reasonably recent toolchain, no cfgs need to be
set and you'll get a fully-featured build.
error: all variants have the same prefix: `Serialize`
--> test_suite/tests/test_macros.rs:1741:5
|
1741 | / enum E {
1742 | | #[serde(rename_all = "camelCase")]
1743 | | Serialize {
1744 | | serialize: bool,
... |
1756 | | },
1757 | | }
| |_____^
|
= note: `-D clippy::enum-variant-names` implied by `-D clippy::all`
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
error: redundant closure
--> serde_derive/src/bound.rs:53:19
|
53 | .flat_map(|predicates| predicates.to_vec());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `[T]::to_vec`
|
note: the lint level is defined here
--> serde_derive/src/lib.rs:18:22
|
18 | #![deny(clippy::all, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::redundant_closure_for_method_calls)]` implied by `#[deny(clippy::pedantic)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
error: redundant closure
--> serde_derive/src/bound.rs:75:19
|
75 | .flat_map(|predicates| predicates.to_vec());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `[T]::to_vec`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
Currently fails:
error[E0509]: cannot move out of type `RemotePackedNonCopyDef`, which implements the `Drop` trait
--> test_suite/tests/test_gen.rs:876:10
|
876 | #[derive(Deserialize)]
| ^^^^^^^^^^^
| |
| cannot move out of here
| data moved here
| move occurs because `__v1` has type `std::string::String`, which does not implement the `Copy` trait
|
= note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
Currently fails to build:
error: reference to packed field is unaligned
--> test_suite/tests/test_gen.rs:858:10
|
858 | #[derive(Serialize, Deserialize)]
| ^^^^^^^^^
|
note: the lint level is defined here
--> test_suite/tests/test_gen.rs:5:9
|
5 | #![deny(warnings)]
| ^^^^^^^^
= note: `#[deny(unaligned_references)]` implied by `#[deny(warnings)]`
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
= note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
error: reference to packed field is unaligned
--> test_suite/tests/test_gen.rs:858:21
|
858 | #[derive(Serialize, Deserialize)]
| ^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
= note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: trailing semicolon in macro used in expression position
--> serde_test/src/ser.rs:44:10
|
44 | );
| ^
...
152 | Some(&Token::BorrowedStr(_)) => assert_next_token!(self, BorrowedStr(v)),
| ---------------------------------------- in this macro invocation
|
= note: `#[warn(semicolon_in_expressions_from_macros)]` on by default
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: this warning originates in the macro `assert_next_token` (in Nightly builds, run with -Z macro-backtrace for more info)
warning: trailing semicolon in macro used in expression position
--> serde_test/src/ser.rs:36:76
|
36 | assert_next_token!($ser, stringify!($actual), Token::$actual, true);
| ^
...
386 | Token::TupleVariantEnd => assert_next_token!(self.ser, TupleVariantEnd),
| --------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: this warning originates in the macro `assert_next_token` (in Nightly builds, run with -Z macro-backtrace for more info)
Clippy bug: https://github.com/rust-lang/rust-clippy/issues/7422
error: use of irregular braces for `format_args!` macro
--> test_suite/tests/test_gen.rs:528:25
|
528 | #[derive(Serialize, Deserialize)]
| ^^^^^^^^^^^
|
= note: `-D clippy::nonstandard-macro-braces` implied by `-D clippy::all`
help: consider writing `Deserialize`
--> test_suite/tests/test_gen.rs:528:25
|
528 | #[derive(Serialize, Deserialize)]
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonstandard_macro_braces
= note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
error: use of irregular braces for `format_args!` macro
--> test_suite/tests/test_annotations.rs:1791:43
|
1791 | #[derive(Debug, PartialEq, Serialize, Deserialize)]
| ^^^^^^^^^^^
|
= note: `-D clippy::nonstandard-macro-braces` implied by `-D clippy::all`
help: consider writing `Deserialize`
--> test_suite/tests/test_annotations.rs:1791:43
|
1791 | #[derive(Debug, PartialEq, Serialize, Deserialize)]
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonstandard_macro_braces
= note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
David Tolnay