pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-09 20:11:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve Jaeger errors and debugging experience (#2127)

Browse Source 
* Improve Jaeger errors and debugging experience

* Bind on 0.0.0.0:0 instead
This commit is contained in:
Pierre Krieger
2020-12-17 15:38:56 +01:00
committed by GitHub
parent 05e9f13782
commit e6e3bda3f0
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/node/subsystem/src/errors.rs
-6
View File
@@ -70,10 +70,4 @@ pub enum JaegerError {
#[error("Missing jaeger configuration")]
MissingConfiguration,
#[error("Failed to allocate port for UDP transfer to jaeger agent")]
PortAllocationError(#[source] std::io::Error),
#[error("Failed to send jaeger span to agent")]
SendError(#[source] std::io::Error),
}
polkadot/node/subsystem/src/jaeger.rs
+4 -8
View File
@@ -210,20 +210,16 @@ impl Jaeger {
// Spawn a background task that pulls span information and sends them on the network.
spawner.spawn("jaeger-collector", Box::pin(async move {
let res = async_std::net::UdpSocket::bind("127.0.0.1:0").await
.map_err(JaegerError::PortAllocationError);
match res {
match async_std::net::UdpSocket::bind("0.0.0.0:0").await {
Ok(udp_socket) => loop {
let buf = traces_out.next().await;
// UDP sending errors happen only either if the API is misused or in case of missing privilege.
if let Err(e) = udp_socket.send_to(&buf, jaeger_agent).await
.map_err(|e| JaegerError::SendError(e))
{
log::trace!("Jaeger: {:?}", e);
if let Err(e) = udp_socket.send_to(&buf, jaeger_agent).await {
log::debug!(target: "jaeger", "UDP send error: {}", e);
}
}
Err(e) => {
log::warn!("Jaeger: {:?}", e);
log::warn!(target: "jaeger", "UDP socket open error: {}", e);
}
}
}));