Commit Graph
100 Commits
Author SHA1 Message Date
Bastian Köcher 22b95a8a55 parachain-template: Simplify it (#3801)
Also while doing this, move slot duration fetching into the AURA code.
2024-04-09 09:43:42 +00:00
Bastian Köcher c1063a530e sc-beefy-consensus: Remove unneeded stream. (#4015)
The stream was just used to communicate from the validator the peer
reports back to the gossip engine. Internally the gossip engine just
forwards these reports to the networking engine. So, we can just do this
directly.

The reporting stream was also pumped [in the worker behind the
engine](https://github.com/paritytech/polkadot-sdk/blob/9d6261892814fa27c97881c0321c008d7340b54b/substrate/client/consensus/beefy/src/worker.rs#L939).
This means if there was a lot of data incoming over the engine, the
reporting stream was almost never processed and thus, it could have
started to grow and we have seen issues around this.

Partly Closes: https://github.com/paritytech/polkadot-sdk/issues/3945
2024-04-08 08:28:42 +00:00
Bastian Köcher 9b378a2ffe sp-wasm-interface: wasmtime should not be enabled by std (#3954)
Closes: https://github.com/paritytech/polkadot-sdk/issues/3909
2024-04-03 08:35:53 +00:00
Bastian Köcher 12eb285dbe Fix parachain upgrade scheduling when done by the owner/root (#3341)
When using `schedule_code_upgrade` to change the code of a parachain in
the relay chain runtime, we had already fixed to not set the `GoAhead`
signal. This was done to not brick any parachain after the upgrade,
because they were seeing the signal without having any upgrade prepared.
The remaining problem is that the parachain code is only upgraded after
a parachain header was enacted, aka the parachain made some progress.
However, this is quite complicated if the parachain is bricked (which is
the most common scenario why to manually schedule a code upgrade). Thus,
this pull request replaces `SetGoAhead` with `UpgradeStrategy` to signal
to the logic kind of strategy want to use. The strategies are either
`SetGoAheadSignal` or `ApplyAtExpectedBlock`. `SetGoAheadSignal` sets
the go ahead signal as before and awaits a parachain block.
`ApplyAtExpectedBlock` schedules the upgrade and applies it directly at
the `expected_block` without waiting for the parachain to make any kind
of progress.
2024-04-02 09:44:23 +00:00
Bastian Köcher 256d5aefdc Revert log level changes (#3913)
Closes: https://github.com/paritytech/polkadot-sdk/issues/3906
2024-03-31 20:47:01 +00:00
Bastian Köcher 5d314eb03e pallet-referenda: Detect incorrect pre-image length (#3850)
There has been a case that a referenda failed because the length given
to `submit` was incorrect. The pallet can actually check the length if
the pre-image already exists to ensure that these kind of issues are not
happening again.
2024-03-27 23:52:50 +00:00
Bastian Köcher 597ea9203a pallet-scheduler: Unrequest call on failed lookup (#3849)
When the scheduler fails to lookup a `call`, it should unrequest it,
because it will not be required anymore.
2024-03-27 23:02:37 +00:00
0c15d88751 westend: SignedPhase is a constant (#3646)
In preparation for the merkleized metadata, we need to ensure that
constants are actually constant. If we want to test the unsigned phase
we could for example just disable signed voter. Or we add some extra
mechanism to the pallet to disable the signed phase from time to time.

---------

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2024-03-26 18:00:39 +00:00
Bastian Köcher 463ccb8f90 pallet-aura: Expose SlotDuration as constant (#3732) 2024-03-24 14:21:18 +00:00
Bastian Köcher 430ad2f561 Make availability-recovery-regression-bench a benchmark (#3741)
Closes: https://github.com/paritytech/polkadot-sdk/issues/3704
2024-03-19 08:27:51 +00:00
Bastian Köcher 0893ca1584 frame-support: Improve error reporting when having too many pallets (#3478)
Instead of only generating the error, we now generate the actual code
and the error. This generates in total less errors and helps the user to
identify the actual problem and not being confronted with tons of
errors.
2024-02-26 10:32:35 +00:00
Bastian Köcher 9bf1a5e238 Check that the validation code matches the parachain code (#3433)
This introduces a check to ensure that the parachain code matches the
validation code stored in the relay chain state. If not, it will print a
warning. This should be mainly useful for parachain builders to make
sure they have setup everything correctly.
2024-02-22 13:35:00 +00:00
Bastian Köcher ef6ac94f52 Downgrade log message to trace (#3405)
This spams logs in `Debug` with no useful information.
2024-02-20 14:28:05 +00:00
Bastian Köcher 150a360c41 sc-keystore: Improve docs (#3334)
Close: https://github.com/paritytech/polkadot-sdk/issues/3320

@Hugo-Trentesaux are these docs better for explaining the internals?
2024-02-15 11:15:05 +00:00
Bastian Köcher aa68ea58f3 Parachains-Aura: Only produce once per slot (#3308)
Given how the block production is driven for Parachains right now, with
the enabling of async backing we would produce two blocks per slot.
Until we have a proper collator implementation, the "hack" is to prevent
the production of multiple blocks per slot.


Closes: https://github.com/paritytech/polkadot-sdk/issues/3282
2024-02-13 20:07:51 +00:00
Bastian Köcher 349132f08a Fix compilation on latest nightly because of stdsimd (#3296)
We need to bump `ahash` to make it compile again.

Closes: https://github.com/paritytech/polkadot-sdk/issues/3269
2024-02-13 13:30:28 +00:00
Bastian KöcherandAlexandru Gheorghe e0674cb3ad Enable async backing by default for Rococo/Westend (#3162)
This change is mainly for people running the local variants. They can
directly start with async backing.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
2024-02-02 19:51:56 +00:00
Bastian Köcher 400ee1bb31 Remove symlinks of non existing files (#3124)
Closes: https://github.com/paritytech/polkadot-sdk/issues/3123
2024-01-30 13:10:51 +01:00
Bastian Köcher a989ddfab9 statement-distribution: Ensure we deactivate leaves before activating (#3042)
As activation can fail, we ensure that we don't miss deactivation of
leaves.
2024-01-24 13:10:42 +00:00
Bastian KöcherandMichal Kucharczyk deb72f432d sc-informant: Respect --disable-log-color (#3009)
Changes `sc-informant` to respect the `--disable-log-color` CLI flag.

Closes: https://github.com/paritytech/polkadot-sdk/issues/2795

---------

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
2024-01-22 10:31:37 +00:00
Bastian Köcher e2caa813bf Review: Remove audit rules (#3010)
Srlabs review is most of the times just blocking the merge, especially
when the changes do not require any audit. This pr removes the
requirement of srlabs to approve these prs.
2024-01-22 10:12:58 +01:00
Bastian Köcher 0e124a0559 pallet-contracts: Fix compilation on latest nightly (#2986)
Apparently they changed detection for visibility identifiers on traits,
which broke more than it should. There is an issue open:
https://github.com/rust-lang/rust/issues/119924 The easy solution for us
is to move the declaration of the global variable outside of the trait.

Closes: https://github.com/paritytech/polkadot-sdk/issues/2960
2024-01-18 17:28:19 +00:00
Bastian Köcher 38205bf139 Downgrade logging to debug (#2980)
There is no need to spawn operators with this debug log.

Closes: https://github.com/paritytech/polkadot-sdk/issues/2974
2024-01-18 10:49:13 +00:00
Bastian Köcher 1c2db1747e Some random fixes (#2936)
- Do not disable `std` feature in the integration tests
- `contracts-fixtures` test should only check for `riscv` build when the
feature is enabled
2024-01-16 00:19:17 +00:00
4fdab499c4 Coretime Zombienet test (#2867)
This adds a Zombienet test for Coretime.

Requires: https://github.com/paritytech/polkadot-sdk/pull/2862

---------

Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
2024-01-08 18:41:02 +00:00
Bastian Köcher 1914775bd4 Make simple-mermaid optional (#2878)
This prevents it leaking `std` into `no_std` builds.

Closes: https://github.com/paritytech/polkadot-sdk/issues/2866
2024-01-08 15:45:15 +00:00
Bastian KöcherandDónal Murray dbff87c268 Return latest known relay chain block number in on_initialize etc (#2862)
This changes `RelaychainDataProvider` to return the latest known relay
chain block number in `on_initialize` et all, aka when the
`validation_data` wasn't yet set by the inherent.

---------

Co-authored-by: Dónal Murray <donal.murray@parity.io>
2024-01-08 12:45:17 +00:00
Bastian Köcher 745c02c59a pallet-contracts-fixtures: Only build RISCV when the feature is enabled (#2870)
This disables building the RISCV fixtures by default. They still require
a custom build rustc version. When there are actual tests for RISCV, the
feature can be enabled in CI. Also fixes some unwraps that assume again
that people are using rustup...
2024-01-07 16:49:34 +01:00
Bastian Köcherandcommand-bot 930c151928 cumulus-primitives-parachain-inherent: Split into two crates (#2803)
This splits `cumulus-primitives-parachain-inherent` into two crates, the
previous `cumulus-primitives-parachain-inherent` and a new
`cumulus-client-parachain-inherent`. The idea behind this is to move the
`create_at` logic into the client crate. This removes quite a lot of
unrelated dependencies from the runtime std build and thus, makes the
compilation faster. On my Laptop the compilation is goes down by one
minute for `asset-hub-rococo-runtime`. I also assume that the full build
of the entire workspace probably can be speed-up a little bit, because
more stuff can be compiled in parallel.

---------

Co-authored-by: command-bot <>
2024-01-05 21:43:26 +01:00
Bastian Köcher 1c95310a66 fungible::Unbalanced::decrease_balance: Handle precision properly (#2823) 2024-01-05 19:55:32 +01:00
Bastian Köcher 5b9e69d37d Remove dotgraph feature (#2848)
Apparently the implementation is broken and is generating warnings in
the build. Not sure this was used any way by anyone.

Closes: https://github.com/paritytech/polkadot-sdk/issues/2836
2024-01-04 13:25:07 +01:00
Bastian Köcher 7070b65d76 xcm: Improve debuggability (#2799)
Adds more logging to the XCM execution for better debugging.
2023-12-26 23:28:29 +01:00
Bastian Köcher 753967ab48 Coretime: Use Superuser for sending the transact calls (#2793) 2023-12-22 21:41:35 +01:00
Bastian Köcher 96bec7a7ab pallet-sudo: Accept Root origin as valid sudo (#2783)
This changes `pallet-sudo` to also accept `Root` origin for
`ensure_sudo`. This can be useful for parachains who allow the relay
chain to have superuser rights to setup the sudo pallet for example.
2023-12-22 09:58:32 +01:00
Bastian Köcher 46dd4b8f53 frame-support: Print key as hex for corrupted state (#2779) 2023-12-22 09:50:35 +01:00
Bastian Köcher 84d6342cd2 pallet-uniques/nfts: Small optimizations (#2754)
Use `contains_key` to not require decoding the actual value.
2023-12-19 17:17:14 +01:00
Bastian Köcher ce1c9a44a7 parachain-system: Do not take self for last_relay_block_number (#2720)
FRAME DSL is working in a static context.
2023-12-15 11:29:57 +01:00
Bastian Köcherandcommand-bot 6dece52e9d pallet-nomination-pools: Enable function for fuzzing feature as well (#2711)
The function is called by `do_try_state` which is also enabled for the
`fuzzing` feature.

---------

Co-authored-by: command-bot <>
2023-12-14 22:51:07 +01:00
Bastian Köcher ef62acfbcf pallet-uniques: Move migration over to VersionedMigration (#2687) 2023-12-12 13:37:52 +02:00
Bastian Köcher f6ae145813 Update proc-macro-crate (#2660) 2023-12-08 16:10:58 +01:00
Bastian Köcher fde5d8fe6c pallet-broker: Small improvements to the origin checks (#2656)
The permissionless calls do not need to ensure that the `origin` is
signed. Anyone can execute these calls.
2023-12-08 02:45:14 +02:00
Bastian Köcher 1a4ab64bcb Fix recursive trait bounds (#2644)
Closes: https://github.com/paritytech/polkadot-sdk/issues/2641
2023-12-07 17:04:18 +01:00
Bastian Köcher 833478f262 Relax approval requirements on CI files (#2564)
- Remove the old Cumulus checks as these files do not exist anymore
- Relax requirements on CI files to also give two core devs the right to
change these files
- Relax requirements on the review bot configuration itself as well.
2023-12-06 23:16:56 +01:00
Bastian KöcherandLiam Aharon a1b2ecb902 pallet-ranked-collective: Ensure to cleanup state in remove_member (#2591)
This ensures that we cleanup the state of `who` in `remove_member`.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
2023-12-04 20:43:27 +02:00
Bastian Köcher aa4754e30a contracts-fixtures: Do not assume that rustup is installed (#2586)
The build script was assuming that `rustup` is installed, which breaks
the build on systems that do not use `rustup`. This pull request just
fixes it by not panicking on the call to `rustup`.
2023-12-04 17:03:47 +01:00
Bastian Köcher d3d301fa42 ParachainHost: No need to be generic over the block or hash type (#2537)
The `BlockNumber` and `Hash` are fixed types any way.
2023-11-29 15:31:51 +01:00
Bastian Köcher 5e27342198 Do not pollute global base path with export genesis/wasm (#2487)
Otherwise the user may runs into weird errors if there is already a db.
2023-11-25 00:22:52 +01:00
Bastian Köcher 803ea76059 Improve UnpinHandleInner debug (#2485)
Printing the `unpin_worker_sender` included the entire stacktrace and
that is a little bit too verbose.
2023-11-24 15:20:21 +01:00
Bastian Köcherandcommand-bot 21f1811c66 sp-api: Move macro related re-exports to __private (#2446)
This moves the macro related re-exports to `__private` to make it more
obvious for downstream users that they are using an internal api.

---------

Co-authored-by: command-bot <>
2023-11-23 14:52:46 +01:00
ea4085ab74 frame-system: Add last_runtime_upgrade_spec_version (#2351)
Adds a function for querying the last runtime upgrade spec version. This
can be useful for when writing runtime level migrations to ensure that
they are not executed multiple times. An example would be a session key
migration.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2023-11-16 00:54:08 +02:00
Bastian KöcherandDavide Galassi ebcf0a0f1c pallet-grandpa: Remove GRANDPA_AUTHORITIES_KEY (#2181)
Remove the `GRANDPA_AUTHORITIES_KEY` key and its usage. Apparently this
was used in the early days to communicate the grandpa authorities to the
node. However, we have now a runtime api that does this for us. So, this
pull request is moving from the custom managed storage item to a FRAME
managed storage item.

This pr also includes a migration for doing the switch on a running
chain.

---------

Co-authored-by: Davide Galassi <davxy@datawok.net>
2023-11-13 15:32:02 +02:00
Bastian Köcher 604704a84c wasm-builder: Optimize rerun-if-changed logic (#2282)
Optimizes the `rerun-if-changed` logic by ignoring `dev-dependencies`
and also not outputting paths. Because outputting paths could lead to
include unwanted crates in the rerun checks.
2023-11-13 13:57:52 +01:00
Bastian Köcher b0d0fb31d8 sc-state-db: Keep track of LAST_PRUNED after warp syncing (#2228)
When warp syncing we import the target block with all its state.
However, we didn't store the `LAST_PRUNED` block which would then lead
to `pruning` to forget about the imported block after a restart of the
node. We just set `LAST_PRUNED` to the parent block of the warp sync
target block to fix this issue.
2023-11-09 21:44:23 +01:00
Bastian Köcher e4f5f3c9c5 Rococo: Build two versions of the wasm binary (#2229)
One for local networks with `fast-runtime` feature activated (1 minute
sessions) and one without the feature activated that will be the default
that runs with 1 hour long sessions.
2023-11-08 23:30:41 +01:00
Bastian Köcher 1bc0885829 validate-block: Fix TrieCache implementation (#2214)
The trie cache implementation was ignoring the `storage_root` when
setting up the value cache. The problem with this is that the value
cache works using `storage_keys` and these keys are not unique across
different tries. A block can actually have different tries (main trie
and multiple child tries). This pull request fixes the issue by not
ignoring the `storage_root` and returning an unique `value_cache` per
`storage_root`. It also adds a test for the seen bug and improves
documentation that this doesn't happen again.
2023-11-08 14:33:19 +01:00
ca5f10567a sc-block-builder: Remove BlockBuilderProvider (#2099)
The `BlockBuilderProvider` was a trait that was defined in
`sc-block-builder`. The trait was implemented for `Client`. This
basically meant that you needed to import `sc-block-builder` any way to
have access to the block builder. So, this trait was not providing any
real value. This pull request is removing the said trait. Instead of the
trait it introduces a builder for creating a `BlockBuilder`. The builder
currently has the quite fabulous name `BlockBuilderBuilder` (I'm open to
any better name 😅). The rest of the pull request is about
replacing the old trait with the new builder.

# Downstream code changes

If you used `new_block` or `new_block_at` before you now need to switch
it over to the new `BlockBuilderBuilder` pattern:

```rust
// `new` requires a type that implements `CallApiAt`. 
let mut block_builder = BlockBuilderBuilder::new(client)
                // Then you need to specify the hash of the parent block the block will be build on top of
		.on_parent_block(at)
                // The block builder also needs the block number of the parent block. 
                // Here it is fetched from the given `client` using the `HeaderBackend`
                // However, there also exists `with_parent_block_number` for directly passing the number
		.fetch_parent_block_number(client)
		.unwrap()
                // Enable proof recording if required. This call is optional.
		.enable_proof_recording()
                // Pass the digests. This call is optional.
                .with_inherent_digests(digests)
		.build()
		.expect("Creates new block builder");
```

---------

Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: command-bot <>
2023-11-03 19:06:31 +01:00
Bastian Köcher 3ae86ae075 check-each-crate: Do not reference crate to check by name (#2098)
This pull request changes how `check-each-crate.py` is working. Instead
of passing the name of the crate via `-p`, we now jump into the
directory of the crate and call there `cargo check`. This should fix
issues like https://github.com/paritytech/polkadot-sdk/issues/2013 where
a crate is present twice in the `Cargo.lock`.

Besides that it also changes `core/Cargo.toml` to not always pull in
bandersnatch.
2023-10-31 14:07:10 +01:00
Bastian Köcher 2d9426f1cc parachain-system: Send same event & digest as a standalone chain (#2064)
This ensures that upgrading a parachain code sends the same event &
digest as when using `set_code` on a standalone chain.

Close: https://github.com/paritytech/polkadot-sdk/issues/2049
2023-10-30 17:37:10 +01:00
Bastian Köcher bea8baed69 level-monitor: Fix issue with warp syncing (#2053)
When warp syncing a node we import a header of the parachain around the
tip of the chain. This header is currently not imported as finalized
block (should be fixed at some point as well), the parent headers are
not yet present (still being synced) and thus, we run into a panic. Even
if there is a case where a leaf could not be found in the database, this
probably means that the db is broken and it will fail somewhere elese.
2023-10-27 20:35:59 +02:00
Bastian Köcherandordian 42707bc98b sp-version: Improve the docs (#2027)
Co-authored-by: ordian <write@reusable.software>
2023-10-26 21:53:15 +02:00
Bastian Köcher 2e11ae89dc basic-authorship: Improve time recording and logging (#2010) 2023-10-25 00:30:48 +02:00
Bastian Köcher a5a2432d22 CheckWeight: Add more logging (#1996)
This adds more logging to `CheckWeight` to get a better understanding
why a transaction exhausts resources.
2023-10-24 11:55:46 +02:00
Bastian Köcher 676bacd729 Always schedule at least one job onto a core (#1990)
Even if the host configuration is returning `0` for the `lookahead`, we
should schedule at least one job on a core if the core exists.
2023-10-23 17:06:04 +02:00
Bastian Köcher f678b61c39 paras-scheduler: Fix migration to V1 (#1969)
The migration was missing to migrate `AvailabilityCores`. If this isn't
migrated, all parachains in the availability phase would stall until the
next session is started. This pull request fixes this by migrating this
data. Besides that it is doing some cosmetics.
2023-10-23 12:07:16 +02:00
Bastian KöcherandKoute e2b21d00c7 sc-executor: Increase maximum instance count (#1856)
Changes the maximum instances count for `wasmtime` to `64`. It also
allows to only pass in maximum `32` for `--max-runtime-instances` as
`256` was way too big. With `64` instances in total and `32` that can be
configured in maximum, there should be enough space to accommodate for
extra instances that are may required to be allocated adhoc.

---------

Co-authored-by: Koute <koute@users.noreply.github.com>
2023-10-22 10:44:34 +02:00
Bastian KöcherandFrancisco Aguirre f3bf5c1acd xcm: Change TypeInfo::path to not include staging (#1948)
The `xcm` crate was renamed to `staging-xcm` to be able to publish it to
crates.io as someone as squatted `xcm`. The problem with this rename is
that the `TypeInfo` includes the crate name which ultimately lands in
the metadata. The metadata is consumed by downstream users like
`polkadot-js` or people building on top of `polkadot-js`. These people
are using the entire `path` to find the type in the type registry. Thus,
their code would break as the type path would now be [`staging_xcm`,
`VersionedXcm`] instead of [`xcm`, `VersionedXcm`]. This pull request
fixes this by renaming the path segment `staging_xcm` to `xcm`.

This requires: https://github.com/paritytech/scale-info/pull/197

---------

Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
2023-10-20 11:21:19 +02:00
Bastian Köcherandeskimor b967ba53d3 Do not force collators to update after enabling async backing (#1920)
The validators are checking if async backing is enabled by checking the
version of the runtime api. If the runtime api is upgraded by a runtime
upgrade, the validators start to also enable the async backing logic.
However, just because async backing is enabled, it doesn't mean that all
collators and parachain runtimes have upgraded. This pull request fixes
an issue about advertising collations to the relay chain when it has
async backing enabled, but the collator is still using the old
networking protocol. The implementation is actually backwards compatible
as we can not expect that everyone directly upgrades. However, the
collation advertisement logic was requiring V2 networking messages after
async backing was enabled, which was wrong. This is now fixed by this
pull request.

Closes: https://github.com/paritytech/polkadot-sdk/issues/1923

---------

Co-authored-by: eskimor <eskimor@users.noreply.github.com>
2023-10-19 21:45:33 +02:00
Bastian Köcherandcommand-bot 4e98bec3f1 sp-api: Improve error message for duplicate runtime apis (#1877)
Co-authored-by: command-bot <>
2023-10-16 14:41:44 +02:00
Bastian Köcher c54ea64af4 no-bound derives: Use absolute path for core (#1763)
Closes: https://github.com/paritytech/polkadot-sdk/issues/1718
2023-10-02 06:45:32 +11:00
Bastian Köcher bf90cb0b73 Remove kusama and polkadot runtime crates (#1731)
This pull request is removing the Kusama and Polkadot runtime crates. As
still some crates dependent on the runtime crates, this pull request is
doing some more changes.

- It removes the `hostperfcheck` CLI command. This CLI command could
compare the current node against the standard hardware by doing some
checks. Later we added the hardware benchmark feature to Substrate. This
hardware benchmark is running on every node startup and prints a warning
if the current node is too slow. This makes this CLI command a duplicate
that was also depending on the kusama runtime.

- The pull request is removing the emulated integration tests that were
requiring the Kusama or Polkadot runtime crates.
2023-09-29 09:54:11 +02:00
Bastian Köcher 6079b6dd3a Remove Polkadot & Kusama native runtime (#1304)
This pull request removes the Polkadot and Kusama native runtime from
the polkadot node. This brings some implications with it:

There are no more kusama/polkadot-dev chain specs available. We will
need to write some tooling in the fellowship repo to provide them
easily.

The try-runtime job for polkadot & kusama is not available anymore as we
don't have the dev chain specs anymore.

Certain benchmarking commands will also not work until we migrate them
to use a runtime api.

Some crates in utils are still depending on the polkadot/kusama native
runtime that will also need to be fixed.

Port of: https://github.com/paritytech/polkadot/pull/7467
2023-09-19 12:07:21 +01:00
Bastian Köcher f1994c8690 wasm-builder: Disable building when running on docs.rs (#1540)
This pull request changes the `wasm-builder` to skip building the wasm
files when the build process is running on docs.rs.
2023-09-13 21:53:05 +02:00
Bastian Köcher e005aef59b Make the node version independent of the crate version (#1495) 2023-09-12 14:12:10 +02:00
Bastian Köcherandcommand-bot a33d7922f8 Rename polkadot-parachain to polkadot-parachain-primitives (#1334)
* Rename `polkadot-parachain` to `polkadot-parachain-primitives`

While doing this it also fixes some last `rustdoc` issues and fixes
another Cargo warning related to `pallet-paged-list`.

* Fix compilation

* ".git/.scripts/commands/fmt/fmt.sh"

* Fix XCM docs

---------

Co-authored-by: command-bot <>
2023-08-31 23:53:29 +02:00
Bastian Köcher cbd745c846 Fix node-metrics test (#1287) 2023-08-30 09:48:29 +02:00
844eda7626 pallet-scheduler: Send CallUnavailable event if the call isn't present (#1161)
The event was already send before, but it was done at the wrong
position. The pull request all changes the `execute_dispatch` signature
to highlight that there is only one error type.

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Javier Viola <javier@parity.io>
2023-08-29 22:42:54 +02:00
Bastian Köcherandcommand-bot 9acb06717e Fix test-rustdoc (#1266)
* Fix `test-rustdoc`

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
2023-08-29 21:23:38 +02:00
Bastian Köcherandparity-processbot 02691d94d8 Companion for Substrate#14612 (#2923)
* Companion for Substrate#14612

https://github.com/paritytech/substrate/pull/14612

* Remove patch

* Cargo.lock

* Fix

* Fix compilation

* Fix Fix

* ...

* :face_palm:

* .................

* update lockfile for {"polkadot", "substrate"}

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: parity-processbot <>
2023-08-17 12:39:09 +00:00
Bastian Köcherandparity-processbot 26b5f259a3 Companion for Substrate#14612 (#7536)
* Companion for reworking the storage transaction cache

* Cargo lock

* Fixes

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
2023-08-17 11:26:44 +00:00
Bastian KöcherandDavide Galassi ecf8035da6 Set StateBackend::Transaction to PrefixedMemoryDB (#14612)
* Yep

* Try to get it working everywhere

* Make `from_raw_storage` start with an empty db

* More fixes!

* Make everything compile

* Fix `child_storage_root`

* Fix after merge

* Cleanups

* Update primitives/state-machine/src/overlayed_changes/mod.rs

Co-authored-by: Davide Galassi <davxy@datawok.net>

* Review comments

* Fix issues

* Silence warning

* FMT

* Clippy

---------

Co-authored-by: Davide Galassi <davxy@datawok.net>
2023-08-17 10:49:38 +00:00
04b1e4fbd8 Improve storage_alias and make UnlockAndUnreserveAllFunds independent of the pallet (#14773)
* Make `storage_alias` more generic over the `prefix`

* Make `UnlockAndUnreserveAllFunds` indepenend from the pallet

* FMT

* Fix error reporting

* Rename prefix type

* Add test

* Apply suggestions from code review

Co-authored-by: Sam Johnson <sam@durosoft.com>

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: Sam Johnson <sam@durosoft.com>
Co-authored-by: command-bot <>
2023-08-16 08:15:32 +00:00
Bastian Köcherandparity-processbot 896c60185a Companion for Polkadot#7617 (#3008)
* Companion for Polkadot#7617

https://github.com/paritytech/polkadot/pull/7617

* Adapt to latest Polkadot changes.

* update lockfile for {"polkadot", "substrate"}

---------

Co-authored-by: parity-processbot <>
2023-08-15 09:29:10 +00:00
Bastian Köcher cf3271fea2 Remove superflous parameter overseer_enable_anyways and make parachain node type more explicit (#7617)
* Remove superflous parameter `overseer_enable_anyways`

We don't need this flag, as we don't need the overseer enabled when the
node isn't a collator or validator.

* Rename `IsCollator` to `IsParachainNode`

`IsParachainNode` is more expressive and also encapsulates the state of
the parachain node being a full node. Some functionality like the
overseer needs to run always when the node runs alongside a parachain
node. The parachain node needs the overseer to e.g. recover PoVs. Other
things like candidate validation or pvf checking are only required for
when the node is running as validator.

* FMT

* Fix CI
2023-08-15 08:51:27 +00:00
Bastian Köcher b16976053e Do some cleanups (#14608)
* Do some cleanups

Found them while looking over the code.

* More

* Fix
2023-07-21 23:54:01 +02:00
Bastian Köcherandparity-processbot ae0210c1cc Companion for removal of execution strategies (#2836)
* Companion for removal of execution strategies

https://github.com/paritytech/substrate/pull/14387

* Update Cargo.lock

* Remove patches

* Delete file again

* update lockfile for {"polkadot", "substrate"}

* Fix

* FMT

---------

Co-authored-by: parity-processbot <>
2023-07-11 22:48:51 +00:00
Bastian Köcherandparity-processbot 0ff60f7da1 Companion for removal of execution strategies (#7443)
* Companion for removal of execution strategies

https://github.com/paritytech/substrate/pull/14387

* Fix some tests

* 🤦

* Adapt to latest changes

* Start supporting the offchain transaction pool

* Fix tests

* FMT

* Remove patches

* Update Substrate

* update lockfile for {"substrate"}

* Fix parachain upgrade smoke test

* Fix test

* Rewrite all tests to use `MockSubstemClient`

---------

Co-authored-by: parity-processbot <>
2023-07-11 21:55:43 +00:00
Bastian Köcher ca5970e582 node-template: Remove accidentally added dependency (#14553)
`sc-statement-store` isn't used by the template and thus, should not appear in the `Cargo.toml`.
2023-07-11 20:55:38 +02:00
5eb816d7a6 Removal of execution strategies (#14387)
* Start

* More work!

* Moar

* More changes

* More fixes

* More worrk

* More fixes

* More fixes to make it compile

* Adds `NoOffchainStorage`

* Pass the extensions

* Small basti making small progress

* Fix merge errors and remove `ExecutionContext`

* Move registration of `ReadRuntimeVersionExt` to `ExecutionExtension`

Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to
`ExecutionExtension` which provides the default extensions.

* Fix compilation

* Register the global extensions inside runtime api instance

* Fixes

* Fix `generate_initial_session_keys` by passing the keystore extension

* Fix the grandpa tests

* Fix more tests

* Fix more tests

* Don't set any heap pages if there isn't an override

* Fix small fallout

* FMT

* Fix tests

* More tests

* Offchain worker custom extensions

* More fixes

* Make offchain tx pool creation reusable

Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be
registered in the runtime externalities context. This factory will be required for a later pr to
make the creation of offchain transaction pools easier.

* Fixes

* Fixes

* Set offchain transaction pool in BABE before using it in the runtime

* Add the `offchain_tx_pool` to Grandpa as well

* Fix the nodes

* Print some error when using the old warnings

* Fix merge issues

* Fix compilation

* Rename `babe_link`

* Rename to `offchain_tx_pool_factory`

* Cleanup

* FMT

* Fix benchmark name

* Fix `try-runtime`

* Remove `--execution` CLI args

* Make clippy happy

* Forward bls functions

* Fix docs

* Update UI tests

* Update client/api/src/execution_extensions.rs

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Koute <koute@users.noreply.github.com>

* Update client/cli/src/params/import_params.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

* Update client/api/src/execution_extensions.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

* Pass the offchain storage to the MMR RPC

* Update client/api/src/execution_extensions.rs

Co-authored-by: Sebastian Kunert <skunert49@gmail.com>

* Review comments

* Fixes

---------

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
2023-07-11 14:21:38 +00:00
Bastian Köcher 43a4f0345e collator-selection: Optimize length decoding (#2851)
Instead of loading always the entire `Vec` into the runtime to just decode the length, we can
directly use `decode_len` to get this info.
2023-07-11 15:15:04 +02:00
Bastian Köcherandalvicsam a2b01c061b CI: Do not fail on junit upload failure (#14545)
* CI: Do not fail on junit upload failure

* fix yaml for test-linux-stable

---------

Co-authored-by: alvicsam <alvicsam@gmail.com>
2023-07-11 11:26:44 +02:00
Bastian Köcher e3ee909e9e paras: Prune upgrade cooldowns (#7470)
After an upgrade cooldown triggered to remove a signal we also need to
prune it from the list.
2023-07-10 15:08:12 +00:00
Bastian Köcher ce038948ef Enable missing features (#7466) 2023-07-10 12:37:26 +00:00
Bastian Köcherandparity-processbot fdd2e5221e Companion for Substrate#14511 (#2821)
* Companion for Substrate#14511

https://github.com/paritytech/substrate/pull/14511

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: parity-processbot <>
2023-07-05 08:39:48 +00:00
Bastian Köcherandparity-processbot a40417da96 Companion for Substrate#14511 (#7459)
* Companion for Substrate#14511

https://github.com/paritytech/substrate/pull/14511

* Make benchmarking build without any native runtime

* Fix warning

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
2023-07-05 08:08:09 +00:00
Bastian Köcher 1bf2504ebf sc-cli: Remove SubstrateCli::native_runtime_version function (#14511)
The native runtime will be removed in the near future and thus this function will not be required
anymore.

\# Code changes

Downstream users just need to remove `native_runtime_version` from their implementation of the
`SubstrateCli` trait.
2023-07-05 07:38:06 +00:00
Bastian Köcher 429e9eae09 Companion for Polkadot#7451 (#2807)
* Companion for Polkadot#7451

https://github.com/paritytech/polkadot/pull/7451

* Update Substrate & Polkadot

* FMT

* Fix integration tests

* Bring back `polkadot-native` feature for now

* 🤦
2023-07-04 15:39:05 +00:00
Bastian Köcherandcommand-bot e53d15aa20 Do not depend on native runtimes for RuntimeApi (#7451)
* Implement runtime apis for fake runtime

These runtime api implementations are only used to make the compiler
think that we have implemented all required runtime apis. They will not
be called as we switch the executor to `WasmExecutor`. In the near
future we will not require these fake implementations anymore after
Substrate has shifted away from this compile time requirement.

This brings us the advantage that the `polkadot-service` doesn't need to
depend on the runtimes for getting the `RuntimeApi` type.

It also removes around 1min of build time on my machine ;)

* Fix warning

* FMT

* ".git/.scripts/commands/fmt/fmt.sh"

* Use more descriptive id

* Fix warnings

* Adapt path

* Fix 🙈

---------

Co-authored-by: command-bot <>
2023-07-04 10:09:14 +02:00
Bastian Köcher 79f600db70 Revert k256 removal (#14499)
* Revert "Remove k256 crate from frame-support dependencies (#14452)"

This reverts commit 4d426214af.

* Keep the test
2023-07-03 23:38:51 +02:00
Bastian Köcherandcommand-bot 42243fb346 wasm-builder: Make hash and date optional (#14490)
* wasm-builder: Make `hash` and `date` optional

Apparently there are installations where the `hash` and `date` is optional.

Closes: https://github.com/paritytech/substrate/issues/14335

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
2023-07-03 09:58:42 +00:00
Bastian Köcherandcommand-bot 698a6d1aa8 sp-api: Put frame-metadata behind some feature (#14398)
* sp-api: Put `frame-metadata` behind some feature

Closes: https://github.com/paritytech/substrate/issues/14296

* ".git/.scripts/commands/fmt/fmt.sh"

* Review feedback

---------

Co-authored-by: command-bot <>
2023-07-03 11:54:28 +02:00