Commit Graph
100 Commits
Author SHA1 Message Date
ordian 03e9dd77e9 Update pr_3302.prdoc (#3985)
Properly account for #3302, cc #3984.
2024-04-05 11:53:29 +00:00
ordianandBastian Köcher 3fc5b82653 fix regression in approval-voting introduced in #3747 (#3831)
Fixes #3826.

The docs on the `candidates` field of `BlockEntry` were incorrectly
stating that they are sorted by core index. The (incorrect) optimization
was introduced in #3747 based on this assumption. The actual ordering is
based on `CandidateIncluded` events ordering in the runtime. We revert
this optimization here.

- [x] verify the underlying issue
- [x] add a regression test

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
2024-03-26 22:59:47 +00:00
ordian 64a707a482 approval-voting: remove some inefficiences on startup (#3747)
Small refactoring to reduce the algorithmic complexity of the initial
message distribution in approval voting after a sync from O(n_candidates
^ 2) to O(n_candidates).
2024-03-21 11:22:16 +00:00
5fd72a1f5e collator-side: send parent head data (#3521)
On top of #3302.

We want the validators to upgrade first before we add changes to the
collation side to send the new variants, which is why this part is
extracted into a separate PR.

The detection of when to send the parent head is based on the core
assignments at the relay parent of the candidate. We probably want to
make it more flexible in the future, but for now, it will work for a
simple use case when a para always has multiple cores assigned to it.

---------

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matteo Muraca <56828990+muraca@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Ignacio Rios <54085674+JuaniRios@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
2024-03-19 15:01:26 +00:00
ordian 02e1a7f476 collator protocol changes for elastic scaling (validator side) (#3302)
Fixes #3128.

This introduces a new variant for the collation response from the
collator that includes the parent head data. For now, collators won't
send this new variant. We'll need to change the collator side of the
collator protocol to detect all the cores assigned to a para and send
the parent head data in the case when it's more than 1 core.

- [x] validate approach
- [x] check head data hash
2024-03-15 19:43:28 +00:00
ordianandKian Paimani 612587b7b6 do not block finality for "disabled" disputes (#3358)
- [x] test with zombienet-sdk
- [x] prdoc

Relevant Issues:
https://github.com/paritytech/polkadot-sdk/issues/3314 (connected to the
cause)
https://github.com/paritytech/polkadot-sdk/issues/3345 (solves)

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2024-02-17 02:00:22 +00:00
ordianandTsvetomir Dimitrov a4195326b9 statement-distribution: validator disabling (#1841)
Closes #1591.

The purpose of this PR is filter out backing statements from the network
signed by disabled validators. This is just an optimization, since we
will do filtering in the runtime in #1863 to avoid nodes to filter
garbage out at block production time.

- [x] Ensure it's ok to fiddle with the mask of manifests
- [x] Write more unit tests
- [x] Test locally
- [x] simple zombienet test
- [x] PRDoc

---------

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2024-01-10 10:32:52 +01:00
ordianandTsvetomir Dimitrov 0ff3f4d3af dispute-coordinator: disabling in participation (#2637)
Closes #2225.

- [x] tests
- [x] fix todos
- [x] fix duplicates
- [x] make the check part of `potential_spam` 
- [x] fix a bug with votes insertion
- [x] guide changes
- [x] docs

---------

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2024-01-09 08:44:19 +02:00
ordianandTsvetomir Dimitrov a02b53475b backport to master: Handling of disabled validators in backing subsystem (#1259) (#2764)
#1259 was merged into a feature branch, but we've decided to merge
node-side changes for disabling straight into master.
This is a dependency of #1841 and #2637.

---------

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2024-01-08 21:58:30 +02:00
ordian b0a8746aec malus: add new variant SupportDisabled (#2835)
This variant pretends that nobody is disabled onchain.
2024-01-04 14:59:12 +02:00
ordianandTsvetomir Dimitrov 909c1e4945 malus: use spawn_blocking (#2804)
Looks like using `spawn` instead of `spawn_blocking` in malus is leading
to a deadlock somehow. I'm not sure why exactly, but switching to
`spawn_blocking` fixes
https://github.com/paritytech/disabling-e2e-tests/issues/1, at least for
`suggest-garbage-candidate` (didn't check other variants).

Maybe my assumption here was wrong:
https://github.com/paritytech/polkadot-sdk/pull/2184#discussion_r1403587674.

---------

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2024-01-02 11:13:16 +01:00
ordian 5e98803f03 implementers-guide: update github link (#2368)
cc @joepetrowski
2023-11-16 21:13:04 +01:00
ordian 5ca909cc09 polkadot: eradicate LeafStatus (#1565)
Fixes #768.
2023-10-23 16:22:37 +02:00
ordian 769bdd3ff3 runtime-api: cleanup after v7 stabilization (#1729)
Follow-up to #1543.
2023-09-28 01:07:32 +02:00
ordian 15503883e2 polkadot: pin one block per session (#1220)
* polkadot: propagate UnpinHandle to ActiveLeafUpdate

Also extract the leaf creation for tests
into a common function.

* dispute-coordinator: try pinned blocks for slashin

* apparently 1.72 is smarter than 1.70

* address nits

* rename fresh_leaf to new_leaf
2023-09-07 13:24:40 +03:00
ordianandJavier Viola a47943983f zombienet: use another collator image for the slashing test (#1386)
* zombienet: use test-parachain image for the slashing test

* use the right image

* try polkadot-parachain image

* try naming collator alice 🙈

* add needed job for the pipeline

* fix user id in polkadot-parachain-debug image

* small tweaks to the test

* another small tweak

* yet another small tweak

* bump zombienet version

---------

Co-authored-by: Javier Viola <javier@parity.io>
2023-09-06 20:39:42 +02:00
ordian 89bfdb15da approval-voting: use proper hash when querying session info (#1387) 2023-09-04 16:48:12 +02:00
ordian c168a77e26 deps: replace lru with schnellru (#1217)
* deps: replace lru with schnellru

* bring the peace to the galaxy
2023-08-28 19:04:11 +02:00
ordian 7125f65fe6 less flaky dispute slashing test (#1218) 2023-08-28 19:03:44 +02:00
01a19b45e3 dispute-coordinator: past session dispute slashing (#6811)
* runtime/vstaging: unapplied_slashes runtime API

* runtime/vstaging: key_ownership_proof runtime API

* runtime/ParachainHost: submit_report_dispute_lost

* fix key_ownership_proof API

* runtime: submit_report_dispute_lost runtime API

* nits

* Update node/subsystem-types/src/messages.rs

Co-authored-by: Marcin S. <marcin@bytedude.com>

* revert unrelated fmt changes

* dispute-coordinator: past session dispute slashing

* encapsule runtime api call for submitting report

* prettify: extract into a function

* do not exit on runtime api error

* fix tests

* try initial zombienet test

* try something

* fix a typo

* try cumulus-based collator

* fix clippy

* build polkadot-debug images with fast-runtime enabled

* wip

* runtime/inclusion: fix availability_threshold

* fix wip

* fix wip II

* revert native provider

* propagate tx submission error

* DEBUG: sync=trace

* print key ownership proof len

* panic repro

* log validator index in panic message

* post merge fixes

* replace debug assertion with a log

* fix compilation

* Let's log the dispatch info in validate block.

* fix double encoding

* Revert "Let's log the dispatch info in validate block."

This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.

* Revert "Let's log the dispatch info in validate block."

This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.

* fix compilation

* update to latest zombienet and fix test

* lower finality lag to 11

* bump zombienet again

* add a workaround, but still does not work

* Update .gitlab-ci.yml

bump zombienet.

* add a comment and search logs on all nodes

---------

Co-authored-by: Marcin S. <marcin@bytedude.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Javier Viola <javier@parity.io>
2023-06-05 18:21:42 +02:00
ordianandparity-processbot 4ed61f9d31 polkompanion 6667: past session slashing (#2160)
* polkompanion 6667: past session slashing

* fix imports

* fix incorrect merge

* implement staging methods on RPC client

* update lockfile for {"polkadot", "substrate"}

---------

Co-authored-by: parity-processbot <>
2023-05-26 10:13:54 +00:00
ordianandMarcin S. 9bc4f62eff runtime: past session slashing runtime API (#6667)
* runtime/vstaging: unapplied_slashes runtime API

* runtime/vstaging: key_ownership_proof runtime API

* runtime/ParachainHost: submit_report_dispute_lost

* fix key_ownership_proof API

* runtime: submit_report_dispute_lost runtime API

* nits

* Update node/subsystem-types/src/messages.rs

Co-authored-by: Marcin S. <marcin@bytedude.com>

* revert unrelated fmt changes

* post merge fixes

* fix compilation

---------

Co-authored-by: Marcin S. <marcin@bytedude.com>
2023-05-26 09:35:46 +00:00
ordianandcommand-bot 8b91d909a3 runtime/polkadot: enable disputes rewards and slashing (#6960)
* runtime/polkadot: enable disputes rewards and slashing

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::disputes::slashing

---------

Co-authored-by: command-bot <>
2023-05-03 13:48:54 +00:00
ordian 703009fb39 malus: dont panic on missing validation data (#6952)
* malus: don't panic if can't fetch validation data

* malus: add fast-runtime feature
2023-04-26 14:03:26 +00:00
ordianandparity-processbot 439ab875dc update rocksdb to 0.20.1 (#7113)
* update rocksdb to 0.20.1

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
2023-04-21 20:37:42 +00:00
ordian 58f5cd6adb cargo upgrade --workspace kvdb-rocksdb (#13973) 2023-04-21 19:58:05 +00:00
ordian 4ed3997938 runtime/inclusion: fix availability_threshold (#6931) 2023-03-21 17:20:59 +01:00
3b493f02cd kusama: enable dispute slashes (#5974)
* disputes: runtime part of slashing

* disputes: reward winners

* disputes/slashing: validate_unsigned impl

* fmt

* disputes/slashing: report_dispute_lost_unsigned

* disputes/slashing: separate winners from losers and report winners

* disputes/slashing: refactoring

* impl HandleReports

* enable on Wenstend

* fmt

* add slashing pallet to the mock and test runtimes

* fix a bug in report_dispute_lost_unsigned

* fmt

* disputes: remove new_participants from summary

* disputes: remove punish_inconclusive

* impl SlashingHandler for Pallet for type-safety

* do not impl slashing::Config on mainnets yet

* teach spellcheck deduplication

* simplify interfaces and resolve some TODOs

* resolve some more TODOs

* minor typos

* move slashing into a folder

* remove unnecessary clone

* fix validator_set_count calculation

* introduce ValidatorSetCount

* store ValidatorSetCount

* fmt

* add the benchmark

* fmt

* unflatten slashing

* post-rebase fixes

* remove winners eagerly

* use real slashing weights for westend

* remove bench test suite

* zombinet: modify disputes test to check for an offence report

* zombinet: add a timeout

* add slashing pallet to Rococo

* zombienet: revert back to rococo-local

* fmt

* remove TODOs

* revert some accidental changes

* slashing is submodule of disputes

* Change the log target

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* wrap comments with rustfmt, more docs, constants

* use Defensive trait

* cargo update -p sp-io

* merge offence types, remove rewards for now

* cargo update -p sp-io

* benchmark fixes

* fmt

* unused var

* fix block_author impl

* ressurect RewardValidators trait

* remove outdated comment

* more module docs

* introduce BenchmarkingConfig

* typo fix

* teach spellcheck unapplied

* use Weight::new()

* fix mocking rewards

* use RefTimeWeight

* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing

* refactor maybe_identify_validators

* no more ticket in disguise

* remove outdated comments

* lower against valid to 0.1%

* bump zombienet version for debug

* use from_perthousand

* post-merge fixes

* another day, another Weight changes

* Revert "bump zombienet version for debug"

This reverts commit 371ab2dfdfd6b4ca46320a6106339bcd4a3a0b12.

* do not reward block authors

* fix outdated comment

* use Pays from frame_support::dispatch::Pays

* kusama: enable dispute slashing

* ".git/.scripts/bench-bot.sh" runtime kusama-dev runtime_parachains::disputes::slashing

* post merge fixes

* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::disputes::slashing

* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::disputes::slashing

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Javier Viola <pepoviola@gmail.com>
2023-03-21 15:10:21 +01:00
ordian d38a94acf1 av-store: skip processing finalized blocks while syncing (#6691) 2023-02-09 13:22:29 +00:00
+1 2fa8565f9d Some late short-term fixes for dispute slashing (#6249)
* disputes/slashing: slash only backers for ForInvalid

* add an assertion in mock impl

* fix tests

* do not slash backers on onconcluded disputes

* slash an intersection of backers and losers

* zombienet/disputes: check for offence only for invalid disputes

* add backing votes to disputes bench builder

* Update runtime/parachains/src/builder.rs

* Brad implementers guide revisions 2 (#6239)

* Add disputes subsystems fix

* Updated dispute approval vote import reasoning

* Improved wording of my changes

* Resolving issues brought up in comments

* Update disputes prioritisation in `dispute-coordinator` (#6130)

* Scraper processes CandidateBacked events

* Change definition of best-effort

* Fix `dispute-coordinator` tests

* Unit test for dispute filtering

* Clarification comment

* Add tests

* Fix logic

If a dispute is not backed, not included and not confirmed we
don't participate but we do import votes.

* Add metrics for refrained participations

* Revert "Add tests"

This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0.

* Revert "Unit test for dispute filtering"

This reverts commit 92ba5fe678214ab360306313a33c781338e600a0.

* fix dispute-coordinator tests

* Fix scraping

* new tests

* Small fixes in guide

* Apply suggestions from code review

Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>

* Fix some comments and remove a pointless test

* Code review feedback

* Clarification comment in tests

* Some tests

* Reference counted `CandidateHash` in scraper

* Proper handling for Backed and Included candidates in scraper

Backed candidates which are not included should be kept for a
predetermined window of finalized blocks. E.g. if a candidate is backed
but not included in block 2, and the window size is 2, the same
candidate should be cleaned after block 4 is finalized.

Add reference counting for candidates in scraper. A candidate can be
added on multiple block heights so we have to make sure we don't clean
it prematurely from the scraper.

Add tests.

* Update comments in tests

* Guide update

* Fix cleanup logic for `backed_candidates_by_block_number`

* Simplify cleanup

* Make spellcheck happy

* Update tests

* Extract candidate backing logic in separate struct

* Code review feedback

* Treat  backed and included candidates in the same fashion

* Update some comments

* Small improvements in test

* spell check

* Fix some more comments

* clean -> prune

* Code review feedback

* Reword comment

* spelling

Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>

* approval-voting: remove redundant validation check (#6266)

* approval-voting: remove a redundant check

* candidate-validation: remove unreachable check

* remove fill_block (#6200)

Co-authored-by: parity-processbot <>

* fix a compilation warning (#6279)

Fixes #6277.

* Only report concluded if there is an actual dispute. (#6270)

* Only report concluded if there is an actual dispute.

Hence no "non"-disputes will be added to disputes anymore.

* Fix redundant check.

* Test for no onesided disputes.

Co-authored-by: eskimor <eskimor@no-such-url.com>

* [ci] fix buildah image (#6281)

* Revert special casing of Kusama for grandpa rounds. (#6217)

Co-authored-by: eskimor <eskimor@no-such-url.com>

* Fixes "for loop over an `Option`" warnings (#6291)

Was seeing these warnings when running `cargo check --all`:

```
warning: for loop over an `Option`. This is more readably written as an `if let` statement
    --> node/core/approval-voting/src/lib.rs:1147:21
     |
1147 |             for activated in update.activated {
     |                              ^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(for_loops_over_fallibles)]` on by default
help: to check pattern in a loop use `while let`
     |
1147 |             while let Some(activated) = update.activated {
     |             ~~~~~~~~~~~~~~~         ~~~
help: consider using `if let` to clear intent
     |
1147 |             if let Some(activated) = update.activated {
     |             ~~~~~~~~~~~~         ~~~
```

My guess is that `activated` used to be a SmallVec or similar, as is
`deactivated`. It was changed to an `Option`, the `for` still compiled (it's
technically correct, just weird), and the compiler didn't catch it until now.

* companion for #12599 (#6290)

* companion for #12599

* update Cargo.lock

* use cargo path instead of diener

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

* remove the runtime check and test

* append keys on past-session slashing

* runtime/disputes: allow importing backing votes after explicit for

* explicit MaliciousBacker error and a test

* update an outdated comment

* Revert "update an outdated comment"

This reverts commit 7c4c3f5a848f16e2b61435e981d814f00333ed41.

* Revert "remove the runtime check and test"

This reverts commit a5bff0c75e77effb5b7d3a1691de1b14bcdbd648.

* incremental punishment post conclusion + test

* punish backers post FOR vote

* remove unnecessary lifetime annotation

* add a comment to zombinet test

* typo

* fmt

* post merge test fixes

* fix test after changes in master

* address review nits

---------

Co-authored-by: Bradley Olson <34992650+BradleyOlson64@users.noreply.github.com>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Sergej Sakac <73715684+Szegoo@users.noreply.github.com>
Co-authored-by: eskimor <eskimor@users.noreply.github.com>
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Marcin S <marcin@bytedude.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
2023-02-01 11:36:05 -03:00
ordian 1c695b815e add erasure-coding benches (#6308)
* add erasure-code benches

* revert Cargo.lock changes

* revert Cargo.lock changes
2023-01-16 12:04:54 +01:00
ordian 45acf6e402 av-store: write meta for unknown finalized blocks (#6452)
* av-store: write meta for unknown finalized blocks

* fix test
2023-01-05 18:25:21 +01:00
ordian d72775d37c cargo update -p libp2p-yamux (#6464) 2022-12-22 12:23:44 +01:00
ordian 063aab236f guide: remove refences to outdated secondary checkers (#6309)
* guide: remove refences to outdated secondary checkers

* Update roadmap/implementers-guide/src/glossary.md

* guide: remove refences to Fisherman

* revert changes to roadmap/parachains.md
2022-11-30 13:28:35 +01:00
ordian 5311911a39 cargo update -p sp-io (#6351) 2022-11-27 14:33:59 +00:00
Andronik e4eb6266f8 fix a compilation warning (#6279)
Fixes #6277.
2022-11-13 19:14:24 +00:00
Andronik 283f40f3ed approval-voting: remove redundant validation check (#6266)
* approval-voting: remove a redundant check

* candidate-validation: remove unreachable check
2022-11-12 11:52:26 +00:00
f1cab419a3 pov-recovery: try connect to validators (#1711)
* zombienet/pov-recovery: do not setup reserved connection for collators

* connect eve to dave

* REVERTME: diener update --polkadot --branch ao-recovery-try-connect

* REVERTME: cargo update -p sp-io

* REVERTME: cargo update -p sp-io and hope for the best

* pass reserved flags for eve after --

* Revert "REVERTME: cargo update -p sp-io and hope for the best"

This reverts commit 0d66b70e5ccedc7a35bcf1b30a070e68cd6a8ccc.

* Revert "REVERTME: cargo update -p sp-io"

This reverts commit f8d16c375afd41b8e0c84b59fe62019b86ba95b9.

* REVERTME: cargo update -p sp-io

* Revert "REVERTME: cargo update -p sp-io"

This reverts commit d48e1e6aa2134591b285e284077a063356d44eed.

* REVERTME: cargo update -p sp-io

* REVERTME: cargo update -p sp-io

* try some logs and flags

* apply some suggestions from Sebastian

* let Charlie produce blocks

* Revert "REVERTME: cargo update -p sp-io"

This reverts commit 02838a656eadfcbd26520e6b60ee21ffd8b27afd.

* git checkout master Cargo.lock

* Revert "REVERTME: diener update --polkadot --branch ao-recovery-try-connect"

This reverts commit 8ae8d5347b787ce5e08d6fdb5e7f266299fd70dd.

* zombienet/pov-recovery: 4 validators

* REVERTME: diener update --polkadot --branch ao-recovery-try-connect && cargo update -p polkadot-primitives

* Revert "REVERTME: diener update --polkadot --branch ao-recovery-try-connect && cargo update -p polkadot-primitives"

This reverts commit 3cc918220de5bf8ca5368586e55556464d106afd.

* make sure it is not due to backing group connections

* clean up flags

* try no-mdns on collators, limit out-peers on validators

* try no-mdns on validators and bob

* fix bob flag

* try 7 validators (3 chunks needed for recovery)

* reserved-only on validators

* reserved-only on alice and charlie

* explicitly pass log targets

* rm default_args

* parachain=debug and cumulus-pov-recovery=debug

* try another idea

* try 13 validators (4 chunks required)

* bump block height to 20

* Register parachain after 20sec, increase block target to 20

* bump zombienet version

* remove debug

* bump zombienet

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
2022-10-19 10:02:29 +00:00
Andronik befaec4cee availability-recovery: use IfDisconnected::TryConnect for chunks (#6081)
* availability-recovery: use `IfDisconnected::TryConnect` for chunks

* fix tests
2022-10-18 13:15:49 +00:00
Andronik 96bb39a6b9 lingua.dic is not managed by CI team (#6148) 2022-10-13 14:31:32 +02:00
AndronikandAlexander Samusev a4e33b13ac ci/guide: install mdbook-graphviz (#6119)
* ci/guide: install mdbook-graphviz

* install graphviz in build-implementers-guide

* Update scripts/ci/gitlab/pipeline/build.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
2022-10-10 09:41:04 +00:00
AndronikBastian Köcherparity-processbot
af6a5cd96a update kvdb & co (#6111)
* toml changes

* REVERTME: patch

* adapt parachains db interface

* fix Cargo.toml patch after master rebase

* fix av-store

* fix chain-selection

* fix parachains-db?

* Revert "fix Cargo.toml patch after master rebase"

This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.

* Revert "REVERTME: patch"

This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.

* Use `Ok` imported from prelude

Co-authored-by: Bastian Köcher <info@kchr.de>

* update lockfile for {"substrate"}

* Revert "update lockfile for {"substrate"}"

This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.

* cargo update -p sp-io

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: parity-processbot <>
2022-10-05 22:36:51 +00:00
Andronik 9e423925f6 update kvdb & co (#12312)
* upgrade kvdb & co

* remove patch

* update Cargo.lock

* upgrade impl-serde

* fix parsing test

* actually fix it

* FFS
2022-10-05 21:07:15 +00:00
AndronikandTsvetomir Dimitrov 4df643271d make spellcheck green again (#6059)
* make spellcheck green again

* remove the comment

* Fix a comment in `provisioner`

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
2022-09-27 08:48:49 +00:00
Andronik 5dd7026383 orchestra: hide subsystem cycle warnings by default (#6047) 2022-09-26 12:39:56 +00:00
18c077a818 runtime/disputes: slashing (#5535)
* disputes: runtime part of slashing

* disputes: reward winners

* disputes/slashing: validate_unsigned impl

* fmt

* disputes/slashing: report_dispute_lost_unsigned

* disputes/slashing: separate winners from losers and report winners

* disputes/slashing: refactoring

* impl HandleReports

* enable on Wenstend

* fmt

* add slashing pallet to the mock and test runtimes

* fix a bug in report_dispute_lost_unsigned

* fmt

* disputes: remove new_participants from summary

* disputes: remove punish_inconclusive

* impl SlashingHandler for Pallet for type-safety

* do not impl slashing::Config on mainnets yet

* teach spellcheck deduplication

* simplify interfaces and resolve some TODOs

* resolve some more TODOs

* minor typos

* move slashing into a folder

* remove unnecessary clone

* fix validator_set_count calculation

* introduce ValidatorSetCount

* store ValidatorSetCount

* fmt

* add the benchmark

* fmt

* unflatten slashing

* post-rebase fixes

* remove winners eagerly

* use real slashing weights for westend

* remove bench test suite

* zombinet: modify disputes test to check for an offence report

* zombinet: add a timeout

* add slashing pallet to Rococo

* zombienet: revert back to rococo-local

* fmt

* remove TODOs

* revert some accidental changes

* slashing is submodule of disputes

* Change the log target

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* wrap comments with rustfmt, more docs, constants

* use Defensive trait

* cargo update -p sp-io

* merge offence types, remove rewards for now

* cargo update -p sp-io

* benchmark fixes

* fmt

* unused var

* fix block_author impl

* ressurect RewardValidators trait

* remove outdated comment

* more module docs

* introduce BenchmarkingConfig

* typo fix

* teach spellcheck unapplied

* use Weight::new()

* fix mocking rewards

* use RefTimeWeight

* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing

* refactor maybe_identify_validators

* no more ticket in disguise

* remove outdated comments

* lower against valid to 0.1%

* bump zombienet version for debug

* use from_perthousand

* post-merge fixes

* another day, another Weight changes

* Revert "bump zombienet version for debug"

This reverts commit 0d9978711f8ec9a746a5e1c45e8ffbe7c75e7b5c.

* do not reward block authors

* fix outdated comment

* use Pays from frame_support::dispatch::Pays

* add timeout to is up

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Javier Viola <pepoviola@gmail.com>
2022-09-20 10:56:55 +00:00
Andronik bbb713521e gossip-support: disconnect when we're no longer in other's reserved set (#6024)
* gossip-support: disconnect when we're no longer in the reserved set

* fmt
2022-09-19 19:26:41 +00:00
Andronik afc7dd3735 node/core/pvf: strip some deps (#6016) 2022-09-15 12:25:03 +00:00
Andronik c79dd8751c disputes rewards (#5862)
* refactor backing points to only reward active set

* impl disputes::RewardValidators

* enable rewards on westend, kusama, polkadot

* fmt

* make dispute points same as backing

* disable on polkadot for now
2022-09-08 13:36:01 +02:00
Andronik f0c74f6bc5 candidate-validation: info logs on failure (#5957) 2022-09-02 09:31:44 +02:00
Andronik 138aae0a22 fix cargo check -p polkadot-node-core-provisioner --all-features (#5942) 2022-08-30 20:42:34 +00:00
Andronik 0cda69d34a offences: make fn slash_fraction non-static (#11956)
* offences: make fn slash_fraction non-static

* Bastifmt (inline variable)
2022-08-02 18:49:03 +00:00
Andronikandparity-processbot f26f845ac7 companion for https://github.com/paritytech/polkadot/pull/5770 (#1442)
* companion for https://github.com/paritytech/polkadot/pull/5770

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>
2022-07-23 00:03:07 +00:00
Andronik b1f8445d62 malus: add finality_delay cli flag (#5770)
* add malus_finality_delay flag

* cargo update -p sp-io

* no warnings when malus is disabled

* subpar workaround for feature unification problem

* remove malus_finality_delay from regular cli

* document finality_delay param, rename cli arg
2022-07-22 23:24:33 +00:00
Andronik c9fd6b8e65 expose grandpa BeforeBestBlockBy voting rule (#11798) 2022-07-08 12:27:58 +00:00
AndronikandJavier Viola 8ba03ac6d2 zombienet: try to fix parachains upgrade test (#5724)
* zombienet: try to fix parachains upgrade test

* try a different collator image

* Revert "try a different collator image"

This reverts commit c83b2929f5a703be0979b4429ab01808408b074d.

* try setting cumulusBased

* fix zombienet upgrade test

* change image

* update command for test

* update zombienet image

* bump zombienet version

* bump zn version

* Revert "try setting cumulusBased"

This reverts commit 0312fa0a7a19065e097b186a08757938abd7c130.

* Revert "update command for test"

This reverts commit 81707e30188a1838e952d66deedaecbff6cb2971.

* Revert "change image"

This reverts commit 43a4f4a6a0286f5bf6698a44b82de835a723b531.

* zombienet: change validator image to a PR branch

Co-authored-by: Javier Viola <javier@parity.io>
2022-06-28 09:15:12 +00:00
Andronik e3330164a7 reward_points: refactor backing reward points (#5474) 2022-05-17 14:08:39 +00:00
Andronik 15e7536a4e runtime/session_info: keep track of stash keys (#5473) 2022-05-12 09:36:57 +00:00
Andronik 69af87a199 more verbose assignment cert errors (#5433)
* more verbose assignment cert errors

* rename a variant to InvalidAssignmentKey
2022-05-04 14:45:11 +02:00
Andronik 6bfa097142 make spellcheck green again (#5428) 2022-05-02 10:20:45 +02:00
Andronik ff18cabbc5 remove old pallet migrations (#5194)
* remove old pallet migrations

* remove more stuff
2022-04-13 10:01:57 +00:00
AndronikandParity Bot dc25b326ba runtime/westend: add disputes (#5046)
* runtime/westend: add disputes

* cargo run --quiet --profile=production  --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_disputes.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_disputes.rs

Co-authored-by: Parity Bot <admin@parity.io>
2022-03-07 19:50:58 +00:00
55e2ddd91c CI: add rococo to the runtime check (#5013)
* ci: add rococo for runtime changes check

* rococo: bump spec_version to 9180

* Update Rococo to 1-day lease (#4761)

* changed lease period to 1 day

* bumped version

* bumped version again

* changed 356 to 365 days to mimic one year

Co-authored-by: Santi Balaguer <santibalaguer@Santis-MacBook-Pro.local>

* rococo: bump spec_version to 9170 for consistency

Co-authored-by: Santi Balaguer <santiago.balaguer@gmail.com>
Co-authored-by: Santi Balaguer <santibalaguer@Santis-MacBook-Pro.local>
2022-03-02 09:14:38 +00:00
Andronik 91ea5bbf57 dispute-distribution: downgrade a warn (#5003)
* dispute-distribution: downgrade a warn

* change at the logging side instead
2022-03-01 11:01:15 +00:00
Andronik 9d9f82256e approval-distribution: a fix for out-of-view messages (#4908)
* approval-distribution: a fix for out-of-view messages

* approval-distribution: trace logs

* adjust the guide slightly

* comments and nits
2022-02-22 15:02:03 +00:00
Andronik 128421b5dd collator-protocol: fix wrong warning (#4909)
* collator-protocol: fix wrong warning

* collator-protocol: add debug log
2022-02-11 18:31:50 +01:00
Andronik 48ed5843ae rm unused deps (#4857)
* rm unused deps

* post merge fix
2022-02-08 11:36:29 +00:00
Andronik db4cff49ca parainherent: fix session in OnChainVotes 2022-01-30 21:50:40 +01:00
Andronik 9ce2798d5b dispute-coordinator: more useful logs 2022-01-30 21:50:40 +01:00
Andronik 762d77e3ec refactor runtime cache for SessionInfo (#4723) 2022-01-15 20:10:09 +00:00
Andronik 6ad8139c39 spellcheck fixes (#4724) 2022-01-15 14:11:31 +00:00
Andronik 5e308e3fee runtime-api: do not cache None SessionInfo (#4706)
* approval-voting: add more logs

* approval-voting: query finalized block on startup and increase look back

* runtime-api: do not cache None SessionInfo
2022-01-13 08:15:59 +00:00
Andronik d4ff5699f0 approval-voting: query finalized block on startup and increase look back (#4705)
* approval-voting: add more logs

* approval-voting: query finalized block on startup and increase look back
2022-01-13 08:15:39 +00:00
Andronik fc7e6047d9 approval-voting: add more logs (#4704) 2022-01-12 19:22:47 +00:00
Andronik c805500dfb zombinet: bump collator image (#4668) 2022-01-07 09:04:20 +01:00
Andronik 868556256e lower debug level for testnet build (#4658) 2022-01-04 13:38:50 +00:00
Andronik aff88a864a collator-protocol: short-term fixes for connectivity (#4640)
* collator-protocol: add to reserved peers on every relay parent

* bump collator slots from 25 to 100

* collator-protocol: reduce inactivity timeout from 24s to 5s

* try to satisfy spellcheck

* add connection log

* fmt

* bring a warn back

* gather validators across all active leaves
2022-01-04 12:58:47 +01:00
AndronikandJavier Viola a44349f652 custom cargo profiles for production (#4627)
* add custom profiles and specify MSVR as 1.57

* fix host-perf-check command

* use testnet profile for CI images

* do not do lto for testnet profile

* fix artifact path

* test with testnet profile to reuse build artifacts

* Revert "fix host-perf-check command"

This reverts commit f1d15492204b8251685a97636cbb5a5f394f21da.

* bump zombienet version

Co-authored-by: Javier Viola <javier@parity.io>
2021-12-29 14:10:40 +00:00
Andronik Ordian 3ae4f0a176 update polkadot (#877) 2021-12-28 08:07:38 +01:00
Andronik OrdianandJavier Viola d077ac2c5e zombienet: fixed adder-collator image for the smoke test (#4600)
* zombinet: fixed adder-collator image for the smoke test

* update COL_IMAGE

* bump zombienet version

* try a different version

Co-authored-by: Javier Viola <javier@parity.io>
2021-12-27 13:29:37 +01:00
Andronik Ordian 9efb223a97 session_info: add dispute_period and random_seed (#4547) 2021-12-27 09:03:50 +00:00
Andronik Ordianandparity-processbot 09b8d7435e companion for polkadot#4545 (session-info v2) (#875)
* companion for https://github.com/paritytech/polkadot/pull/4545

* update lockfile for polkadot

Co-authored-by: parity-processbot <>
2021-12-27 08:34:08 +00:00
Andronik OrdianandJavier Viola b342ae11d3 session-info: add new fields + migration (#4545)
* session_info: v2 + migration

* use primitives::v2

* use polkadot_primitives::v2

* impl primitives::v2

* fix approval-voting tests

* fix other tests

* hook storage migration up

* backwards compat (1)

* backwards compat (2)

* fmt

* fix tests

* FMT

* do not reexport v1 in v2

* fmt

* set storage version to 1

Co-authored-by: Javier Viola <javier@parity.io>
2021-12-27 08:01:30 +00:00
Andronik Ordian 7acfd4f80a companion for polkadot#4542 (#873)
* new ParachainHost methods

* update polkadot
2021-12-22 13:58:53 +01:00
Andronik Ordian 5442e7a928 cargo update -p polkadot-primitives (#809) 2021-11-29 18:12:59 +01:00
Andronik Ordian fa1080a03a req/resp: use IfDisconnected::ImmediateError (#4253)
* req/resp: use IfDisconnected::ImmediateError

* remove outdated comments

* fmt
2021-11-12 17:01:52 +00:00
Andronik Ordian 760d6804dc collator-protocol: do not connect to the next group (#4261)
* collator-protocol: do not connect to the next group

* fmt
2021-11-11 15:38:41 -06:00
Andronik Ordian 77cf73c1b1 bump rococo spec (#4189)
* bump rococo spec_version

* replace the spec file

* bump rococo chain id

* use rococo-staging
2021-10-31 23:52:16 +00:00
Andronik Ordian f52bd38215 collator-protocol/validator_side: a couple of fixes (#4179)
* collator-protocol/validator: do not wait 1s to poll requested collations

* collator-protocol/validator: do not request collation for the next group

* put everything into select

* fmt

* more hacks yay

* a test

* review nits

* remove outdated comment
2021-10-30 14:20:48 -05:00
Andronik Ordian 7b1ee41c95 bump finality safety net depth to 500 blocks (#4178) 2021-10-29 13:07:10 +00:00
Andronik Ordian 9d4efa340e enable disputes feature in CI (#4168) 2021-10-28 08:40:13 -05:00
Andronik Ordian 8aba3ea8ca some spelling fixes (#4088)
* quotes around Job::ToJob
* add new words to dictionary
2021-10-18 11:59:46 +02:00
Andronik Ordian d7faa5b875 enable ApprovalCheckingVotingRule on Polkadot (#4072)
* enable ApprovalCheckingVotingRule on Polkadot

* fmt
2021-10-15 08:11:45 -05:00
Andronik Ordian ce1a110574 update polkadot (#664) 2021-10-15 10:03:31 +02:00
47202727cf validator-discovery: don't remove multiaddr of requested PeerIds (#4036)
* validator-discovery: remove from peer set before inserting

* bump spec versions

* rework into a companion

* fmt

* fix

* fix

* one more time

* one more try

* one more try

* Revert "one more try"

This reverts commit ab6568d3b828a33dc06f5650037597fc88dd06b1.

* one more try

* one more try

* Revert "one more try"

This reverts commit 8d7369f7b78633bd1b1c5ba3e0f2a0544bdd77a5.

* fix a warning

* fix another warn

* correct log

* fix compilation

* ffs

* less cloning

* Apply suggestions from code review

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>

* add comments and a small refactoring

* use set_reserved_peers

* cargo update -p sp-io

* rename added to num_peers

* update Substrate

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: parity-processbot <>
2021-10-08 16:12:57 +00:00
Andronik Ordian 12f958faa8 NetworkService: change remove_from_peers_set to accept PeerIds (#9964)
* NetworkService: expose split_multiaddr_and_peer_id

* Revert "NetworkService: expose split_multiaddr_and_peer_id"

This reverts commit 47b9a0d57c3617e64d01c449afca8896bd4bb6b6.

* change remove_from_peer_set to accets PeerIds

* fixes

* try fixing it

* try fixing it again

* FMT

* revert me

* Revert "revert me"

This reverts commit 1ea34f473f1aedc8b3e6e888d1ad2e1b45eaa1e0.
2021-10-08 15:31:18 +00:00
Andronik Ordian fe8bba1e9a change genesis authority set for wococo-local, revert rococo-local (#3998) 2021-10-03 06:26:32 -05:00
Andronik Ordian e0a0b5612e docs: make collators actually work (#638)
* docs: make collators actually work

* bump polkadot

* include recent fix for overseer
2021-10-02 21:00:18 +02:00
Andronik Ordian 679c51eb57 some tweaks to rococo-local (#3996)
* some tweaks to rococo-local

* rococo-local, not staging
2021-10-02 13:40:56 +00:00
Andronik Ordian 9825eb9fb2 av-store: clean up StoreAvailableData message (#3984)
* av-store: clean up StoreAvailableData message

* fmt

* use named fields
2021-10-01 17:33:39 +00:00