ae75a371bf
Adding benchmarking for new frame_election_provider_support ( #11149 )
...
* First stab at adding benchmarking for
`election-provider-support` onchain
* Adding `BoundedPhragMMS` and fixing stuff
* Fixing node runtime
* Fixing tests
* Finalising all benchmarking stuff
* better comments
* Better benchmarking config
* Better `WeightInfo` and benchmarking
* Fixing tests
* Adding some documentation
* Fixing some typos
* Incorporating review feedback
* cleanup of rustdocs
* rustdoc changes
* changes after code review
* Fixing some errors.
* Fixing dependencies post merge
* Bringing back `UnboundedExecution`
* Better rustdoc and naming
* Cargo.toml formatting
2022-04-15 10:15:01 +00:00
7dca0e467c
pallet_assets : Remove event for no_op ( #11023 )
...
* remove no_op event
* ensure no transferred event emitted
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-04-14 19:41:42 +00:00
c56e8f684f
Rb staking pallet validator commission change event ( #10827 )
...
* commission-changed-event-and-deposit
* deposit_event fix
* commission_changed_event_works
* fmt
* CommissionChanged -> ValidatorPrefsUpdated
* event ValidatorPrefs
* updated commet
* fmt
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/staking/src/pallet/mod.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Update frame/staking/src/tests.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
2022-04-14 16:25:54 +00:00
e5c33d8aa4
Update wasmtime to 0.35.3 ( #11058 )
...
* Update wasmtime to 0.35.2 and default `zstd` features in all crates
* Update wasmtime to 0.35.3
2022-04-14 15:07:36 +02:00
001ade9c5d
Make the generic of CliConfiguration explicit ( #11223 )
...
Othewise the compiler will complain if someone passes something that
implements `CliConfiguration<DVC>` but `DVC` is not the default `()`.
2022-04-14 11:18:54 +02:00
298fdf3012
authority-discovery: Fix flaky test ( #11219 )
...
It can happen that `+ 1` overflows `p.signature[1]` ;D (I have seen this in the CI).
2022-04-13 17:01:36 +02:00
c028d38645
Document the chain spec format ( #11208 )
...
* Document the chain spec format
* Update client/chain-spec/src/lib.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
* Update client/chain-spec/src/lib.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
* Apply suggestions from code review
Co-authored-by: Sacha Lansky <sacha@parity.io >
* Update client/chain-spec/src/lib.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Update client/chain-spec/src/lib.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Mention extensions
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Sacha Lansky <sacha@parity.io >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2022-04-13 16:53:35 +02:00
8a49af27ad
[ci] fix publish-docker-substrate job ( #11218 )
2022-04-13 14:22:25 +02:00
ca658002a8
Fix WASM block producer panic ( #11206 )
...
* Box events
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Box events"
This reverts commit 9fb1887cd23eb272844d63640b0b2d9ba3e549a1.
* Revert "Fix tests"
This reverts commit 981c50f23a7c514c9527299734bc6bc5b77a817f.
* Use simpler approach
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-04-13 11:55:14 +00:00
80ce5c5768
Expose MMR root through runtime API - use it in BEEFY client ( #11183 )
...
* beefy-gadget: allow custom runtime api provider
* beefy-gadget: use mock runtime api in tests
* pallet-mmr: expose mmr root from state through runtime API
* beefy-gadget: get mmr root from runtime state
* pallet-beefy-mmr: remove MmrRoot from header digests
* frame/mmr: move mmr primitives out of frame
* frame/mmr: completely move primitives out of frame
* address review comments
* beefy-mmr: bring back mmr root from header digest
* clippy fixes for rustc 1.60
* address review comments
2022-04-13 10:13:06 +00:00
3fec108263
Bump soketto to v0.7.1 ( #11203 )
...
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-04-12 22:43:10 +02:00
ba8beeed32
CI: rename ambiguous jobs ( #11207 )
2022-04-12 15:53:03 +02:00
cc4b5c4818
Finality notification: Optimize calculation of stale heads ( #11200 )
...
* Finality notification: Optimize calculation of stale heads
While looking into some problem on Versi where a collator seemed to be stuck. I found out that it
was not stuck but there was a huge gap between last finalized and best block. This lead to a lot
leaves and it was basically trapped inside some loop of reading block headers from the db to find
the stale heads. While looking into this I found out that `leaves` already supports the feature to
give us the stale heads relative easily. However, the semantics change a little bit. Instead of
returning all stale heads of blocks that are not reachable anymore after finalizing a block, we
currently only return heads with a number lower than the finalized block. This should be no problem,
because these other leaves that are stale will be returned later when a block gets finalized which
number is bigger than the block number of these leaves.
While doing that, I also changed `tree_route` of the `FinalityNotification` to include the
`old_finalized`. Based on the comment I assumed that this was already part of it. However, if
wanted, I can revert this change.
* FMT
* Update client/service/src/client/client.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
* Do not include the last finalized block
* Rename function
* FMT
* Fix tests
* Update figure
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2022-04-12 13:12:53 +02:00
f84fc59892
add has_identity ( #11197 )
...
* add has_identity
* Update frame/identity/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* update
* update
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2022-04-12 05:26:34 +00:00
8351ada6a3
Add new hardware and software metrics ( #11062 )
...
* Add new hardware and software metrics
* Move sysinfo tests into `mod tests`
* Correct a typo in a comment
* Remove unnecessary `nix` dependency
* Fix the version tests
* Add a `--disable-hardware-benchmarks` CLI argument
* Disable hardware benchmarks in the integration tests
* Remove unused import
* Fix benchmarks compilation
* Move code to a new `sc-sysinfo` crate
* Correct `impl_version` comment
* Move `--disable-hardware-benchmarks` to the chain-specific bin crate
* Move printing out of hardware bench results to `sc-sysinfo`
* Move hardware benchmarks to a separate messages; trigger them manually
* Rename some of the fields in the `HwBench` struct
* Revert changes to the telemetry crate; manually send hwbench messages
* Move sysinfo logs into the sysinfo crate
* Move the `TARGET_OS_*` constants into the sysinfo crate
* Minor cleanups
* Move the `HwBench` struct to the sysinfo crate
* Derive `Clone` for `HwBench`
* Fix broken telemetry connection notification stream
* Prevent the telemetry connection notifiers from leaking if they're disconnected
* Turn the telemetry notification failure log into a debug log
* Rename `--disable-hardware-benchmarks` to `--no-hardware-benchmarks`
2022-04-11 18:46:53 +09:00
f517e57f67
Prepare for rust stable 1.60 ( #11138 )
...
* Prepare for rust stable 1.59
Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.
* Ensure we run the UI tests in CI
* use staging ci image
* More test updates
* Unignore test (#11097 )
* empty commit for pipeline rerun
* empty commit for pipeline rerun
* Try to make clippy happy
* More clippy fixes
* FMT
* ci image production
Co-authored-by: alvicsam <alvicsam@gmail.com >
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com >
2022-04-11 11:21:54 +02:00
d20a10dee3
Updated docs for method set_payee & set_controller ( #11192 )
...
* Updated docs for method 'set_payee'
* Updated docs for method 'set_controller'
2022-04-11 08:36:13 +00:00
03ab76e9c7
add sort & try_append to bounded_vec ( #11196 )
2022-04-11 10:35:25 +02:00
641a43a05d
Normalization of CLI options format (CamelCase => kebab-case) ( #11194 )
...
* Convert cli options from 'CamelCase' to 'kebab-case'
* Remove not required 'as_str' for 'ExecutionStrategy' option
2022-04-11 09:45:45 +02:00
9090f0d2a2
Remove useless trait bound and move instructions ( #11193 )
...
* Remove useless trait bound and `move` instructions
* cargo fmt
2022-04-09 12:08:46 +00:00
f4336fafb7
Add GHA for custom PR review ( #10951 )
...
* Add GHA for custom PR review
* Change FILES rule settings
* Update rules according to feedback
* Update .github/pr-custom-review.yml
Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com >
* CI: PRCR new 🔒 team is locks-review
* CI: rename a confusing step
* Update .github/workflows/pr-custom-review.yml
Co-authored-by: João Paulo Silva de Souza <77391175+joao-paulo-parity@users.noreply.github.com >
* CI: use a proper new team for
as per discussion with @drahnr it was decided to create a dedicated team for reviewing runtime files
* Update pr-custom-review.yml
* Update .github/workflows/pr-custom-review.yml
Co-authored-by: João Paulo Silva de Souza <77391175+joao-paulo-parity@users.noreply.github.com >
* Update .github/workflows/pr-custom-review.yml
Co-authored-by: João Paulo Silva de Souza <77391175+joao-paulo-parity@users.noreply.github.com >
Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com >
Co-authored-by: TriplEight <denis@parity.io >
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io >
Co-authored-by: João Paulo Silva de Souza <77391175+joao-paulo-parity@users.noreply.github.com >
2022-04-08 17:39:10 +02:00
1411e028aa
Catch panics on the FFI boundary between the runtime and the host for wasmtime ( #11189 )
...
* Catch panics on the FFI boundary between the runtime and the host for `wasmtime`
* Use an already existing test runtime function
* Merge the tests together
2022-04-08 11:26:47 +00:00
2a5c11e2cc
Bump lru from 0.7.3 to 0.7.5 ( #11190 )
...
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.3 to 0.7.5.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.3...0.7.5 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-08 10:18:25 +00:00
34ddda6101
Bump impl-trait-for-tuples from 0.2.1 to 0.2.2 ( #11171 )
...
Bumps [impl-trait-for-tuples](https://github.com/bkchr/impl-trait-for-tuples ) from 0.2.1 to 0.2.2.
- [Release notes](https://github.com/bkchr/impl-trait-for-tuples/releases )
- [Commits](https://github.com/bkchr/impl-trait-for-tuples/compare/v0.2.1...v0.2.2 )
---
updated-dependencies:
- dependency-name: impl-trait-for-tuples
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-08 10:41:21 +02:00
04bd1b9bba
fix .github/pr-custom-review.yml ( #11187 )
2022-04-08 10:38:51 +03:00
a7261180ee
Sub-commands for benchmark ( #11164 )
...
* Restructure benchmark commands
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add benchmark block test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fixup imports
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Extend error message
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Apply suggestions from code review
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add commands to node-template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Zeke Mostov <z.mostov@gmail.com >
2022-04-07 19:33:11 +00:00
ef5c4b7fc3
update pr-custom-review.yml ( #11169 )
...
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
2022-04-07 16:23:33 +02:00
ec6a4db6f6
Improve docs of remove_all and remove_prefix ( #11182 )
...
These docs didn't mention how the removal works internally. This is important for the user to know
that calling such a method multiple times in the same block leads always to the same result.
2022-04-07 15:00:30 +02:00
ca1261ee21
Apply WeightToFeePolynomials to pallet_transaction_payment's length fee ( #10785 )
...
* Apply WeightToFeePolynomials to length fee
* Remove TransactionByteFee
* Add test cases for ConstantModifierFee
* Restore import
* Use pallet::constant_name
* Remove irrelevant TODO comment
* Update frame/support/src/weights.rs
* Update frame/transaction-payment/src/lib.rs
* Update frame/transaction-payment/src/lib.rs
* Update frame/transaction-payment/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* s/ConstantModifierFee/ConstantMultiplier/
* Impl LengthToFee for test configs
* fmt
* Remove unused import
* Impl WeightToFeePolynomial for byte fee in ExtBuilder
* Remove unused import
* fix doc
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-04-07 11:24:59 +00:00
b438b47f1a
relax input conditions of fixed::checked_from_integer ( #11159 )
...
* relax input conditions of fixed::checked_from_integer
* Fix build
2022-04-07 07:46:51 +00:00
1df943cd6d
chore: update jsonrpsee to v0.10.1 ( #11173 )
...
* fix(bin/node): remove unsed dep jsonrpsee
* chore(remote ext): update jsonrpsee v0.10.1
* chore(try runtime): update jsonrpsee v0.10.1
* Update utils/frame/try-runtime/cli/src/commands/follow_chain.rs
* cargo fmt
2022-04-07 06:47:36 +00:00
fc4bd3c4fd
[ci] Remove vault ( #11179 )
...
* [ci] Remove vault
* remove anchors
2022-04-06 18:20:15 +02:00
2bdebbcb00
Grandpa revert procedure ( #11162 )
...
* Grandpa revert procedure
* Trigger ci pipeline
* Test rename
* Update client/finality-grandpa/src/authorities.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2022-04-06 16:23:57 +02:00
845e37609b
Fix fork-tree descendent check ( #11150 )
...
* Fix fork-tree descendent check
* Add test assertions for the fix
* Improve documentation
* Nitpicks
2022-04-06 10:19:14 +02:00
b3dc304fd0
Change default execution strategies to Wasm ( #11170 )
...
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the
native runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.
This will also improve the usage for people who want to run random commits, which most often forget
to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of
using the native runtime.
2022-04-06 09:55:55 +02:00
7efac8c844
Bump enumflags2 from 0.6.4 to 0.7.4 ( #11108 )
...
* Bump enumflags2 from 0.6.4 to 0.7.4
Bumps [enumflags2](https://github.com/NieDzejkob/enumflags2 ) from 0.6.4 to 0.7.4.
- [Release notes](https://github.com/NieDzejkob/enumflags2/releases )
- [Commits](https://github.com/NieDzejkob/enumflags2/compare/v0.6.4...v0.7.4 )
---
updated-dependencies:
- dependency-name: enumflags2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* use `#[bitflags]` attribute macro
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-04-05 21:14:49 +00:00
14333e3074
Upgrade to wasmer 2.2 ( #11168 )
2022-04-05 17:01:45 +00:00
7a4d5b5ec6
Correct a spelling mistake ( #11167 )
2022-04-05 08:39:46 +00:00
9090c01ee7
transactional: Fix some nitpicks ( #11163 )
...
* transactional: Fix some nitpicks
This fixes some nitpicks related to the transactional storage stuff from me. As everything was
merged too fast, here are some nitpicks from me. First, the entire functionality is moved into its
own file to have a clear separation. Secondly I changed the `set_transactional_level` to not take
`Layer` by reference. Besides that I have added some docs etc.
* Add some comment
* Move tests
* 🤦
2022-04-04 22:28:57 +02:00
d3d3df5bfb
Remove not required DigestItem conversion ( #11165 )
2022-04-04 14:29:29 +00:00
b8dbe46b3e
Revert "Replace storage access by atomics" ( #11156 )
...
This reverts commit a69b8eb4a28f365a4a4b2fc295a693ec4d3d3cd5.
2022-04-04 13:19:46 +02:00
6531ed7430
Update kvdb-rocksdb to 0.15.2 ( #11144 )
2022-04-04 09:23:17 +00:00
4eeec5fd47
Bump dyn-clone from 1.0.4 to 1.0.5 ( #11048 )
...
Bumps [dyn-clone](https://github.com/dtolnay/dyn-clone ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/dtolnay/dyn-clone/releases )
- [Commits](https://github.com/dtolnay/dyn-clone/compare/1.0.4...1.0.5 )
---
updated-dependencies:
- dependency-name: dyn-clone
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-04 11:22:18 +02:00
60dd1ea9b8
Bump backtrace from 0.3.63 to 0.3.64 ( #11157 )
...
Bumps [backtrace](https://github.com/rust-lang/backtrace-rs ) from 0.3.63 to 0.3.64.
- [Release notes](https://github.com/rust-lang/backtrace-rs/releases )
- [Commits](https://github.com/rust-lang/backtrace-rs/compare/0.3.63...0.3.64 )
---
updated-dependencies:
- dependency-name: backtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-04 11:21:45 +02:00
41c84b0b41
Remove useless imports ( #11136 )
...
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-04-03 21:44:29 +02:00
98ed4afe45
Bump futures from 0.3.19 to 0.3.21 ( #11133 )
...
Bumps [futures](https://github.com/rust-lang/futures-rs ) from 0.3.19 to 0.3.21.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.19...0.3.21 )
---
updated-dependencies:
- dependency-name: futures
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-03 19:34:13 +00:00
96ee61179a
Add Limit to Tranasctional Layers ( #10808 )
...
* introduce hard limit to transactional
* add single layer transactional
* remove single_transactional
* Update mod.rs
* add tests
* maybe fix contracts cc @athei
* fmt
* fix contract logic
* Update frame/contracts/src/exec.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Update exec.rs
* add unchecked and custom errors
* Update lib.rs
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Replace storage access by atomics
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
2022-04-02 17:12:54 +00:00
2d3ee74805
Refactor Beefy MMR and remove parachain specific implementations ( #10664 )
...
* refactor beefy mmr
* use plain vector of bytes for leaf extra
* update comment
* update comments
* remove unused vars
* Use sp_std::vec::Vec
Co-authored-by: Adrian Catangiu <adrian@parity.io >
* make extra data generic
* fix tests
* refactor beefy-mmr
* Update frame/beefy-mmr/src/lib.rs
* minor fix
* fmt
* Update frame/beefy-mmr/src/lib.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io >
2022-04-01 08:50:11 +00:00
c2d3d488b8
add iter-from for bags-list ( #11104 )
...
* add iter-from for bags-list
* Fix
* Apply suggestions from code review
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-03-31 14:16:34 +00:00
6ec4ee1647
frame-support: Rename tests to express what they are doing ( #11147 )
...
Fixes: https://github.com/paritytech/substrate/issues/11145
2022-03-31 13:13:34 +00:00
Georges