Commit Graph
65 Commits
Author SHA1 Message Date
Niklas AdolfssonandAlexandru Vasile f79fa6c8bd pallet epm: add TrimmingStatus to the mined solution (#1659)
For tools such that is using the `Miner` it's useful to know whether a
solution was trimmed or not and also how much that was trimmed.

---------

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
2023-09-22 19:22:18 +02:00
Niklas Adolfsson ba3f612c57 chore: bump jsonrpsee v0.16.3 (#14820)
Close https://github.com/paritytech/substrate/issues/14814
2023-08-24 14:03:32 +00:00
Niklas Adolfssonandparity-processbot 081fe8b4e4 companion for #14088 (#2539)
* companion for #14088

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: parity-processbot <>
2023-05-07 21:46:00 +00:00
Niklas Adolfssonandparity-processbot 3d32afa608 companion for #14088 (#7192)
* companion for #14088

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
2023-05-07 20:16:03 +00:00
Niklas Adolfsson bd96f00146 fix cli: make port Option<u16> again (#14088) 2023-05-07 19:11:03 +00:00
Niklas Adolfssonparity-processbotmuharem
cb0f623d6f companion for #13384 (#2417)
* companion for #13384

* update rpc cli

* fix missed stuff

* update parachain rpc commands

* update polkadot and substrate deps

* update substrate & polkadot

---------

Co-authored-by: parity-processbot <>
Co-authored-by: muharem <ismailov.m.h@gmail.com>
2023-05-04 10:40:11 +00:00
dcbf8b70f7 companion for #13384 (#6987)
* companion for #13384

* adjust parsing RPC address from process output

* update rpc cli

* update lockfile for {"substrate"}

* bump zombienet v1.3.48

* bump zombienet version

* allow zombienet-tests-misc-upgrade-node to fail

* add comment and issue link to allowed_failure

* grumbles: disable failed job

* disabled the correct test

---------

Co-authored-by: parity-processbot <>
Co-authored-by: Javier Viola <javier@parity.io>
2023-05-04 11:48:08 +02:00
5a1074712a rpc server: break legacy CLI options and remove "backward compatible HTTP server" (#13384)
* jsonrpsee v0.16

* breaking: remove old CLI configs

* remove patch.crates-io

* fix bad merge

* fix clippy

* fix bad merge

* fix grumbles

* Update client/service/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* revert block_in_place

* add issue link in todo

* Update client/cli/src/config.rs

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

* grumbles: add ipv6 loopback address

* Revert "grumbles: add ipv6 loopback address"

This reverts commit 3a0b1ece6c4e36055d666896c29d1da55ffa1c4f.

* remove nits

* bump zombienet version

* adress grumbles: provide structopt default_val_t

* remove duplicate from structopt

* bump zombienet v1.3.47

* bump zombienet version

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Javier Viola <javier@parity.io>
2023-05-03 15:18:25 +00:00
Niklas Adolfsson bf8559a37c staking miner: less aggresive submissions (#6978)
* staking miner: less aggresive submissions

We have noticed that the staking-miner performs many concurrent RPC calls (more than 256).
Probably because these batch request are getting bigger because the state is growing.

So let's relax this and mine solutions sequentially i.e, mine solution
one solution at the time and not in concurrently.

* add check if self hasn't submitted after mining
2023-03-30 16:01:18 +02:00
Niklas Adolfsson 3b0a0aa92d refactor: state RPC remove max_rpc_payload_size (#13649)
This limit is not needed anymore as the JSON-RPC servers doesn't terminate
the connection if the RPC max limit is exceeded anymore
2023-03-21 15:25:33 +00:00
Niklas Adolfssonandparity-processbot b6593bbfa5 companion for #13555 (#6842)
* companion for #13555

* update lockfile for {"substrate"}

* fix: `decl_TryRuntime` -> `decl_for_try_runtime`

---------

Co-authored-by: parity-processbot <>
2023-03-15 14:34:02 +01:00
Niklas Adolfsson 5e3f1b1af5 frame epm: expose feasibility_check in MinerConfig (#13555)
* frame epm: expose feasibity_check in miner

The goal with this commit is to expose the `feasibity_check` such
that anyone that implements the `MinerConfig trait` can utilize it

* cleanup

* fix tests
2023-03-14 22:53:03 +00:00
Niklas Adolfsson acac823a7a companion for #12663 jsonrpsee v0.16 (#1905)
* companion for #12663 jsonrpsee v0.16.1

* update deps

* update rpc client params

* update substrate and polkadot
2022-12-12 12:23:01 +00:00
8db9bb5dfd companion for #12663 jsonrpsee v0.16 (#6339)
* companion for #12663 jsonrpsee v0.16.1

* update substrate

* merge master

* Update rpc/Cargo.toml

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

* Update utils/staking-miner/Cargo.toml

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

* update lockfile for {"substrate"}

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: parity-processbot <>
2022-12-12 12:40:37 +01:00
Niklas Adolfsson 84303ca75d rpc server with HTTP/WS on the same socket (#12663)
* jsonrpsee v0.16

add backwards compatibility

run old http server on http only

* cargo fmt

* update jsonrpsee 0.16.1

* less verbose cors log

* fix nit in log: WS -> HTTP

* revert needless changes in Cargo.lock

* remove unused features in tower

* fix nits; add client-core feature

* jsonrpsee v0.16.2
2022-12-12 10:32:55 +00:00
Niklas Adolfsson 4cc3d4a9fe companion for #12599 (#1881)
* companion for #12599

* update substrate & polkadot
2022-11-15 17:07:19 +00:00
Niklas Adolfssonandparity-processbot 4b9f3aa82c companion for #12599 (#6290)
* companion for #12599

* update Cargo.lock

* use cargo path instead of diener

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-11-15 17:30:50 +01:00
Niklas Adolfsson 2b8af8cb1a release sp-core 7.0.0 and sp-runtime 7.0.0 (#12599)
* chore(release): sp-core v7.0.0

* chore(release): sp-runtime v7.0.0

* fix bad merge
2022-11-15 14:54:14 +00:00
Niklas Adolfsson e1ccb8499d staking miner: remove needless queue check (#6221)
* staking miner: remove needless queue check

If the queue is full and the "mined solution" is better than solutions in the queue according to the "strategy"
then the solution with worse score will be kicked out from the queue.

Thus, the check can be removed completly.

* fix compile warns
2022-11-08 16:19:48 +00:00
Niklas Adolfsson 400ee474a5 companion for #12212 (#6162)
* companion for #12212

* cargo fmt

* fix build

* update Cargo.lock

* update Cargo.lock
2022-10-18 20:09:37 +02:00
e3b269ab0f frame/utils: introduce substrate-rpc-client crate for RPC utils (#12212)
* hack together a PoC

* Update utils/frame/rpc-utils/Cargo.toml

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update utils/frame/rpc-utils/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* rpc_utils -> substrate_rpc_client

* try runtime: remove keep connection

* make CI happy

* cargo fmt

* fix ci

* update lock file

* fix

* fix

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
2022-10-18 16:39:19 +00:00
Niklas Adolfsson d9ea02c09a staking miner: CLI make request and connection timeout configurable (#6004)
* staking miner: CLI request and connection timeout

Make it possible to configure the `connection timeout` and `request timeout` via CLI flags.

* cargo fmt
2022-09-26 20:56:12 +00:00
Niklas Adolfsson 4c280059ab feat(rpc middleware): use custom time buckets (#11950)
* feat(rpc middleware): use custom time buckets

* cargo fmt

* make it compile again

* fix bad comment
2022-08-12 15:39:05 +00:00
Niklas Adolfsson 795afe2747 fix(rpc middleware): fix is_error bug (#11951)
* fix(rpc middleware): fix `is_error` bug

* Update client/rpc-servers/src/middleware.rs
2022-08-02 07:06:36 +00:00
Niklas Adolfsson 6d672f0951 fix(staking miner): check latest state in solution (#5744) 2022-07-01 15:05:01 +00:00
Niklas AdolfssonandDavid ef198a579c staking-miner: CLI flag delay solution x secs (#5734)
* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>
2022-06-30 10:46:37 +00:00
Niklas Adolfsson 21b0d92d31 companion #11661 (#1364)
* bump jsonrpsee v0.14.0

* update Cargo.lock
2022-06-14 22:33:42 +00:00
Niklas Adolfssonandparity-processbot 77f4cab60c Companion for #11661 (#5676)
* bump jsonrpsee v0.14.0

* update Cargo.lock

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-06-14 23:48:31 +02:00
Niklas Adolfsson bed163dceb rpc servers: update jsonrpsee to fix host filtering + WS server-side pings (#11661)
* bump jsonrpsee to fix #11480

In addition it adds WebSocket server-side pings which is configured to
send out pings periodically every 30 seconds.

* use released crates.io version

* Update Cargo.toml
2022-06-14 20:43:25 +00:00
Niklas Adolfsson e9e6916596 remove flaky rpc subscription tests (#11653) 2022-06-14 10:17:58 +02:00
Niklas Adolfsson 69aa11f680 fix: --feature fast-runtime on westend (#5585)
The westend runtime was missing the fast runtime for `EpochDuration`
which caused the epoch be 1 hour which isn't fast.

This PR changes the `EpochDuration` to 2 minutes when `--fast-runtime`
is enabled, the same as polkadot and kusama.
2022-05-24 15:24:43 +00:00
Niklas AdolfssonandJames Wilson c75474f7b8 rpc servers CLI: add --max--subscriptions--per--connection + fix a few bugs (#11461)
* cli: fix RPC CLI nits

* remove needless lines

* cargo fmt

* Update client/service/src/lib.rs

Co-authored-by: James Wilson <james@jsdw.me>

Co-authored-by: James Wilson <james@jsdw.me>
2022-05-21 08:45:57 +00:00
Niklas Adolfsson 96006322bb fix: regression of sync_state_genSyncSpec #11435 (#11437)
* fix: #11435

* address grumbles: better safe than sorry
2022-05-17 16:29:21 +00:00
Niklas Adolfsson d8ba3cf547 companion 11395 (#1253)
* companion for 11395

* companion for 11395

* update polkadot
2022-05-11 15:02:22 +02:00
Niklas Adolfssonandparity-processbot 718380119a companion for #11395 (#5499)
* companion for 11395

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-05-11 14:24:07 +02:00
Niklas Adolfsson 79b1aa5677 jsonrpc http server: expose health endpoint (#11395) 2022-05-11 10:39:39 +00:00
Niklas Adolfsson 6e0ba2da8b update Cargo.lock (#11384) 2022-05-10 16:20:42 +00:00
Niklas Adolfsson 2d506dfcd7 companion #8738 (jsonrpsee) (#823)
* update polkadot and substrate

* add jsonrpsee glue code

* fix tests

* update substrate & polkadot

* update substrate & polkadot

* update Cargo.lock

* revert Cargo.toml

* revert changes in Cargo.toml

* update companion

* revert substrate change

* add Cargo.lock

* update substrate manually

* update polkadot
2022-05-10 12:53:21 +02:00
Niklas Adolfssonandparity-processbot 804d0f38a5 companion for #8783 - jsonrpsee (#4344)
* add jsonrpsee glue code

* diener --substrate dp-jsonrpsee-integration-2

* cargo fmt

* update substrate

* fix build

* update substrate

* fix tests

* update substrate

* update substrate

* revert Cargo.toml

* revert changes in Cargo.toml

* jsonrpsee v0.11

* fix staking miner

* chore: update jsonrpsee v0.12

* update companion

* update companion

* fix changes in substrate

* revert requires_full_sync removal

* fix: read WS address from polkadot output

* fit nits

* fix more nits

* update lockfile for {"substrate"}

* cargo fmt

Co-authored-by: parity-processbot <>
2022-05-10 12:13:38 +02:00
Niklas Adolfssonandparity-processbot e682424034 companion for #11173 (#5264)
* staking miner: update jsonrpsee v0.10.1

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-04-07 10:01:31 +02:00
Niklas Adolfsson 1df943cd6d chore: update jsonrpsee to v0.10.1 (#11173)
* fix(bin/node): remove unsed dep jsonrpsee

* chore(remote ext): update jsonrpsee v0.10.1

* chore(try runtime): update jsonrpsee v0.10.1

* Update utils/frame/try-runtime/cli/src/commands/follow_chain.rs

* cargo fmt
2022-04-07 06:47:36 +00:00
Niklas Adolfsson 4649e767d8 staking miner: Check the queue one last time before submission (#4819)
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* feat: add `ensure_no_better_solution` function

* storage access for submissions and indices

* check ensure_no_previous_solution before remote ext

* fix todos

* grumbles: Perbill::from_percent

* hacky fix

* use modified EPM pallet and various fixes

* diener update --substrate --branch na-epm-pub

* Revert "diener update --substrate --branch na-epm-pub"

This reverts commit b3b9a58c9313372c8f21cf247ba0c8528d9953c0.

* update substrate

* tokio spawn on concurrent stuff

* cleanup

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/monitor.rs

* more cleanup

* fix nits

* address grumbles

* only run batch reqs when signed phase

* better help menu for submission strategy CLI

* add tests for submission strategy
2022-03-04 09:34:02 +00:00
Niklas Adolfssonandparity-processbot 8ea9b676a9 companion for #10945 (#5012)
* companion for #10945

* fix build

* fix bad merge

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-03-03 23:26:05 +00:00
Niklas AdolfssonandParity Bot e6b6c8aac6 [EPM pallet]: remove number of signed submissions (#10945)
* [EPM pallet]: remove `number of signed submissions`

Closing #9229

* fix tests

* remove needless assert

* Update frame/election-provider-multi-phase/src/lib.rs

* cargo fmt

Signed-off-by: Niklas <niklasadolfsson1@gmail.com>

* fix grumbles

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* drop `num_signed_submissions` in WeightInfo too

* fix build

Co-authored-by: Parity Bot <admin@parity.io>
2022-03-03 22:47:10 +00:00
Niklas AdolfssonandKian Paimani 3d5e9b3c9c [staking miner]: add CLI tests + fix --version (#5024)
* staking miner: add CLI tests

* cargo fmt

* fix bad merge

* Update utils/staking-miner/Cargo.toml

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* grumbles: derive PartialEq only for tests

* make test `--version` a integration tests

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2022-03-03 22:43:38 +00:00
Niklas Adolfsson 2893be8321 make submissions pub (#10899) 2022-02-22 09:20:29 +01:00
Niklas Adolfsson 4210d014ec staking miner: reuse ws conn for remote-ext (#4849)
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* fix grumbles

* Update utils/staking-miner/src/monitor.rs

* staking miner: reuse ws conn for remote-ext

* Revert "revert polkadot runtime changes"

This reverts commit 5fddbbec40702c122b079526915cabac8facdbc1.

* cargo fmt

* revert unintentional change

* revert unintentional change

* add type SharedRpcClient

* cargo fmt

* fix nits

* spelling

* use tracing_subcriber and cleanup

* remove some needless clones

* fix some nits

* fix spellcheck
2022-02-18 11:41:56 +00:00
Niklas Adolfssonandparity-processbot 7273c4b03f Companion for refactor election score #10834 (#4927)
* Companion for refactor election score #10834

https://github.com/paritytech/substrate/pull/10834

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-02-16 13:57:31 +01:00
Niklas Adolfsson 188840dca1 staking miner: spawn separate task for each block (#4716)
* staking miner: use config for emergency solution

Fixes #4678

* bump jsonrpsee

* run `monitor_cmd_for` until the connection is closed

* new tokio task for submit_and_watch xt

* re-use header subscription

* update jsonrpsee + simplify code

* revert polkadot runtime changes

* fix grumbles

* Update utils/staking-miner/src/monitor.rs

* grumbles: fix logs + nits
2022-02-07 11:21:56 +01:00
Niklas Adolfsson 3f69a2e1ff remote ext: make it possible to use an existing ws connection (#10737)
* remote ext: make it possible to pass ws client

* grumbles: introduce `map_uri`
2022-01-28 09:04:52 +00:00
Niklas Adolfsson d278b63f6d staking miner: use config for emergency solution (#4694) 2022-01-11 19:30:24 +01:00
Niklas Adolfsson b5583c26b6 fix(staking miner): use StorageKey in getStorage (#4231)
Use `StorageKey` in the rpc call `getStorage` instead of `[u8;32]`
2021-11-06 07:16:00 +00:00
Niklas Adolfssonandparity-processbot 6b1f457078 Companion for #9036 (#3191)
* deps: cargo update -p rustls

* fix build

* update Substrate

Co-authored-by: parity-processbot <>
2021-06-08 16:47:06 +00:00
Niklas Adolfsson 51ee2747d2 deps(jsonrpsee): update to 0.2.0 to avoid alpha (#9036)
The motivation is a couple of bug fixes and not to pin to certain alpha versions.
2021-06-08 16:17:25 +00:00
Niklas Adolfsson 70f008b9f1 update jsonrpsee to 0.2.0-alpha.5 (#8644) 2021-04-21 10:59:15 +00:00
Niklas Adolfsson 0dc9750026 update jsonrpsee to fix a allow(dead_code) (#8302) 2021-03-09 13:42:53 +00:00
6bd09c07bd refactor(remote ext): use jsonrpsee (#8105)
* A clean new attempt

* Checkpoint to move remote.

* A lot of dependency wiring to make it feature gated.

* bad macro, bad macro.

* refactor(remote ext): use jsonrpsee

* refactor(remote ext): use jsonrpsee

* Undo the DB mess.

* fix(remote ext): use max limit `u32::MAX`

* resolve TODOs

* jsonrpsee switch to `hyper` as backend

* Update utils/frame/try-runtime/remote-externalities/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* update jsonrpsee

* remove boiler-plate

* suppress warnings to CI happy

* Unbreak his build

* Use option

* fix nit; make it work again

* fix err message.

* Update utils/frame/remote-externalities/Cargo.toml

* Fix uri stuff

* remove needless clone

Co-authored-by: kianenigma <kian.peymani@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
2021-03-06 15:33:22 +00:00
Niklas Adolfsson 7c6ad9dd1c [client cli] generic blocknumber (#4376)
* rewrite me

* [cli]: make `BlockNumber` generic

* cleanup
2019-12-17 11:45:20 +01:00
Niklas Adolfsson 5f1538b834 cargo update -p smallvec (#2983) 2019-07-01 10:04:43 +02:00
Niklas Adolfsson 549b4e9fb1 fix(compile warn): &mut Trait -> dyn &mut Trait (#2872) 2019-06-15 09:01:37 +02:00
Niklas Adolfsson 5ca761c033 fix(bump protobuf): fix vulnerability (#2654) 2019-05-23 10:28:49 +01:00
Niklas Adolfsson 009898f309 feat(light client): fetch block body from remote (#2527)
* feat(on_demand): block body request

* fix(light block req): no justific + one block

* fix(bad rebase)

* feat(protocol): add messages for `remote_body`

* fix(on demand body): remove needless `take()`

* fix(network): remove messages for `on_demand_body`

* fix(grumbles): use `hash` in `remote_body_requests`

As long as we can't compute `ordered_trie_root(body)` just compare that request.header.hash() == response.header.hash()

* fix(grumbles): `hdr.ext_root == trie_root(body)`

* fix(grumbles): propogate `Err` in `fn body()`

* fix(grumbles): Vec<Block::Extrinsic>

* fix(grumbles): util_fn for `not_impl` in tests

* fix(on remote body): tests `fetch` and `on_demand`

* docs(resolve todos)
2019-05-17 20:05:00 -04:00
Niklas Adolfsson 7e525dc603 fix(telemetry): remove needless Box (#2612) 2019-05-16 20:13:45 -04:00
Niklas Adolfsson e330b69cb9 fix(redundant import) (#2582)
Fixes warning: the item `HashSet` is imported redundantly
2019-05-14 18:07:13 +03:00
Niklas Adolfsson 11da395553 style(on_demand): remove needless wildcards (#2171) 2019-04-02 16:54:02 +02:00