A recent referendum failed because the parachain's sovereign account had
enough funds for the deposit (the runtime at the time required a
deposit) but not enough left over for the existential deposit, which
must remain free.
The current logic does not require a deposit for channels with system
chains, and the current tests check that none is taken. This new test
simply ensures that even without any balance in a parachain's sovereign
account, opening a channel with a system chain will be successful.
This PR allows _username authorities_ to issue unique usernames that
correspond with an account. It also provides two-way lookup, that is
from `AccountId` to a single, "primary" `Username` (alongside
`Registration`) and multiple unique `Username`s to an `AccountId`.
Key features:
- Username Authorities added (and removed) via privileged origin.
- Authorities have a `suffix` and an `allocation`. They can grant up to
`allocation` usernames. Their `suffix` will be appended to the usernames
that they issue. A suffix may be up to 7 characters long.
- Users can ask an authority to grant them a username. This will take
the form `myusername.suffix`. The entire name (including suffix) must be
less than or equal to 32 alphanumeric characters.
- Users can approve a username for themselves in one of two ways (that
is, authorities cannot grant them arbitrarily):
- Pre-sign the entire username (including suffix) with a secret key that
corresponds to their `AccountId` (for keyed accounts, obviously); or
- Accept the username after it has been granted by an authority (it will
be queued until accepted) (for non-keyed accounts like pure proxies or
multisigs).
- The system does not require any funds or deposits. Users without an
identity will be given a default one (presumably all fields set to
`None`). If they update this info, they will need to place the normal
storage deposit.
- If a user does not have any username, their first one will be set as
`Primary`, and their `AccountId` will map to that one. If they get
subsequent usernames, they can choose which one to be their primary via
`set_primary_username`.
- There are some state cleanup functions to remove expired usernames
that have not been accepted and dangling usernames whose owners have
called `clear_identity`.
TODO:
- [x] Add migration to runtimes
- [x] Probably do off-chain migration into People Chain genesis
- [x] Address a few TODO questions in code (please review)
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
- Updates all safe call filters to allow `system::authorize_upgrade`.
- Updates Coretime safe call filter to allow `sudo` and
`system_set_storage`.
- Update Coretime teleports to allow teleportation with other system
chains.
---------
Co-authored-by: Bastian Köcher <info@kchr.de>
Adds the `authorize_upgrade` -> `enact_authorized_upgrade` pattern to
`frame-system`. This will be useful for upgrading bridged chains that
are under the governance of Polkadot without passing entire runtime Wasm
blobs over a bridge.
Notes:
- Changed `enact_authorized_upgrade` to `apply_authorized_upgrade`.
Personal opinion, "apply" more accurately expresses what it's doing. Can
change back if outvoted.
- Remove `check_version` in favor of two extrinsics, so as to make
_checked_ the default.
- Left calls in `parachain-system` and marked as deprecated to prevent
breaking the API. They just call into the `frame-system` functions.
- Updated `frame-system` benchmarks to v2 syntax.
---------
Co-authored-by: command-bot <>
Follow up to fix a bug from #1814 discovered in XCM emulator testing.
I mistakenly thought that checking out an asset would withdraw it from
the sender. This actually withdraws the asset before checking out.
---------
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
The goal of this PR is to migrate Identity deposits from the Relay Chain
to a system parachain.
The problem I want to solve is that `IdentityOf` and `SubsOf` both store
an amount that's held in reserve as a storage deposit. When migrating to
a parachain, we can take a snapshot of the actual `IdentityInfo` and
sub-account mappings, but should migrate (off chain) the `deposit`s to
zero, since the chain (and by extension, accounts) won't have any funds
at genesis.
The good news is that we expect parachain deposits to be significantly
lower (possibly 100x) on the parachain. That is, a deposit of 21 DOT on
the Relay Chain would need 0.21 DOT on a parachain. This PR proposes to
migrate the deposits in the following way:
1. Introduces a new pallet with two extrinsics:
- `reap_identity`: Has a configurable `ReapOrigin`, which would be set
to `EnsureSigned` on the Relay Chain (i.e. callable by anyone) and
`EnsureRoot` on the parachain (we don't want identities reaped from
there).
- `poke_deposit`: Checks what deposit the pallet holds (at genesis,
zero) and attempts to update the amount based on the calculated deposit
for storage data.
2. `reap_identity` clears all storage data for a `target` account and
unreserves their deposit.
3. A `ReapIdentityHandler` teleports the necessary DOT to the parachain
and calls `poke_deposit`. Since the parachain deposit is much lower, and
was just unreserved, we know we have enough.
One awkwardness I ran into was that the XCMv3 instruction set does not
provide a way for the system to teleport assets without a fee being
deducted on reception. Users shouldn't have to pay a fee for the system
to migrate their info to a more efficient location. So I wrote my own
program and did the `InitiateTeleport` accounting on my own to send a
program with `UnpaidExecution`. Have discussed an
`InitiateUnpaidTeleport` instruction with @franciscoaguirre . Obviously
any chain executing this would have to pass a `Barrier` for free
execution.
TODO:
- [x] Confirm People Chain ParaId
- [x] Confirm People Chain deposit rates (determined in
https://github.com/paritytech/polkadot-sdk/pull/2281)
- [x] Add pallet to Westend
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
This PR filters calls from the Identity pallet from all Relay Chain
runtimes as preparation to move the identity state and logic to a system
parachain within each network.
After this change is deployed to a runtime, no more changes such as
adding new sub-identities will be possible. The frozen state will be
part of the genesis state of the system chain. After the system chain
launches, the pallet and all state will be removed from each Relay
Chain.
Applications and UIs that render display information from this pallet
will need to read from the system chain when it launches.
When adding this pallet to the [Coretime
Chain](https://github.com/paritytech/polkadot-sdk/pull/1479), this
dependency results in conflicting implementations (rustc error below).
This toml change fixes it.
```
error: failed to run custom build command for `coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo)`
Caused by:
process didn't exit successfully: `/home/joe/parity/polkadot-sdk/target/debug/build/coretime-rococo-runtime-7943703d2770a119/build-script-build` (exit status: 1)
--- stdout
Information that should be included in a bug report.
Executing build command: RUSTFLAGS="-C target-cpu=mvp -C target-feature=-sign-ext -C link-arg=--export-table -Clink-arg=--export=__heap_base -C link-arg=--import-memory " SKIP_WASM_BUILD="" "/home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=/home/joe/parity/polkadot-sdk/target/debug/wbuild/coretime-rococo-runtime/Cargo.toml" "--color=always" "--profile" "release"
Using rustc version: rustc 1.71.1 (eb26296b5 2023-08-03)
--- stderr
Compiling sp-io v23.0.0 (/home/joe/parity/polkadot-sdk/substrate/primitives/io)
Compiling coretime-rococo-runtime v1.0.0 (/home/joe/parity/polkadot-sdk/cumulus/parachains/runtimes/coretime/coretime-rococo)
error[E0152]: found duplicate lang item `panic_impl`
--> /home/joe/parity/polkadot-sdk/substrate/primitives/io/src/lib.rs:1749:1
|
1749 | pub fn panic(info: &core::panic::PanicInfo) -> ! {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: the lang item is first defined in crate `std` (which `bitvec` depends on)
= note: first definition in `std` loaded from /home/joe/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib/libstd-67dfbacfb4b441ef.rlib
= note: second definition in the local crate (`sp_io`)
For more information about this error, try `rustc --explain E0152`.
```
* remove candidate when to invulnerable
* fix
* candidates to collators
* make parameters consistent and more reasonable
* add call to kick invulnerable candidates
* factor removal into weight
* fix: use accrue instead of add
* make set_invulnerables non-atomic
* benchmark add_invulnerable to account for candidate removal
* don't remove from candidates with set_invulnerables
* fix bounds on benchmarking
* protect against zero min invulnerables underflow
* extra event and tests
* make candidates/invulnerables self-cleaning on session change
* add integrity test
* unused imports
* make rococo-contracts have 1 collator
* change dir names
* cargo toml updates
* fix crate imports for build
* change chain spec names and PR review rule
* update cli to accept asset-hub
* find/replace benchmark commands
* integration tests
* bridges docs
* more integration tests
* AuraId
* other statemint tidying
* rename statemint mod
* chain spec mod
* rename e2e test dirs
* one more Runtime::Statemine
* benchmark westmint
* rename chain spec name and id
* rename chain spec files
* more tidying in scripts/docs/tests
* rename old dir if exists
* Force people to manually do the move.
(Safer as there could be additional considerations with their setup)
* review touchups
* more renaming
* Update polkadot-parachain/src/command.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* better error message
* do not break on-chain spec_name
* log info message that path has been renamed
* better penpal docs
---------
Co-authored-by: gilescope <gilescope@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
* add foreign assets to westmint
* add foreign assets to statemine
* use updated api for ensure origin trait
* Assets/ForeignAssets tests and fixes (#2167)
* Test for create and transfer `TrustBackedAssets` with AssetTransactor
* Test for transfer `local Currency` with AssetTransactor
* Test for create foreign assets (covers foreign relaychain currency)
* Added `ForeignFungiblesTransactor` and test for transfer `ForeignAssets` with AssetTransactor
* Removed unused `pub const Local: MultiLocation`
* Changed `ParaId -> Sibling` for `SiblingParachainConvertsVia`
* Test for create foreign assets (covers local sibling parachain assets)
* Reverted stuff for ForeignCreators from different global consensus (moved to transfer asset branch)
* Refactor `weight_limit` for `execute_xcm`
* Added test for `set_metadata` by ForeignCreator with `xcm::Transact(set_metadata)`
* Renamed `receive_teleported_asset_works` -> `receive_teleported_asset_for_native_asset_works`
* Allow `ForeignCreators` only for sibling parachains
* Unify ReservedDmpWeight/ReservedXcmpWeight usage
* Removed hack - replaced with `MatchedConvertedConcreteId`
* Refactor `ForeignCreators` to assets-common
* Add `ReceiveTeleportedAsset` test
* Change test - `Utility::batch` -> Multiple `xcm::Transact`
* Reusing the same deposits as for TrustBackedAssets
* missing `try_successful_origin` ?
* Finished `ForeignAssets` for westmint (converter, FungiblesApi, tests)
* Refactoring tests - receive_teleported_asset_for_native_asset_works
* ForeignAssets for statemine + refactored `receive_teleported_asset_from_foreign_creator_works`
* Add `ForeignAssets` to statemine `FungiblesApi`
* Add `asset_transactor_transfer_with_local_consensus_currency_works` to all runtimes
* Added `asset_transactor_transfer_with_trust_backed_assets_works` test
* Added `asset_transactor_transfer_with_foreign_assets_works`
* Fix `missing `try_successful_origin` in implementation`
* Added `create_and_manage_foreign_assets_for_local_consensus_parachain_assets_works`
* Added `ExpectTransactStatus` check
* Small rename
* Extended `test_assets_balances_api_works` with ForeignAssets for `statemine`
* PR fixes
* Update parachains/runtimes/assets/test-utils/src/test_cases.rs
---------
Co-authored-by: parity-processbot <>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
* Added `StartsWithExplicitGlobalConsensus` to ignores (#2338)
* Update parachains/runtimes/assets/common/src/lib.rs
Co-authored-by: Gavin Wood <gavin@parity.io>
* include mint and burn in SafeCallFilter
* include mint and burn in SafeCallFilter (statemine)
* clarify doc
* Fix compilation (moved trait `InspectMetadata`)
* Fix test
* Extended test for `teleport` from/to relaychain + `CheckingAccount` (Part I)
* Extended test for `teleport` from/to foreign parachain + `CheckingAccount` (Part II)
* Fixed TODO - `NonLocal` for `ForeignAssets`
* Changed `NonLocal` to `NoChecking`
* Fix weight in test
---------
Co-authored-by: parity-processbot <>
Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
* Remove Default, HasCompact, and TypeInfo trait bounds on AssetId
* don't use default in benchmarking
* add helper trait
* add helper to assets tx payment test
* docs fixes
* i'm confused
* aha, cargo
* move affected dispatchable calls into new indices
* Helper -> BenchmarkHelper
* benchmark use of helper
* actually, don't break every call interface
* use into on AssetIdParameter
* Remove From from AssetIdParameter and use it in BenchmarkHelper
* include from
Co-authored-by: parity-processbot <>
* allow fellows to abdicate voting rights
* rename founders to founding fellows, give equal power
* Drop FoundingFellow role and veto call (#12762)
* drop FoundingFellow role
* drop veto call
* Storage migration to remove founder role (#12766)
* storage migration to remove founder role
* skip migration if no members
* truncate the final fellows set if overflows
* change log - action order
* MemberAbdicated -> FellowAbdicated
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
* add new runtime and remove unnecessary pallets
* make runtime build
* add collectives to collator node
* sketch alliance config in runtime
* Slash handler was supposed to be commented out (for now)
* correct signature
* move to impls
* add alliance to runtime
* rustfmt
* IsReserve, remove Ping, update fn deposit
* add transaction_payment event
* Update parachains/runtimes/collectives/collectives-polkadot/src/lib.rs
Co-authored-by: Squirrel <gilescope@gmail.com>
* fmt
* add genesis config to chain spec
* fix merge
* local and dev configs only (for now)
* remove duplicate imports
* Collectives polkadot runtime to cargo workspace members (#1397)
* Collectives polkadot runtime: use unit type impl for identity verifier (#1398)
* apply fn rename
* fmt
* one less todo
* Less code in magic macros (#1407)
* Less code in magic macros
* cargo fmt
* Bench alliance (#1427)
* add benchmarks
* call one script from the other
* shebang changes so works on nixos too.
* bench in parallel as separate jobs
* hyphens can turn into underscores
* remove workaround to trigger bench
Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
* enable ci jobs
* fix publish bench results jobs
* chainspecs for collectives-westend (#1441)
* initial chainspecs for collections relay chain
* plumb in the collectives-westend chainspec
* add Runtime::CollectivesWestend
* lock
* Collectives: teleport slashed assets (#1433)
* Collectives: teleport slashed assets
* fmt
* Cargo.lock > polkadot-parachain 0.9.25
* create temp account for imbalance
* treasury acc id from pallet id
* move accounts into constants, use here junction for assets
* assets location is relay chain, accounts as parameters
* fix typos
* fix typo
* Update parachains/runtimes/collectives/collectives-polkadot/src/constants.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
* Move alliance proposal provider to impls.rs (#1464)
* Move to impls alliance proposal provider
* rustfmt
* Bumping spec version
(so that we can redeploy with slashing change.)
* cargo lock
* slurp collectives digest to make appear in release notes (#1473)
* add slurp
* Slurp better :)
* Bring some order
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Wilfried Kopp <wilfried@parity.io>
* reorder barrier
* Update parachains/runtimes/collectives/collectives-polkadot/src/xcm_config.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* address review
* clean construct runtime
* fmt
* looks pretty but brings in too much
Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Wilfried Kopp <wilfried@parity.io>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* update readme for current networks
* remove networks docs (they were copy/paste from readme)
* remove trailing whitespace
* add polkadot wiki
* remove hello world name
* remove authors/revision
* /paint to /palette
* rename paint to palette
* rename the modules in palette to be pallets
* update Structure.adoc
* bump impl
* fix CI directory
* Update docs/Structure.adoc
Co-Authored-By: Benjamin Kampmann <ben@gnunicorn.org>
* opening and closing links
* sudo example compiles
* add Aura after it was merged to master
* Timestamp doc testing passes
* Timestamp doc testing works, extraneous lines commented out
* balances
* remove extern crate line
* Removed unneeded code snippet from aura
* make consensus compiles
* executive compiles
* cleanup unnecessary lines
* staking (removed examples that are just copies of tests)
* Apply suggestions from code review
* unindent example
* all the ise
* forgot a misspelling
* a few more replacements
* bump impl
* rollback and fixes
* bump impl again
* Add aliases for RPC
* Update on_demand.rs
* remove TODO
TODO should have been removed after the last update
* add issue link to grandpa config
* add todo with link
* update issue link to substrate
* add issue link
* add issue link
* add issue link
* Update README.adoc
* add parens
* add issue link
* add issue link
* add issue link
* add issue link
* add issue link
* add issue link
* add issue link
* Updated README.adoc
Added a new section with instructions of how to join the Krumme Lanke testnet.
Closes Issue 1217
* Update README.adoc
Instructions for joining Charred Cherry + some minor typos
* Updated Runtime & API in README.adoc
Properties of these functions are changing quickly, updated this section to be more generic.