Commit Graph
98 Commits
Author SHA1 Message Date
Muharem bbaa5a3bb5 Asset Conversion: doc guide to address incorrect exchange rate for non-withdrawable pool (#3275)
This documentation guide to address an incorrect exchange rate for a
non-withdrawable pool.
2024-03-10 21:24:41 +00:00
Muharem 629506ce06 Deprecate xcm::body::TREASURER_INDEX constant, use standard Treasury varian instead (#3608)
Deprecate the `xcm::body::TREASURER_INDEX` constant and use the standard
Treasury variant from the `xcm::BodyId` type instead.

To align with the production runtimes:
https://github.com/polkadot-fellows/runtimes/pull/149
2024-03-07 15:13:17 +00:00
MuharemandSvyatoslav Nikolsky dcc76525d9 Westend/Rococo Asset Hub: pay xcm fees with sufficient assets (#2978)
Set up the `TakeFirstAssetTrader` trader for Westend and Rococo Asset
Hubs to cover XCM fees with sufficient assets.

This PR reintroduces previously
[removed](https://github.com/paritytech/polkadot-sdk/pull/1845) trader
setups, as it was decided to keep both traders, `TakeFirstAssetTrader`
and `SwapFirstAssetTrader`, during the transition period.

---------

Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
2024-01-18 14:04:13 +00:00
2cb39f8dc9 XCM WeightTrader: Swap Fee Asset for Native Asset (#1845)
Implements an XCM executor `WeightTrader`, facilitating fee payments in
any asset that can be exchanged for a native asset.

A few constraints need to be observed:
- `buy_weight` and `refund` operations must be atomic, as another weight
trader implementation might be attempted in case of failure.
- swap credit must be utilized since there isn’t an account to which an
asset of some class can be deposited with a guarantee to meet the
existential deposit requirement. Also, operating with credits enhances
the efficiency of the weight trader -
https://github.com/paritytech/polkadot-sdk/pull/1677

related PRs:
- (depends) https://github.com/paritytech/polkadot-sdk/pull/2031
- (depends) https://github.com/paritytech/polkadot-sdk/pull/1677
- (caused) https://github.com/paritytech/polkadot-sdk/pull/1847
- (caused) https://github.com/paritytech/polkadot-sdk/pull/1876

// DONE: impl `OnUnbalanced` for a `fungible/s` credit
// DONE: make the trader free from a concept of a native currency and
drop few fallible conversions. related issue -
https://github.com/paritytech/polkadot-sdk/issues/1842
// DONE: tests

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
2024-01-16 07:34:48 +00:00
Muharem d288c81b96 pallet-core-fellowship: import an unimported member on approve (#2883)
To align with the documentation of the approve call, we import an
unimported member on approval.

No changes have been made to the benchmarks as they already cover the
worst-case scenario.
2024-01-09 12:36:39 +01:00
4f832ea865 pallet-asset-conversion: Decoupling Native Currency Dependancy (#2031)
closes https://github.com/paritytech/polkadot-sdk/issues/1842

Decoupling Pallet from the Concept of Native Currency

Currently, the pallet is intrinsically linked with the concept of native
currency, requiring users to provide implementations of the
`fungible::*` and `fungibles::*` traits to interact with native and non
native assets. This incapsulates some non-related to the pallet
complexity and makes it less adaptable in contexts where the native
currency concept is absent.

With this PR, the dependence on `fungible::*` for liquidity-supplying
assets has been removed. Instead, the native and non-native currencies'
handling is now overseen by a single type that implements the
`fungibles::*` traits. To simplify this integration, types have been
introduced to facilitate the creation of a union between `fungible::*`
and `fungibles::*` implementations, producing a unified `fungibles::*`
type.

One of the reasons driving these changes is the ambition to create a
more user-friendly API for the `SwapCredit` implementation. Given that
it interacts with two distinct credit types from `fungible` and
`fungibles`, a unified type was introduced. Clients now manage potential
conversion failures for those credit types. In certain contexts, it's
vital to guarantee that operations are fail-safe, like in this impl -
[PR](https://github.com/paritytech/polkadot-sdk/pull/1845), place in
[code](https://github.com/paritytech/polkadot-sdk/blob/20b85a5fada8f55c98ba831964f5866ffeadf4da/cumulus/primitives/utility/src/lib.rs#L429).

Additional Updates:
- abstracted the pool ID and its account derivation logic via trait
bounds, along with common implementation offerings;
- removed `inc_providers` on a pool creation for the pool account;
- benchmarks:
-- swap complexity is N, not const;
-- removed `From<u128> + Into<u128>` bound from `T::Balance`;
-- removed swap/liquidity/.. amount constants, resolve them dynamically
based on pallet configuration;
-- migrated to v2 API;
- `OnUnbalanced` handler for the pool creation fee, replacing direct
transfers to a specified account ID;
- renamed `MultiAssetId` to `AssetKind` aligning with naming across
frame crates;

related PRs:
- (depends) https://github.com/paritytech/polkadot-sdk/pull/1677
- (caused) https://github.com/paritytech/polkadot-sdk/pull/2033
- (caused) https://github.com/paritytech/polkadot-sdk/pull/1876

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
2023-12-20 14:57:26 +02:00
Muharemandjoe petrowski 5ce04514eb pallet-asset-conversion: Swap Credit (#1677)
Introduces a swap implementation that allows the exchange of a credit
(aka Negative Imbalance) of one asset for a credit of another asset.

This is particularly useful when a credit swap is required but may not
have sufficient value to meet the ED constraint, hence cannot be
deposited to temp account before. An example use case is when XCM fees
are paid using an asset held in the XCM executor registry and has to be
swapped for native currency.

Additional Updates:
- encapsulates the existing `Swap` trait impl within a transactional
context, since partial storage mutation is possible when an error
occurs;
- supplied `Currency` and `Assets` impls must be implemented over the
same `Balance` type, the `AssetBalance` generic type is dropped. This
helps to avoid numerous type conversion and overflow cases. If those
types are different it should be handled outside of the pallet;
- `Box` asset kind on a pallet level, unbox on a runtime level - here
[why](https://substrate.stackexchange.com/questions/10039/boxed-argument-of-a-dispatchable/10103#10103);
- `path` uses `Vec` now, instead of `BoundedVec` since it is never used
in PoV;
- removes the `Transfer` event due to it's redundancy with the events
emitted by `fungible/s` implementations;
- modifies the `SwapExecuted` event type;

related issue: 
- https://github.com/paritytech/polkadot-sdk/issues/105

related PRs:
- (required for) https://github.com/paritytech/polkadot-sdk/pull/1845
- (caused) https://github.com/paritytech/polkadot-sdk/pull/1717

// DONE make the pallet work only with `fungibles` trait and make it
free from the concept of a `native` asset -
https://github.com/paritytech/polkadot-sdk/issues/1842

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2023-12-19 18:31:18 +02:00
0b74812ce8 UnionOf types for merged fungible and fungibles implementations (#2033)
Introduces `UnionOf` types, crafted to merge `fungible` and `fungibles`
implementations or two `fungibles` implementations into a single type
implementing `fungibles`.

This also addresses an issue where `ItemOf` initiates a double drop for
an imbalance type, leading to inaccurate total issuance accounting.

Find the application of these types in this PR -
[link](https://github.com/paritytech/polkadot-sdk/pull/2031), places in
code -
[1](https://github.com/paritytech/polkadot-sdk/blob/4ec7496fa2632385b08fae860fcf28a523a7b5de/cumulus/parachains/runtimes/assets/asset-hub-kusama/src/lib.rs#L327),
[2](https://github.com/paritytech/polkadot-sdk/blob/4ec7496fa2632385b08fae860fcf28a523a7b5de/cumulus/parachains/runtimes/assets/asset-hub-kusama/src/lib.rs#L343).

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: joepetrowski <joe@parity.io>
2023-12-19 13:51:05 +01:00
da40d97a23 Westend: Fellowship Treasury (#2532)
Treasury Pallet Instance for the Fellowship in Westend Collectives.

In this update, we present a Treasury Pallet Instance that is under the
control of the Fellowship body, with oversight from the Root and
Treasurer origins. Here's how it is governed:
- the Root origin have the authority to reject or approve spend
proposals, with no amount limit for approvals.
- the Treasurer origin have the authority to reject or approve spend
proposals, with approval limits of up to 10,000,000 DOT.
- Voice of all Fellows ranked at 3 or above can reject or approve spend
proposals, with a maximum approval limit of 10,000 DOT.
- Voice of Fellows ranked at 4 or above can also reject or approve spend
proposals, with a maximum approval limit of 10,000,000 DOT.

Additionally, we introduce the Asset Rate Pallet Instance to establish
conversion rates from asset A to B. This is used to determine if a
proposed spend amount involving a non-native asset is permissible by the
commanding origin. The rates can be set up by the Root, Treasurer
origins, or Voice of all Fellows.

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: joepetrowski <joe@parity.io>
2023-12-08 15:02:09 +02:00
Muharem d0fd266003 Resolve Credit to Account impls of OnUnbalanced trait (#1876)
Implements the `OnUnbalanced` trait to resolve received credits to the
specified account. Credits that fail to resolve are dropped.

### Motivation 
Throughout the codebase, several types implement the trait with the same
behavior. While some currently utilize older currency trait, a migration
to the new fungible/s is anticipated for all. Examples:
[1](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/cumulus/parachains/common/src/impls.rs#L37),
[2](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/polkadot/runtime/common/src/impls.rs#L36),
[3](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/substrate/bin/node/runtime/src/impls.rs#L40),
[4](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/substrate/bin/node/runtime/src/lib.rs#L1969),
[5](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/substrate/frame/broker/src/mock.rs#L198),
[6](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/substrate/frame/society/src/lib.rs#L2031),
[7](https://github.com/paritytech/polkadot-sdk/blob/1b34571c0c423115813034783ddf524aac257bf5/substrate/frame/treasury/src/lib.rs#L1118)
2023-10-23 19:14:52 +02:00
Muharem c422e3f577 extract amount method for fungible/s Imbalance (#1847)
Introduces an `extract` amount method for `fungible/s` `Imbalance`.
2023-10-16 17:16:59 +02:00
cb944dc548 Treasury spends various asset kinds (#1333)
### Summary 

This PR introduces new dispatchables to the treasury pallet, allowing
spends of various asset types. The enhanced features of the treasury
pallet, in conjunction with the asset-rate pallet, are set up and
enabled for Westend and Rococo.

### Westend and Rococo runtimes.

Polkadot/Kusams/Rococo Treasury can accept proposals for `spends` of
various asset kinds by specifying the asset's location and ID.

#### Treasury Instance New Dispatchables:
- `spend(AssetKind, AssetBalance, Beneficiary, Option<ValidFrom>)` -
propose and approve a spend;
- `payout(SpendIndex)` - payout an approved spend or retry a failed
payout
- `check_payment(SpendIndex)` - check the status of a payout;
- `void_spend(SpendIndex)` - void previously approved spend;
> existing spend dispatchable renamed to spend_local

in this context, the `AssetKind` parameter contains the asset's location
and it's corresponding `asset_id`, for example:
`USDT` on `AssetHub`,
``` rust
location = MultiLocation(0, X1(Parachain(1000)))
asset_id = MultiLocation(0, X2(PalletInstance(50), GeneralIndex(1984)))
```

the `Beneficiary` parameter is a `MultiLocation` in the context of the
asset's location, for example
``` rust
// the Fellowship salary pallet's location / account
FellowshipSalaryPallet = MultiLocation(1, X2(Parachain(1001), PalletInstance(64)))
// or custom `AccountId`
Alice = MultiLocation(0, AccountId32(network: None, id: [1,...]))
```

the `AssetBalance` represents the amount of the `AssetKind` to be
transferred to the `Beneficiary`. For permission checks, the asset
amount is converted to the native amount and compared against the
maximum spendable amount determined by the commanding spend origin.

the `spend` dispatchable allows for batching spends with different
`ValidFrom` arguments, enabling milestone-based spending. If the
expectations tied to an approved spend are not met, it is possible to
void the spend later using the `void_spend` dispatchable.

Asset Rate Pallet provides the conversion rate from the `AssetKind` to
the native balance.

#### Asset Rate Instance Dispatchables:
- `create(AssetKind, Rate)` - initialize a conversion rate to the native
balance for the given asset
- `update(AssetKind, Rate)` - update the conversion rate to the native
balance for the given asset
- `remove(AssetKind)` - remove an existing conversion rate to the native
balance for the given asset

the pallet's dispatchables can be executed by the Root or Treasurer
origins.

### Treasury Pallet

Treasury Pallet can accept proposals for `spends` of various asset kinds
and pay them out through the implementation of the `Pay` trait.

New Dispatchables:
- `spend(Config::AssetKind, AssetBalance, Config::Beneficiary,
Option<ValidFrom>)` - propose and approve a spend;
- `payout(SpendIndex)` - payout an approved spend or retry a failed
payout;
- `check_payment(SpendIndex)` - check the status of a payout;
- `void_spend(SpendIndex)` - void previously approved spend;
> existing spend dispatchable renamed to spend_local

The parameters' types of the `spend` dispatchable exposed via the
pallet's `Config` and allows to propose and accept a spend of a certain
amount.

An approved spend can be claimed via the `payout` within the
`Config::SpendPeriod`. Clients provide an implementation of the `Pay`
trait which can pay an asset of the `AssetKind` to the `Beneficiary` in
`AssetBalance` units.

The implementation of the Pay trait might not have an immediate final
payment status, for example if implemented over `XCM` and the actual
transfer happens on a remote chain.

The `check_status` dispatchable can be executed to update the spend's
payment state and retry the `payout` if the payment has failed.

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: command-bot <>
2023-10-07 19:32:35 +02:00
Muharem 7d4f82968c frame-support: RuntimeDebug\Eq\PartialEq impls for Imbalance (#1717)
Derive `RuntimeDebug\Eq\PartialEq` but do not bound any generics.

This achieved by using their equivalent no bound versions:
`EqNoBound\PartialEqNoBound\RuntimeDebugNoBound`.

Deriving with `Debug`, `Eq`, and `PartialEq` for the `Debt` and `Credit`
type aliases of `Imbalance` is not feasible due to the `OnDrop` and
`OppositeOnDrop` generic types lacking implementations of the same
traits.

This absence posed challenges in testing and any scenarios that demanded
the traits implementations for the type.
2023-09-29 23:47:17 +02:00
9e403629d5 The Ambassador Program (#1308)
The Ambassador Program on Polkadot Collectives Parachain

The Polkadot Ambassador Program has existed for a while; more
information can be found
[here](https://wiki.polkadot.network/docs/ambassadors).
In this PR, the program is being brought on chain.

### On Chain Structure
The on-chain program consists of nine ranks, divided into four
categories ([full
list](https://github.com/paritytech/cumulus/blob/c238fb26b75569a11abb57437fd14acd26e05f18/parachains/runtimes/collectives/collectives-polkadot/src/ambassador/mod.rs#L52)):
- Ambassadors (1-2 tiers)
- Senior Ambassadors (3-4 tiers)
- Head Ambassadors (5-7 tiers)
- Master Ambassadors (8-9 tiers)

Each rank has a corresponding `Origin` (e.g., `HeadAmbassadorsTier5` -
[full
list](https://github.com/paritytech/cumulus/blob/c238fb26b75569a11abb57437fd14acd26e05f18/parachains/runtimes/collectives/collectives-polkadot/src/ambassador/origins.rs#L35)),
which represents the collective voice of members of that rank and above.

### Referendum

The `AmbassadorReferenda` instance of [referenda
pallet](https://docs.rs/pallet-referenda/latest/pallet_referenda/)
consists of [nine
tracks](https://github.com/paritytech/cumulus/blob/c238fb26b75569a11abb57437fd14acd26e05f18/parachains/runtimes/collectives/collectives-polkadot/src/ambassador/tracks.rs#L51),
each corresponding to an `Origin`. A referendum taken on `senior
ambassador tier 4` track invites all members from rank 4 or above to
vote and commands `SeniorAmbassadors` `Origin`. Every member gets one
vote plus an additional vote for every excess rank. The referendum
proposal can be submitted by any member of a senior rank or above.

### Membership Management

Initial members will be brought on chain via migration, with subsequent
member management handled through the `AmbassadorCollective` instance of
[ranked collective
pallet](https://docs.rs/pallet-ranked-collective/latest/pallet_ranked_collective/).
Both `Root` and `FellowshipAdmin` `Origins`, commanded via public
Polkadot referendum, can promote or demote members to and from any rank.
Members themselves also have the power to promote or demote via its
referendum, with a senior member vote by the rank two above the new /
current rank - [full
configuration](https://github.com/paritytech/cumulus/blob/9ab6aa47063d7e8b67ddc10d9c136037f99c03a3/parachains/runtimes/collectives/collectives-polkadot/src/ambassador/mod.rs#L67).

### Content Management

The program's on-chain content is managed via the collectives content
pallet, allowing for setting its charter and making announcements. The
voice of head ambassadors have the authority to set the charter, while
announcements can be made by any senior rank member or through a
referendum among all members.

### Additional Functionality

The `AmbassadorCore` instance of [core fellowship
pallet](https://docs.rs/pallet-core-fellowship/latest/pallet_core_fellowship/)
decorates the ranked collectives pallet with features like salary
determination, activity/passivity registration, and the handling of
promotion and demotion periods. While the usage of this pallet is
optional in the first version, future updates will make it the exclusive
method for induction/promotion.

Periodic salaries in USDt, payable on Asset Hub, are introduced through
the [salary
pallet](https://docs.rs/pallet-salary/latest/pallet_salary/). This
requires induction into the ambassador core pallet.

Please for more information on the pallets' functionality refer to their
documentations.

### Next Steps:
- Migrate to seed the program members
- Mint ambassador NFT badges on Asset Hub when promoting
- Treasury pallet instance for the Ambassador Program

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2023-09-20 21:55:56 +02:00
Muharem Ismailov a8e82a365e xcm-builder: PayOverXcm supports fallible convertors for asset kind and beneficiary conversion (#1572)
`PayOverXcm` type accepts two converters to transform the `AssetKind`
and `Beneficiary` parameter types into recognized `xcm` types. In this
PR, we've modified the bounds for these converters, transitioning from
`Convert` to `TryConvert`.

One such use case for this adjustment is when dealing with versioned xcm
types for `AssetKind` and `Beneficiary`. These types might be not
convertible to the latest xcm version, hence the need for fallible
conversion.

This changes required for
https://github.com/paritytech/polkadot-sdk/pull/1333
2023-09-18 11:04:47 +02:00
Muharem IsmailovandOliver Tale-Yazdi 841a33ede4 asset-rate pallet: box asset kind parameter (#1545)
The `AssetKind` type parameter of a dispatchable, defined by the user,
might be large — like `xcm::MultiLocation`. To prevent inflating the
size of the `Call` type, we `Box` it.

This changes required for
https://github.com/paritytech/polkadot-sdk/pull/1333

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2023-09-15 11:52:05 +02:00
Muharem Ismailov 49c4b2014b Enable runtime-benchmarks feature for crates (#1544)
Enable `runtime-benchmarks` feature for `parachain-common` and
`cumulus-primitives-utility` crates' dependencies.

After adding `runtime-benchmarks = []` under `features` category in
`Cargo.toml` files for the creates, I did run,
> zepter lint propagate-feature --feature runtime-benchmarks --workspace
--fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking"

This changes required for
https://github.com/paritytech/polkadot-sdk/pull/1333
2023-09-14 15:38:50 +02:00
Muharem Ismailov dd5fa9fcbe asset-conversion pallet: pool's AccountId derivation warn docs (#14811)
* pool_id docs

* fmt
2023-08-23 00:37:06 +02:00
Muharem Ismailov 59e47aaf6e benchmark script void output file name (#2998) 2023-08-21 08:25:28 +00:00
Muharem Ismailov 3854012268 Pallets: Treasury deprecate propose_spend dispatchable (#14538)
* treasury deprecate dispatchables

* allow deprecated

* allow deprecated for benchmarks

* allow deprecated in tests

* allow deprecated for bounties tests

* deprecation month
2023-08-10 13:35:06 +00:00
a15f573e7d e2e tests for Gov2 (#2944)
* Fellowship e2e tests

* fixes

* fixe wrong result

* Update parachains/integration-tests/e2e/collectives/README.md

* Apply suggestions from code review

Co-authored-by: Squirrel <gilescope@gmail.com>

* fixes

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
2023-08-01 09:17:47 +00:00
Muharem Ismailovandjoe petrowski 99fc51ce3e Pallets: Asset Rate - Rename AssetId to AssetKind, Introduce AssetKindFactory Trait (#14514)
* asset-rate rename asset_id to asset_kind

* asset-rate pallet benchmarks asset kind factory

* rename to SEED

* fixes

* Update frame/asset-rate/src/benchmarking.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* sp-core optional dep

* sp-core included for benchmarks

* sp-core to dev dep

* sp-core add dep prefix

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2023-07-26 14:49:53 +00:00
Muharem Ismailov 20e677bf28 use ext_wrapper instead execute_with (#2893) 2023-07-19 08:53:15 +00:00
2f98b56393 Pallets: Assets destroy_accounts releases the deposit (#14443)
* assset accounts destroy releases the deposit

* enumerate

* Update frame/assets/src/functions.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* import defensive from frame_support

---------

Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: parity-processbot <>
2023-07-01 15:48:53 +00:00
Muharem Ismailov 0105897ab8 Runtime: Success value and reachable location for Polkadot Collectives benchmarks (#2784)
* Runtime: Success value and reachable location for Polkadot Collectives benchmarks

* separate promote origin for benches

* pay with ensure
2023-06-30 18:34:26 +00:00
Muharem Ismailov f8cc95c6b9 Xcm Emulator: prepare XCMP on init (#2711)
* std for pallet-glutton

* fix xcm-emulator init

* headers for it tests
2023-06-08 11:09:48 +00:00
ce0dcd5741 Runtime: Polkadot Fellowship promotion/demotion periods, members activity and salaries (#2607)
* core fellowship

* core fellowship weights

* salary

* weights

* fellowship pot

* registration period 15 days

* use treasury account for salary pay, promotion origin

* decision period for tracks 30 days

* docs

* comment

* Couple of fixes and some refactoring

* Alter curves to be a bit more conservative

* Use `PayOverXcm` for fellowship salary payments

* Docs and remove unneeded code

* Fixes

* Move Fellowship stuff in line with whitepaper

* fix: induction by a single Fellow (not proficient)

* doc fix

* renames, pallet index, allow unpaid for salary pallet

* Fix budget units

* Fixes

* Test sovereign account for Fellowship salaries

* Nice address test

* Fixes

* test for PayOverXcm setup

* Update parachains/runtimes/collectives/collectives-polkadot/src/fellowship/mod.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Gav <gavin@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
2023-06-06 11:48:15 +01:00
Muharem Ismailov 429b1e4de7 descend first (#7327) 2023-06-05 06:50:33 +01:00
Muharem Ismailov 4624856e3e Core-Fellowship: fix origin typo (#14179) 2023-05-19 16:16:58 +00:00
Muharem Ismailovandparity-processbot e17680fde7 Max class voters for ranked collective vote tally (#13313)
* max class voters for vote tally

* fix move

* tests

* rename to GetMaxVoters

* saturating sub

---------

Co-authored-by: parity-processbot <>
2023-05-17 10:58:44 +00:00
Muharem Ismailovandparity-processbot 90de06876a Collectives integration tests xcm v3 (#2221)
* Collectives integration tests xcm v3

* remove comment

* review fixs

---------

Co-authored-by: parity-processbot <>
2023-05-16 15:03:26 +00:00
Muharem Ismailov 0a105eed6f AccountTouch: deposit_required requires asset id (#14147) 2023-05-15 16:08:07 +00:00
Muharem Ismailov 05201c4047 Assets: impl ContainsPair for asset and account IDs (#14119)
* Assets impl ContainsPair for asset and account IDs

* clap version
2023-05-11 15:56:01 +00:00
Muharem Ismailov c89992f391 Collectives: xcm base weights (#2550) 2023-05-10 07:31:01 +00:00
Muharem Ismailovandparity-processbot faf86c5b76 Companion: XCM remote lock config (#2463)
* xcm remote lock config

* rename

* update lockfile for {"polkadot", "substrate"}

---------

Co-authored-by: parity-processbot <>
2023-05-05 14:39:13 +00:00
Muharem Ismailovandparity-processbot 245305be4e XCM remote lock consumers (#6947)
* xcm remote lock consumers

* update xcm pallet config setups

* fix import

* update xcm pallet config setups

* rename consumers to users

* rename

* rename users to consumers, more docs

* correct doc

---------

Co-authored-by: parity-processbot <>
2023-05-05 14:11:35 +00:00
Muharem Ismailovandparity-processbot 97f4a09591 Vote locks for all reasons except RESERVE (#13914)
* Vote locks tip

* except reserve

* reason for delegate

* fix tests

---------

Co-authored-by: parity-processbot <>
2023-04-24 14:57:45 +00:00
Muharem Ismailovandparity-processbot 1f7a6ae9d4 Companion for substrate#13771 (#2410)
* max proposal weight config

* update deps

---------

Co-authored-by: parity-processbot <>
2023-04-19 12:53:03 +00:00
Muharem Ismailovandparity-processbot 2842e2f62c Companion for substrate#13771 (#6983)
* max proposal weight config

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
2023-04-19 11:59:00 +00:00
Muharem Ismailovandparity-processbot f8b77f64f3 Collective pallet: max proposal weight (#13771)
* collective: max proposal weight

* fix test

---------

Co-authored-by: parity-processbot <>
2023-04-19 11:00:27 +00:00
fd2f200265 The Polkadot Fellowship import (#2236)
* Fellowship into Collectives

* cargo.lock

* tracks alias

* allow to send Fellows origin over XCM

* update todos, remove duplication of type

* use Collectives location for Fellows body

* alias for ranks constants

* benchmarks

* proxy for Fellowship

* docs

* correct copyright date

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* rustfmt

* remove council, update origins

* renames

* remove tech committee from promote origin

* renames

* Fellowship import

* test

* rename mod

* fix import

* updated addresses (only ss58 version)

* update addresses

* doc nits

* weights with new api

* update addresses

* fix try runtime

* update addresses

* use pallet api to import the members

* merge fix

* hex-literal version

* add Bradley to the 1 rank

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: parity-processbot <>
2023-04-09 10:26:12 +00:00
Muharem Ismailov f06ad48a4c PR review rules, include all rs files except weights (#6990) 2023-04-04 16:10:13 +02:00
Muharem Ismailovandparity-processbot e524bf0e30 Scheduler pre block limit note (#13231)
Co-authored-by: parity-processbot <>
2023-04-03 10:59:01 +00:00
Muharem Ismailovandjoe petrowski ef0d3fe7af Introduce Fellowship into Collectives (#2186)
* Fellowship into Collectives

* cargo.lock

* tracks alias

* allow to send Fellows origin over XCM

* update todos, remove duplication of type

* use Collectives location for Fellows body

* alias for ranks constants

* benchmarks

* proxy for Fellowship

* docs

* correct copyright date

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* rustfmt

* remove council, update origins

* renames

* remove tech committee from promote origin

* renames

* doc nits

* weights with new api

* sane weights for pallet_scheduler

* XCM tweaks for OpenGov (#2305)

* updated xcm configs for collectives and statemint

* remove xcm send from safe filter

* remove prod_or_fast

* remove empty line

* drop redundant aggregation

* remove match arm duplication

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2023-03-21 13:10:37 +00:00
Muharem Ismailov 16f3bd48b3 Council as SpendOrigin (#6877) 2023-03-15 09:39:20 +00:00
Muharem Ismailovandparity-processbot dfb60f32cd Polkadot XCM Body constants (#6788)
Co-authored-by: parity-processbot <>
2023-03-06 14:43:28 +00:00
Muharem Ismailov 85a5a5db13 constructor for MemberRecord (#13473) 2023-02-27 16:41:23 +00:00
Muharem Ismailov 26b109bb82 Collectives chain xcm filter (#2222) 2023-02-23 02:24:01 +00:00
Muharem Ismailovandparity-processbot 046ef29ece Benchmarks script improvements (#2214)
* Benchmarks script improvements

* EOF

---------

Co-authored-by: parity-processbot <>
2023-02-21 10:26:26 +00:00
Muharem Ismailovandparity-processbot 988a25dd67 Weights for new referenda/democracy extrinsics (#6638)
* Weights for new referenda/democracy extrinsics

* fix

* substrate update

---------

Co-authored-by: parity-processbot <>
2023-02-08 12:21:47 +00:00
cc766cc1c5 Referendum proposal's metadata (#12568)
* referenda metadata

* todo comment

* remove TODO, update rustdocs

* referenda clear_metadata origin signed or root

* referenda metadata unit tests

* drop schema type for referenda metadata

* remove metadata type

* referenda metadata benches

* note different preimages

* metadata for democracy pallet

* metadata democracy pallet tests and benches

* fix cargo clippy

* update docs

* ".git/.scripts/bench-bot.sh" pallet dev pallet_democracy

* ".git/.scripts/bench-bot.sh" pallet dev pallet_referenda

* Update the doc frame/democracy/src/lib.rs

Co-authored-by: Roman Useinov <roman.useinov@gmail.com>

* Update the doc frame/democracy/src/lib.rs

Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>

* reference instead clone for take

Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>

* error rename BadMetadata to PreimageNotExist

* clear metadata within internal_cancel_referendum fn

* remove redundant clone

* collapse metadata api into one set_metadata method

* fmt

* review fixes

* not request preimage on set_metadata

* rename events and update docs

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_democracy

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_referenda

* rename reset_metadata to transfer_metadata

---------

Co-authored-by: command-bot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>
2023-02-08 09:33:34 +01:00
Muharem Ismailovandparity-processbot 3079a17c94 Benchmark's successful origin api update (#13146)
* try successful origin unimplemented by default

* error as a default impl for try_successful_origin

* remove successful_origin func of EnsureOrigin trait

* default impl -> unimplemented!()

* update EnsureOriginWithArg

* fix EnsureOriginWithArg

* prefix unused arg with underscore

* use try_successful_origin instead successful_origin, map err to Weightless

* fix tests

* remove default impl

* unwrap for indirect origin dep

* replace unwrap by expect with a message

---------

Co-authored-by: parity-processbot <>
2023-02-01 03:11:41 +01:00
Muharem Ismailovandparity-processbot 0494cefc72 Update benchmark's successful origin api (#2122)
* Update benchmark's successful origin api

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: parity-processbot <>
2023-01-29 23:34:59 +00:00
Muharem Ismailovandparity-processbot 887d01af5d Update benchmark's successful origin api (#6598)
* Update benchmark's successful origin api

* rustfmt

* unwrap for indirect origin dep

* replace unwrap by expect with a message

---------

Co-authored-by: parity-processbot <>
2023-01-29 22:57:16 +00:00
Muharem Ismailov 513b68c471 Westend Collectives raw chain spec (#2131) 2023-01-24 16:07:50 +01:00
Muharem Ismailov d2fcebef40 debug assert events at genesis (#13217) 2023-01-23 15:39:11 +00:00
Muharem Ismailov d7021c9dc3 Collectives parachain integration tests update (#2036)
* Collectives: update integration tests

* update title
2022-12-23 14:41:48 +00:00
Muharem Ismailovandparity-processbot 29267961f8 Alliance: remove veto weight func (#2030)
* Alliance: remove veto weight func

* update lockfile for {"substrate", "polkadot"}

Co-authored-by: parity-processbot <>
2022-12-22 20:49:52 +00:00
Muharem Ismailovandcommand-bot 614cd04df0 Alliance: remove unused func from weight trait (#13001)
* Alliance: remove unused weight func

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: command-bot <>
2022-12-22 20:12:01 +00:00
Muharem Ismailovandparity-processbot 4e611b11b1 Companion: Accept Kusama StakingAdmin origin (#1865)
* Companion: Accept Kusamsa StakinAdmin origin

* Fellows origin for xcmp queue controller

* plurality bodies to ensure origin

* include root into controller ensure origin

* fix

* use xcm bodies

* rename to more frequent "defense"

Co-authored-by: parity-processbot <>
2022-12-22 12:01:46 +00:00
Muharem IsmailovandOliver Tale-Yazdi 4dc62d7e71 Scheduler: remove empty agenda on cancel (#12989)
* Scheduler: remove empty agenda on cancel

* use iter any

* fix benches

* remove trailing None

* Add CleanupAgendas migration

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fix ci

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Count non-empty agendas in migration

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2022-12-21 15:25:46 +00:00
dd46523f82 Kusama origins as xcm multi_location (#6273)
* Kusamsa origins as xcm multilocation

* Fellows origin index

* origins to xcm plurality body

* cleanup

* fix cargo spellcheck

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* include Fellows into scope

* include Fellows into scope

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
2022-12-21 08:33:01 +00:00
Muharem Ismailovandparity-processbot f29a5af740 Collectives integration tests (#1979)
Co-authored-by: parity-processbot <>
2022-12-13 14:09:42 +00:00
Muharem Ismailovandparity-processbot 0b0cceff0d bounties calls docs fix (#12909)
Co-authored-by: parity-processbot <>
2022-12-12 22:20:21 +00:00
Muharem Ismailov 4d3895a167 Collectives runtime: add query call info api (#1976) 2022-12-09 20:27:40 +00:00
Muharem Ismailovandparity-processbot 1b9f62cd73 Companion for paritytech/substrate#12788 (#6360)
* Companion for paritytech/substrate#12788

* migrations

* rustfmt

* update lockfile for {"substrate"}

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
2022-12-07 14:48:43 +00:00
Muharem Ismailov 3b9d781afc bench assert update (#12866) 2022-12-07 13:57:41 +00:00
Muharem IsmailovandGav 198faaa6f9 Refund referendum submission deposit (#12788)
* optinal submission deposit and migration

* refund submission deposit call, test, bench

* try runtime fixes

* assert for bench

* Only refund cancelled/approved referenda deposits

* update storage version

Co-authored-by: Gav <gavin@parity.io>
2022-12-07 12:20:48 +00:00
Muharem Ismailov aebe87ee30 kusama whitelist pallet preimage dep upgrade (#6392) 2022-12-06 14:51:16 +00:00
Muharem Ismailovandcommand-bot 07117e7913 Whitelist pallet preimage provider upgrade (#12834)
* whitelist preimage provider upgrade

* rustdocs unresolved link error fix

* ".git/.scripts/bench-bot.sh" pallet dev pallet_whitelist

* PreimageHash alias, remove type annotation

Co-authored-by: command-bot <>
2022-12-06 14:51:03 +00:00
Muharem Ismailov 11aabd352c Kusama: approve/reject treasury prop by treasurer (#6354) 2022-12-01 12:22:37 +00:00
ddbf07e0b6 Collectives Alliance: Remove Founder role and veto call (#1902)
* Companion: Remove Founder role and veto call

* wieghts

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: joepetrowski <joe@parity.io>
Co-authored-by: parity-processbot <>
2022-11-25 17:58:31 +00:00
Muharem Ismailovandcommand-bot 6b0466cdf6 Collectives: alliance and collective pallets weights (#1813)
* Collectives: alliance and collective pallets weights

* ".git/.scripts/bench-bot.sh" pallet collectives-polkadot collectives pallet_collective

* ".git/.scripts/bench-bot.sh" pallet collectives-polkadot collectives pallet_alliance

Co-authored-by: command-bot <>
2022-11-08 15:05:03 +00:00
Muharem Ismailovandcommand-bot 153399431b Collective benchmark respects DefaultVote configuration (#12612)
* Collective benchmark respects DefaultVote configuration

* ".git/.scripts/bench-bot.sh" pallet dev pallet_collective

Co-authored-by: command-bot <>
2022-11-03 16:52:57 +00:00
b023dc97c5 Runtime release checklist template update (#1762)
* Runtime release checklist template update

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Squirrel <gilescope@gmail.com>

* remove check

* xcm 50%

* xcm config check update

* post release

* update post release check

* update post release check

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
2022-10-18 11:24:29 +02:00
Muharem Ismailov b668e196b4 Use saturating add for alliance::disband witness data (#12418) 2022-10-04 13:15:57 +00:00
Muharem Ismailov e5fd9d6a29 Westend Collectives chain spec (#1712) 2022-10-02 15:45:06 +00:00
Muharem Ismailov de7aba91d7 Polkadot Collectives chain spec (#1603)
* initial chain spec template

* boot nodes, para ids, name

* para id 1001

* update boot nodes

* add collators accounts and session keys

* add p2p into wss boot nodes pathes

* replace aura raw private keys by ss58

* remove collectives spec

* rename collectives genesis spec into collectives

* Revert "rename collectives genesis spec into collectives"

This reverts commit 60df522a5c3666a9984d87476c2d93f28a2910fb.

* insert wasm into spec
2022-09-29 15:49:36 +00:00
Muharem Ismailov fc97bf456a Bump runtimes transaction version for v9290 (#1647) 2022-09-20 13:36:04 +00:00
Muharem Ismailov b50c9f0355 fix a wrong path to ci script (#1646) 2022-09-20 11:29:38 +00:00
Muharem IsmailovandGiles Cope 981ab19d54 runtimes version to 9290 (#1612)
* runtimes version to 9290

* No need to bump shell

Co-authored-by: Giles Cope <gilescope@gmail.com>
2022-09-12 10:12:06 +00:00
Muharem Ismailov 00babd8eeb Common version pattern for Collectives runtime (#1606) 2022-09-09 08:32:30 +00:00
Muharem Ismailov 66b06e7563 fix release report generation script (#1599) 2022-09-06 11:40:16 +00:00
Muharem Ismailov b9de4af2ef fix release report generation script (#1597) 2022-09-06 08:53:17 +01:00
Muharem Ismailovandparity-processbot caaa2dc6f3 Companion for substrate#12179 (#1593)
* remove funcs not included in ProposalProvider trait anymore

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>
2022-09-05 15:33:26 +00:00
Muharem Ismailovandcommand-bot f919894c84 Alliance pallet: split force_set_members call (#12179)
* Alliance pallet: split force_set_members call

* use counts for event

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: command-bot <>
2022-09-05 15:08:50 +00:00
Muharem Ismailov a9a2fdca7b Alliance pallet: fix func name, fix migration weights (#12174)
* Alliance pallet: fix func name, fix migration weights

* update comment order
2022-09-02 18:54:30 +02:00
8765c22840 Update Cumulus to Latest Substrate and Polkadot Master (#1551)
* proposal provider impl for proposals func

* rustfmt

* impl proposals_count fn

* update lockfile for {"substrate", "polkadot"}

* cargo update pallet-alliance

* cargo update deps

* fix for https://github.com/paritytech/substrate/commit/324a18e3c5cbf333672c54f9367f530ea976928d

* update lockfile for {"substrate", "polkadot"}

* fix try runtime feature flags

* update log target

Co-authored-by: parity-processbot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2022-09-01 17:20:08 +00:00
d8e951758c Alliance pallet: add force_set_members instead of init_members function (#11997)
* Alliance pallet: add force_set_members instead of init_members function

* benchmark with witness data

* remove invalid limit for clear

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Revert "remove invalid limit for clear"

This reverts commit dba54e3071b63bfea908087aef213f4640e3ccbf.

* compile constructor only for test

* Update comments for force_set_members

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

* benchmark - founders count range

* Revert "benchmark - founders count range"

This reverts commit aad16796f8dfed48079fb7f587b8f5b59382cda6.

* witness members count instead votable members count

* update the doc

* use decode_len for witness data checks

* change witness data member count to voting member count; update clear limits

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

* merge master

* fixes after merge master

* revert to cb3e63

* disband alliance and return deposits

* revert debug changes

* weights

* update docs

* update test comments

* Apply Joe suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* rename event from AllianceDisband to AllianceDisbanded

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: command-bot <>
2022-09-01 10:31:32 +00:00
73e5531664 Collectives runtime: alliance pallet upgrade introducing new retirement notice feature (#1573)
* support retirement notice feature

* [ci] Apply cargo-fmt

* use primitive const

* update lockfile for {"substrate", "polkadot"}

Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
Co-authored-by: parity-processbot <>
2022-08-29 21:39:27 +00:00
b74fba5dac Alliance pallet: retirement notice call (#11970)
* Alliance pallet: retirement notice

* add alliance pallet to benchmark list for dev chain

* fix type

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

* link weight generated by bench for retirement_notice method

* migration to clear UpForKicking storage prefix

* rename migration from v1 to v0_to_v1

* Apply suggestions from code review

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* rename `retirement-notice to give-retirement-notice

* Apply suggestions from code review

Co-authored-by: Squirrel <gilescope@gmail.com>

* review fixes: update doc, saturating add, BlockNumber type alias

* add suffix to duratin consts *_IN_BLOCKS

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

* add negative tests (#11995)

* add negative tests

* remove tests powerless asserts checking against announcment origin

* assert bad origin from announcement origin checks

Co-authored-by: muharem <ismailov.m.h@gmail.com>

Co-authored-by: command-bot <>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
2022-08-29 16:02:23 +00:00
Muharem IsmailovandAlexander Theißen 7a0620e07e Transaction payment runtime apis: query call info and fee details (#1535)
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
2022-08-18 11:01:56 +00:00
Muharem Ismailov 219fd5a3ed Transaction payment runtime apis: query call info and fee details (#5871) 2022-08-15 14:39:01 +02:00
Muharem Ismailov e41b90910e Transaction payment runtime api: query call info and fee details (#11819)
* Transaction payment RPC calls: query call info

* transaction payment pallet - runtime api - add query_call info and fee_details

* remove unused deps

* separate call runtime api

* undo fmt for unchanged code

* system config call bounded to GetDispatchInfo, drop Call generic for query call info/fee

* impl GetDispatchInfo for Extrinsics within runtime test-utils

* introduced runtime api methods accept encoded Call instead of Call type

* replace Bytes by Vec, docs for for new api, drop len argument, drop GetDispatchInfo bound from system_Config::Call

* clean up toml and extra impl for dropped bound

* panic if Call can not be decoded

* revert to d43ba2f

* fmt and docs

* rustfmt
2022-08-10 10:36:16 +00:00
Muharem Ismailov 65e24ec498 gitignore dot-underscore (#1488) 2022-08-02 13:12:34 +00:00
Muharem Ismailov 7ad9cb90aa westend xcm: collectives parachain is trusted teleporter (#5798) 2022-07-21 11:50:00 +00:00
Muharem Ismailov bced5732bf Democracy.fast_track not allowed with zero voting period (#11666)
* Democracy.fast_track not allowed with zero voting period

* revert static parameter alter line

* ensure voting period greater zero

* update doc for fast_track

* unit test: instant fast track to the next block referendum is backed

* fix typos in comments
2022-06-27 14:33:58 +00:00
Muharem Ismailov 460c835ce1 README: installation instructions (#1403) 2022-06-24 08:31:51 +00:00