Commit Graph
18 Commits
Author SHA1 Message Date
girazokiandAdrian Catangiu 9a04ebbfb0 [pallet-xcm] fix transport fees for remote reserve transfers (#3792)
Currently `transfer_assets` from pallet-xcm covers 4 main different
transfer types:
- `localReserve`
- `DestinationReserve`
- `Teleport`
- `RemoteReserve`

For the first three, the local execution and the remote message sending
are separated, and fees are deducted in pallet-xcm itself:
https://github.com/paritytech/polkadot-sdk/blob/3410dfb3929462da88be2da813f121d8b1cf46b3/polkadot/xcm/pallet-xcm/src/lib.rs#L1758.

For the 4th case `RemoteReserve`, pallet-xcm is still relying on the
xcm-executor itself to send the message (through the
`initiateReserveWithdraw` instruction). In this case, if delivery fees
need to be charged, it is not possible to do so because the
`jit_withdraw` mode has not being set.

This PR proposes to still use the `initiateReserveWithdraw` but
prepending a `setFeesMode { jit_withdraw: true }` to make sure delivery
fees can be paid.

A test-case is also added to present the aforementioned case

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
2024-03-22 18:48:15 +00:00
girazokiandBastian Köcher 579ef32ddd remove bound on accountID in AssetFeeAsExistentialDepositMultiplier (#3303)
I dont think this bound is required by anything else and it allows now
to use this struct with runtimes that have 20 bytes accounts

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
2024-02-20 23:34:09 +00:00
girazoki 5f8b6f38a3 implement ConversionToAssetBalance in asset-rate (#2903)
Implements the `ConversionToAssetBalance` trait to asset-rate by doing
`1/rate*(balance)`.
2024-02-20 14:28:05 +00:00
girazoki 0956357b60 work with additional key values (#1757)
Add the possibility to inject additional key-values in the
sproof-builder that generates the relay root that gets stored in
parachain-system.

Rationale: pallets that verify additional storage items (not those
verified by parachain-system) from the relay should be able to proof
against the relay root that gets stored in parachain-system. This PR
allows to create provide additional nibles that can later be used for
verifiability in other pallets
2023-11-22 19:29:06 +02:00
girazokiandBastian Köcher 41d912aaed Companion for substrate#13159 (#2136)
* set setMembersOrigin

* Update Substrate & Polkadot

---------

Co-authored-by: Bastian Köcher <info@kchr.de>
2023-02-13 11:49:47 +00:00
girazokiandBastian Köcher 91bb2ae3d0 Companion for substrate #13159 (#6620)
* SetMembersOrigin

* Update Substrate

* Remove bags list from runtime common

---------

Co-authored-by: Bastian Köcher <info@kchr.de>
2023-02-13 11:30:02 +01:00
girazoki 79cde7b126 SetMembers configurable origin (#13159)
* SetMembers configurable origin

* root origin comment replaced

* fmt
2023-02-12 10:43:03 +00:00
girazoki f614752c22 Add event to asset claim (#6029) 2022-10-10 04:39:30 +00:00
girazokiandShawn Tabrizi b74e584e02 Add inspect trait for asset roles (#11738)
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2022-09-13 00:12:09 +00:00
8f2a3a5077 Statemint runtimes to accept sufficient assets as xcm fee payment (#1278)
* point to my branch

* girazoki-add-TakeFirstAssetTrader-to-utility

* Commit lock

* point at custom branch

* add new trader to statemine runtimes

* compiles

* Back to master

* Update last tomls

* Imports up

* remove non-needing imports

* FMT

* log messages properly

* Use TakeRevenue instead of HandleCredit

* Introduce xcm fee handler

* check total supply in tests

* FMT

* fix test

* Start decoupling balance calculation into different traits

* Make traits a bit more generic

* PR suggestions

* add import

* import well

* Place xcmfeesassethandler into parachains common

* fix tests

* config parameters

* Min amount to fee receiver

* Make minimum amount for block author to be at least the ED

* Doc in AssetFeeAsExistentialDepositMultiplier

* saturating sub

* make sure we dont enter twice

* FMT

* fmt again

* adapt tests

* Add doc and struct for weight refund

* Doc

* More doc

* PR suggestions

* store all info related to asset payment as multiasset

* return AssetNotFound instead of TooExpensive

* Use asset transactor to deposit fee

* uninstall from statemint

* R for RUntime and CON for BalanceConverter

* Rework logic to avoid unnecesary match and error

* Rework ED check, also in case of refund

* rework typo

* In case refund makes drop below ED, just refund the difference

* fix test westmint

* clone id

* move test imports to preamble

* move test imports to preamble

* test-utils with builderS

* lock file updated

* remove unused imports

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: joepetrowski <joe@parity.io>
2022-08-03 16:04:13 +00:00
girazokiandjoe petrowski 1579a8a3a4 Add event with XCM executor outcome, which includes weight fee (#1286)
* Add event with XCM executor outcome, which includes weight fee

* Show weight used in processed messages

* remove added event

* named events

* message_id for message_hash

* Update pallets/xcmp-queue/src/lib.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
2022-06-20 13:49:28 +00:00
girazoki 77558aacc9 fix pallet-xcm toml related to runtime-benchmarks (#5561)
* fix tomls

* Remove xcm-builder from runtime-benchmarks

* Maintain order in toml
2022-05-20 07:32:58 +02:00
girazokiandBastian Köcher f41f8a0740 Default not implemented for non-std builds for PersistedValidationData (#1207)
* Default not implemented for non-std builds for PersistedValidationData

* Remove v1

* Remove v1 for v2, this time correct

* More reverts of v1 for v2

* Update pallets/parachain-system/src/lib.rs

* fmt

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-04-22 22:35:47 +02:00
girazoki d3c7d88548 Make sure when storage is empty we set the block number (#1197) 2022-04-21 21:18:09 +02:00
girazoki 4db9ff03a2 Implement set_block_number for runtime-bencmarks in RelayBlockNumberProiver (#1187) 2022-04-21 10:23:20 +02:00
girazokiandBastian Köcher 074ff19dbc maybe_total_supply in pallet-assets (#10799)
* maybe_total_supply in pallet-assets

* Update frame/assets/src/functions.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2022-02-05 11:06:44 +00:00
girazokiandShawn Tabrizi 48a524c565 Add low level traits to retrieve name, symbol, decimals and allowance in pallet-assets (#9757)
* Add ERC20 compatible trait to retrieve name, symbol, decimals and allowance

* delegate instead of spender

* Remove erc20 trait and divide it into lower level traits

* add import

* approvals and metadata depend on fungibles

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2021-10-07 14:29:48 +00:00
girazokiandBastian Köcher b9e968fb3f Add setter configurable only for benchmarking or tests (#9668)
* Add setter configurable only fior benchmarking or tests

* Update primitives/runtime/src/traits.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-09-09 12:45:16 +02:00